u-boot.git/drivers/mtd, branch v2022.07

mtd: mxs_nand_spl: fix nand_command protocol violation

2022-06-29T13:26:44+00:00

mxs_nand_command() implementation assume that it's working with a
LP NAND, which is a common case nowadays and thus uses two bytes
for column address.

However this is wrong for NAND_CMD_READID and NAND_CMD_PARAM, which
expects only one byte of column address, even for LP NANDs.
This leads to ONFI detection problem with some NAND manufacturer (like
Winbond) but not with others (like Samsung and Spansion)

We fix this with a simple workaround to avoid the 2nd byte column address
for those two commands.

Also align the code with nand_base to support 16 bit devices.

Tested on an iMX6SX device with:
* Winbond W29N04GVSIAA
* Spansion S34ML04G100TF100
* Samsung K9F4G08U00

Tested on imx8mn device with:
* Windbond W29N04GV

Signed-off-by: Andrea Scian 
CC: Stefano Babic 
Signed-off-by: Michael Trimarchi 
Reviewed-by: Fabio Estevam

spi: spi_flash_probe_bus_cs() rely on DT for spi speed and mode

2022-05-23T13:33:10+00:00

Now, spi_flash_probe_bus_cs() relies on DT for spi speed and mode
and logically calls spi_get_bus_and_cs(). In case spi mode and speed are
not read from DT, make usage of spi_flash_probe() instead.

To sum-up:
 - Previous call tree was:
    spi_flash_probe() -> spi_flash_probe_bus_cs() -> spi_get_bus_and_cs()

 - Current call tree is:
    spi_flash_probe() -> _spi_get_bus_and_cs()
    spi_flash_probe_bus_cs() -> spi_get_bus_and_cs()

This patch impacts the following :
  - cmd/sf.c: if spi mode and/or speed is passed in argument of
    do_spi_flash_probe(), call spi_flash_probe() otherwise call
    spi_flash_probe_bus_cs().

  - drivers/net/fm/fm.c: as by default spi speed and mode was set to
    0 and a comment indicates that speed and mode are read from DT,
    use spi_flash_probe_bus_cs().

  - drivers/net/pfe_eth/pfe_firmware.c: spi speed and mode are not read
    from DT by all platforms using this driver, so keep legacy and replace
    spi_flash_probe_bus_cs() by spi_flash_probe();

  - drivers/net/sni_netsec.c : spi speed and mode are not read from DT,
    so replace spi_flash_probe_bus_cs() by spi_flash_probe().

  - drivers/usb/gadget/max3420_udc.c: Can't find any platform which make
    usage of this driver, nevertheless, keep legacy and replace
    spi_get_bus_and_cs() by _spi_get_bus_and_cs().

  - env/sf.c: a comment indicates that speed and mode are read
    from DT. So use spi_flash_probe_bus_cs().

Signed-off-by: Patrice Chotard 

Cc: Marek Behun 
Cc: Jagan Teki 
Cc: Vignesh R 
Cc: Joe Hershberger 
Cc: Ramon Fried 
Cc: Lukasz Majewski 
Cc: Marek Vasut 
Cc: Wolfgang Denk 
Cc: Simon Glass 
Cc: Stefan Roese 
Cc: "Pali Rohár" 
Cc: Konstantin Porotchkin 
Cc: Igal Liberman 
Cc: Bin Meng 
Cc: Pratyush Yadav 
Cc: Sean Anderson 
Cc: Anji J 
Cc: Biwen Li 
Cc: Priyanka Jain 
Cc: Chaitanya Sakinam

spi: spi-uclass: Add new spi_get_bus_and_cs() implementation

2022-05-23T13:33:10+00:00

Move legacy spi_get_bus_and_cs() code to _spi_get_bus_and_cs().

Add new spi_get_bus_and_cs() implementation which rely on DT
for speed and mode and don't need any drv_name nor dev_name
parameters. This will prepare the ground for next patch.

Update all callers to use _spi_get_bus_and_cs() to keep the
same behavior.

Signed-off-by: Patrice Chotard 

Cc: Marek Behun 
Cc: Jagan Teki 
Cc: Vignesh R 
Cc: Joe Hershberger 
Cc: Ramon Fried 
Cc: Lukasz Majewski 
Cc: Marek Vasut 
Cc: Wolfgang Denk 
Cc: Simon Glass 
Cc: Stefan Roese 
Cc: "Pali Rohár" 
Cc: Konstantin Porotchkin 
Cc: Igal Liberman 
Cc: Bin Meng 
Cc: Pratyush Yadav 
Cc: Sean Anderson 
Cc: Anji J 
Cc: Biwen Li 
Cc: Priyanka Jain 
Cc: Chaitanya Sakinam

mtd: nand: mxs_nand_spl: Fix bad block skipping

2022-05-20T10:36:47+00:00

The specific implementation was having bug. Those bugs are since
the beginning of the implementation. Some manufactures can already
experience this bug in their SPL code. This bug can be more visible on
architecture that has complicated boot process like imx8mn. Older
version of uboot can be affected if the bad block
appear in correspoding of the beginning of u-boot image. In order to
adjust the function we scan from the first erase block.

The problematic part of old code was in this part:

while (is_badblock(mtd, offs, 1)) {
           page = page + nand_page_per_block;
          /* Check i we've reached the end of flash. */
          if (page >= mtd->size >> chip->page_shift) {
                      free(page_buf);
                      return -ENOMEM;
         }
}

Even we fix it adding increment of the offset of one erase block size
, we don't fix the problem, because the first erase block where the
image start is not checked. The code was tested on an imx8mn where
the boot rom api was not able to skip it. This code is used by other
architecures like imx6 and imx8mm

Cc: Han Xu 
Cc: Fabio Estevam 
Acked-by: Han Xu 
Tested-By: Tim Harvey 
Signed-off-by: Michael Trimarchi

nand: raw: mxs_nand: Fix specific hook registration

2022-05-20T10:36:47+00:00

Move the hook after nand_scan_tail is called. The hook must be replaced
to the mxs specific one but those must to be assignment later in the
probe function.

With this fix markbad is working again. Before this change:

nand markbad 0xDEC00
NXS NAND: Writing OOB isn't supported
NXS NAND: Writing OOB isn't supported
block 0x000dec00 NOT marked as bad! ERROR 0

Cc: Han Xu 
Cc: Fabio Estevam 
Acked-by: Han Xu 
Tested-By: Tim Harvey 
Signed-off-by: Michael Trimarchi

mtd: rawnand: mxs_nand: Fix use_minimum_ecc for spl driver

2022-05-19T19:39:36+00:00

Because mxs_nand_spl driver does not support DM, to use the minimum ECC
layout, it needs to handle the CONFIG_NAND_MXS_USE_MINIMUM_ECC.

Signed-off-by: Ye Li 
Reviewed-by: Han Xu

Convert CONFIG_MTD_CONCAT to Kconfig

2022-05-11T13:22:24+00:00

This converts the following to Kconfig:
  CONFIG_MTD_CONCAT

Signed-off-by: Chris Packham 
Reviewed-by: Tom Rini 
Reviewed-by: Stefan Roese

Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-spi

2022-05-04T13:04:43+00:00

- NPCM7xx FIU SPI driver (Jim Liu)
- AT45DB641E dataflash (Luca Ellero)

pci: Add mask parameter to dm_pci_map_bar()

2022-05-03T22:33:29+00:00

Add a mask parameter to control the lookup of the PCI region from which
the mapping can be made.

Signed-off-by: Andrew Scull 
Reviewed-by: Bin Meng

pci: Map bars with offset and length

2022-05-03T19:50:46+00:00

Evolve dm_pci_map_bar() to include an offset and length parameter. These
allow a portion of the memory to be mapped and range checks to be
applied.

Passing both the offset and length as zero results in the previous
behaviour and this is used to migrate the previous callers.

Signed-off-by: Andrew Scull 
Reviewed-by: Bin Meng