u-boot.git/drivers/net/eth-phy-uclass.c, branch v2024.01

net: phy: Handle reset-delay-us/reset-post-delay-us properties

2023-06-10T11:34:05+00:00

These two properties are used by various DTs in place of
current reset-assert-us/reset-deassert-us , handle both .

Signed-off-by: Marek Vasut 
Reviewed-by: Ramon Fried

net: eth-phy: staticize eth_phy_reset()

2023-06-10T11:34:04+00:00

The eth_phy_reset() is not used outside of this file, staticize it.
No functional change.

Signed-off-by: Marek Vasut 
Reviewed-by: Ramon Fried

net: eth-phy: prevent undesired de-assertion of phy-reset on request

2022-04-10T05:44:13+00:00

When gpio_request_by_name allocates a gpio output it by default will
de-assert the gpio which for phy-reset will take the PHY out of reset.
As this occurs before eth_phy_reset is called to assert the reset
line it can cause undesired affects if reset timings are not properly
met.

Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active
(reset asserted) to avoid this.

Cc: Sean Anderson 
Signed-off-by: Tim Harvey 
Acked-by: Joe Hershberger 
Reviewed-by: Ramon Fried

net: eth-phy: Demote missing phy-handle log message to debug

2022-01-15T16:51:49+00:00

Reduce the missing phy-handle log message to debug message. It is
possible for ethernet DT node to have no phy-handle e.g. in case
of a fixed-link connection. Furthermore, drop the FEC: prefix,
which is a copy-paste error and rather print the ethernet device
name.

Signed-off-by: Marek Vasut 
Cc: Ramon Fried 
Reviewed-by: Ramon Fried

net: eth-phy: Handle gpio_request_by_name() return value

2021-12-02T06:35:37+00:00

The gpio_request_by_name() returns zero in case of success, however the
conditional return value check in gpio_request_by_name() checks only for
(ret != -ENOENT) and if the condition is true, returns ret outright.

This leads to a situation where successful gpio_request_by_name() return
leads to immediate successful eth_phy_of_to_plat() return as well, and
to skipped parsing of "reset-assert-us" and "reset-deassert-us", so the
PHY driver operates with valid reset GPIO, but with assert/deassert times
set to default, which is 0, instead of the values from DT. This breaks
PHY reset.

Fix this by checking if return value is non-zero and then for this one
single allowed non-zero return value, -ENOENT.

Signed-off-by: Marek Vasut 
Cc: Ramon Fried 
Reviewed-by: Ramon Fried

net: eth-phy: define LOG_CATEGORY

2021-07-22T19:09:27+00:00

Define LOG_CATEGORY to allow filtering with log command.

Signed-off-by: Patrick Delaunay 
Reviewed-by: Ramon Fried

net: eth-phy: manage subnode mdio0

2021-07-22T19:05:44+00:00

Bind any subnode with name beginning by mdio, mdio0 for example,
and not only the "mdio" as namei of subnode.

Reviewed-by: Ramon Fried 
Signed-off-by: Patrick Delaunay

net: eth-phy: use dev_dbg and log_notice

2021-07-22T19:05:44+00:00

Replace debug trace and printf to log macros:
- debug() replaced by dev_dbg() when device is available, this macro
indicate the device name since commit ceb70bb870ac ("dm: Print device
name in dev_xxx like Linux")
- printf() replaced by log_notice() to allow  dispatch to log backends.

Reviewed-by: Ramon Fried 
Signed-off-by: Patrick Delaunay

net: eth-phy: add support of device tree configuration for gpio reset

2021-07-22T19:05:28+00:00

The gpio reset and the assert or deassert delay are defined in generic
binding of the ethernet phy in Linux:
Documentation/devicetree/bindings/net/ethernet-phy.yaml

  reset-gpios:
    maxItems: 1
    description:
      The GPIO phandle and specifier for the PHY reset signal.

  reset-assert-us:
    description:
      Delay after the reset was asserted in microseconds. If this
      property is missing the delay will be skipped.

  reset-deassert-us:
    description:
      Delay after the reset was deasserted in microseconds. If
      this property is missing the delay will be skipped.

See also U-Boot: doc/device-tree-bindings/net/phy.txt

This patch adds the parsing of this common DT properties in the
u-class "eth_phy_generic", used by default in the associated driver
"eth_phy_generic_drv"

This parsing function eth_phy_of_to_plat can be reused by other
ethernet phy drivers for this uclass UCLASS_ETH_PHY.

Signed-off-by: Patrick Delaunay 
Reviewed-by: Ramon Fried

dm: Use access methods for dev/uclass private data

2021-01-05T19:24:40+00:00

Most drivers use these access methods but a few do not. Update them.

In some cases the access is not permitted, so mark those with a FIXME tag
for the maintainer to check.

Signed-off-by: Simon Glass 
Acked-by: Andy Shevchenko 
Acked-by: Pratyush Yadav