u-boot.git/drivers/tpm, branch v2018.09

tpm: sandbox: fix wrong assignment with a simplification

2018-08-13T18:04:04+00:00

The recv variable in sandbox_tpm2_fill_buf() is a pointer on a pointer
of a char array. It means accessing *recv is the char array pointer
itself while **recv is the first character of that array. There is no
need for such indirection here, so simplify the code.

Simplifying things will make the last assignment right: "*recv = NULL"
is now correct. The issue has been found by the following Coverity
Scan report:

    CID 183371:  Incorrect expression  (UNUSED_VALUE)
    Assigning value "4UL" to "*recv" here, but that stored value is overwritten before it can be used.
    232             *recv += sizeof(rc);
    233
    234             /* Add trailing \0 */
    235             *recv = NULL;

While at simplifying things, use '\0' instead of NULL when adding an
empty char at the end of the buffer.

Reported-by: Tom Rini 
Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass

tpm: sandbox: fix wrong check on pcr_map

2018-08-13T18:04:04+00:00

The second check on pcr_map in sandbox_tpm2_xfer() is wrong. It should
check for pcr_map not being empty. Instead, it is a pure copy/paste of
the first check which is redundant.

This has been found thanks to a Coverity Scan report:

    CID 183370:  Memory - illegal accesses  (UNINIT)
    Using uninitialized value "pcr_index".
        put_unaligned_be32(tpm->pcr_extensions[pcr_index], recv);

This is because pcr_index is initialized only if the user input is
correct, ie. at least one valid bit is set in pcr_map.

Fix the second check and also initialize pcr_index to 0 (which is
harmless in case of error) to make Coverity Scan happy.

Reported-by: Tom Rini 
Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass

tpm: make TPM_V2 be compiled by default

2018-07-28T15:58:09+00:00

TPM_V1 was already compiled by default. Now that both can be compiled
at the same time, compiled them both by default.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass

tpm: allow TPM v1 and v2 to be compiled at the same time

2018-07-28T15:57:38+00:00

While there is probably no reason to do so in a real life situation, it
will allow to compile test both stacks with the same sandbox defconfig.

As we cannot define two 'tpm' commands at the same time, the command for
TPM v1 is still called 'tpm' and the one for TPM v2 'tpm2'. While this
is the exact command name that must be written into eg. test files, any
user already using the TPM v2 stack can continue to do so by just writing
'tpm' because as long as TPM v1 support is not compiled, U-Boot prompt
will search for the closest command named after 'tpm'.

The command set can also be changed at runtime (not supported yet, but
ready to be), but as one can compile only either one stack or the other,
there is still one spot in the code where conditionals are used: to
retrieve the v1 or v2 command set.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass 
[trini: In sandbox_tpm2_fill_buf() use NULL not \0 to ensure NULL
terminated string due to LLVM warning]
Signed-off-by: Tom Rini

tpm: remove stale symbol in Kconfig

2018-07-28T15:55:32+00:00

The TPM_DRIVER_SELECTED symbol was used in one of the initial series
about TPMv2 but its use has been dropped, making these selects
useless, remove them.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass

tpm: compile Sandbox driver by default

2018-07-28T15:55:32+00:00

When Sandbox and the TPM stack are both selected, compile Sandbox TPM
driver by default.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass

tpm: add a Sandbox TPMv2.x driver

2018-05-26T00:13:00+00:00

This driver can emulate all the basic functionalities of a TPMv2.x
chip and should behave like them during regular testing.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass 
Reviewed-by: Tom Rini

tpm2: tis_spi: add the possibility to reset the chip with a gpio

2018-05-26T00:12:59+00:00

On some designs, the reset line could not be connected to the SoC reset
line, in this case, request the GPIO and ensure the chip gets reset.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass

tpm: add support for TPMv2.x SPI modules

2018-05-26T00:12:59+00:00

Add the tpm2_tis_spi driver that should support any TPMv2 compliant
(SPI) module.

Signed-off-by: Miquel Raynal 
Reviewed-by: Tom Rini 
Reviewed-by: Simon Glass

tpm: prepare support for TPMv2.x commands

2018-05-26T00:12:55+00:00

Choice between v1 and v2 compliant functions is done with the
configuration.

Create the various files that will receive TPMv2-only code on the same
scheme as for the TPMv1 code.

Signed-off-by: Miquel Raynal 
Reviewed-by: Simon Glass 
Reviewed-by: Tom Rini