u-boot.git/drivers/usb/dwc3/core.c, branch v2018.03

usb: dwc3: gadget: make cache-maintenance on event buffers more robust

2017-04-14T14:44:16Z

Merely using dma_alloc_coherent does not ensure that there is no stale data left in the caches for the allocated DMA buffer (i.e. that the affected cacheline may still be dirty). The original code was doing the following (on AArch64, which translates a 'flush' into a 'clean + invalidate'): # during initialisation: 1. allocate buffers via memalign => buffers may still be modified (cached, dirty) # during interrupt processing 2. clean + invalidate buffers => may commit stale data from a modified cacheline 3. read from buffers This could lead to garbage info being written to buffers before reading them during even-processing. To make the event processing more robust, we use the following sequence for the cache-maintenance: # during initialisation: 1. allocate buffers via memalign 2. clean + invalidate buffers (we only need the 'invalidate' part, but dwc3_flush_cache() always performs a 'clean + invalidate') # during interrupt processing 3. read the buffers (we know these lines are not cached, due to the previous invalidation and no other code touching them in-between) 4. clean + invalidate buffers => writes back any modification we may have made during event processing and ensures that the lines are not in the cache the next time we enter interrupt processing Note that with the original sequence, we observe reproducible (depending on the cache state: i.e. running dhcp/usb start before will upset caches to get us around this) issues in the event processing (a fatal synchronous abort in dwc3_gadget_uboot_handle_interrupt on the first time interrupt handling is invoked) when running USB mass storage emulation on our RK3399-Q7 with data-caches on. Signed-off-by: Philipp Tomsich

usb: dwc3: fix build warnings

2015-12-06T23:14:59Z

fix the following build warnings: drivers/usb/dwc3/core.c: In function ‘dwc3_uboot_init’: drivers/usb/dwc3/core.c:625:6: warning: ‘dev’ is used uninitialized in this function [-Wuninitialized] mem = devm_kzalloc(dev, sizeof(*dwc) + DWC3_ALIGN_MASK, GFP_KERNEL); ^ drivers/usb/dwc3/dwc3-omap.c: In function ‘dwc3_omap_uboot_init’: drivers/usb/dwc3/dwc3-omap.c:380:7: warning: ‘dev’ is used uninitialized in this function [-Wuninitialized] omap = devm_kzalloc(dev, sizeof(*omap), GFP_KERNEL); Signed-off-by: Felipe Balbi

usb: dwc3: Fix warnings on 64-bit builds

2015-11-03T16:29:54Z

Change aritmentics to use 64bit types to be compatible with 64bit builds. Signed-off-by: Michal Simek

usb: dwc3: optimize interrupt loop

2015-04-14T03:48:12Z

There is no point in calling dwc3_thread_interrupt() if no event is pending. There is also no point in flushing event cache in EVERY loop iteration. Signed-off-by: Marek Szyprowski

usb: dwc3: make dwc3_set_mode to static

2015-04-14T03:48:12Z

This commit makes the dwc3_set_mode() as static, to prevent collisions. Signed-off-by: Joonyoung Shim Signed-off-by: Lukasz Majewski

dwc3: flush the buffers before using it

2015-04-14T03:48:10Z

In the linux kernel, non cacheable buffers are used. However in uboot since there are no APIs to allocate non cacheable memory, all the buffers should be flushed before using it. Signed-off-by: Kishon Vijay Abraham I

dwc3: core: added an API to invoke irq handlers

2015-04-14T03:48:10Z

Since interrupt support is not present in u-boot, added an API to handle the interrupts in dwc3 core. This API can be polled to handle the interrupts. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Lukasz Majewski

dwc3: core: add support for multiple dwc3 controllers

2015-04-14T03:48:10Z

Added support for multiple dwc3 controllers. This gives uboot the capability to control multiple dwc3 controllers. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Lukasz Majewski

dwc3: core: change probe and remove to uboot init and uboot exit code

2015-04-14T03:48:09Z

Removed probe and remove that are specific to linux and replaced it with uboot init and uboot exit. These functions will be invoked from boardfile. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Lukasz Majewski

usb: dwc3: core: make dwc3 core build in uboot

2015-04-14T03:48:09Z

*) Changed the include header files to that used in u-boot. *) Removed phy_* APIs *) Removed jiffies and used a simple while loop *) Used dma_alloc_coherent and dma_free_coherent APIs of u-boot *) Fixed other misc warnings Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Lukasz Majewski