u-boot.git/drivers, branch v2019.07-rc4

Merge branch 'master' of git://git.denx.de/u-boot-spi

2019-06-10T13:43:11+00:00

- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

spi: mpc8xxx: Convert to DM

2019-06-10T12:29:49+00:00

Support DM in the MPC8xxx SPI driver, and remove the legacy SPI
interface.

Signed-off-by: Mario Six 
Signed-off-by: Jagan Teki

spi: mpc8xxx: Use get_timer

2019-06-10T12:29:49+00:00

The comment before the transmission loop in conjunction with the
definition of SPI_TIMEOUT as 1000 implies that the loop is supposed to
have a timeout value of 1000 ms. But since there is no mdelay(1) or
similar in the loop body, the loop just runs 1000 times, without regard
for the time elapsed.

To correct this, use the standard get_timer functionality to properly
time out the loop after 1000 ms.

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Fix if check

2019-06-10T12:29:49+00:00

Decreasing the bit length and increasing the write data pointer should
be done when there are more than 32 bit of data, not 16 bit.

This did not produce incorrect behavior, because the only time where the
two checks produce different outcomes is the case of 16 < bitlen < 32,
and in this case the subsequent transmission is the last one regardless,
hence the additional bit length decrease and write data pointer increase
has no effect anyway.

Still, the correct check is the check for "bitlen > 32", so correct this
behavior.

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Re-order transfer setup

2019-06-10T12:29:49+00:00

Minize the time the adapter is disabled (via SPI_MODE_EN
clearing/setting) to just the character length setting, and only set up
the temporary data writing variable right before we need it, so there is
a more clear distinction between setting up the SPI adapter, and setting
up the data to be written.

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Document LEN setting better

2019-06-10T12:29:49+00:00

Instead of having a table right before the code implementing the length
setting for documentation, have inline comments for the if branches
actually implementing the length setting described table's entries
(which is readable thanks to the set_char_len function).

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Rename variable

2019-06-10T12:29:49+00:00

The variable "char_size" holds the number of bits to be transferred in
the current loop iteration. A better name would be "xfer_bitlen", which
we rename this variable to.

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Make code more readable

2019-06-10T12:29:48+00:00

Introduce the to_prescale_mod and set_char_len inline functions to make
the code more readable.

Note that the added "if (bitlen > 16)" check does not change the
semantics of the current code, and hence only preserves the current
error (this will be fixed in a later patch in the series).

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Reduce scope of loop variables

2019-06-10T12:29:48+00:00

The transmission loop starts with setting some variables, which are only
used inside the loop. Reduce the scope to the loop to make the
declaration and initialization of these variables coincide.

In the case of char_size this also always initializes the variable
immediately with the final value actually used in the loop (instead of
the placeholder value 32).

Signed-off-by: Mario Six 
Acked-by: Jagan Teki

spi: mpc8xxx: Simplify logic a bit

2019-06-10T12:29:48+00:00

We do nothing in the loop if the "not empty" event was not detected. To
simplify the logic, check if this is the case, and skip the execution of
the loop early to reduce the nesting level and flag checking.

Signed-off-by: Mario Six 
Acked-by: Jagan Teki