u-boot.git/env/common.c, branch v2020.01

common: Move sorting functions to their own header file

2019-12-02T23:23:08+00:00

These don't need to be in common.h so move them out into a new header.
Also add some missing comments.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

crc32: Use the crc.h header for crc functions

2019-12-02T23:23:08+00:00

Drop inclusion of crc.h in common.h and use the correct header directly
instead.

With this we can drop the conflicting definition in fw_env.h and rely on
the crc.h header, which is already included.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

Revert "env: solve compilation error in SPL"

2019-10-04T16:21:33+00:00

This reverts commit 7d4776545b0f8a8827e5d061206faf61c9ba6ea9.  The
changes here break environment validation and furthermore do not seem to
be required.

Signed-off-by: Tom Rini

env: Rename environment.h to env_internal.h

2019-08-11T23:27:31+00:00

This file contains lots of internal details about the environment. Most
code can include env.h instead, calling the functions there as needed.

Rename this file and add a comment at the top to indicate its internal
nature.

Signed-off-by: Simon Glass 
Acked-by: Joe Hershberger 
Reviewed-by: Simon Goldschmidt 
[trini: Fixup apalis-tk1.c]
Signed-off-by: Tom Rini

env: Drop the ENTRY typedef

2019-08-11T20:43:41+00:00

U-Boot is not supposed to use typedef for structs anymore. Also this name
is the same as the ENTRY() macro used in assembler files, and 'entry'
itself is widely used in U-Boot (>8k matches).

Drop the typedef and rename the struct to env_entry to reduce confusion.

Signed-off-by: Simon Glass 
Acked-by: Joe Hershberger

env: Move get/set_default_env() to env.h

2019-08-11T20:43:41+00:00

Move these functions to the new header file and rename set_default_env()
to env_set_default() so that it has a consistent env_ prefix.

Acked-by: Joe Hershberger 
Signed-off-by: Simon Glass

env: Move set_default_vars to env.h

2019-08-11T20:43:41+00:00

Move this function to the new header file and rename it so it has an env_
prefix.

Acked-by: Joe Hershberger 
Signed-off-by: Simon Glass

env: Move env_relocate() to env.h

2019-08-11T20:43:41+00:00

Move env_relocate() over to the new header file.

Signed-off-by: Simon Glass 
Acked-by: Joe Hershberger

env: solve compilation error in SPL

2019-05-23T09:36:48+00:00

Solve compilation issue when cli_simple.o is used in SPL
and CONFIG_SPL_ENV_SUPPORT is not defined.

env/built-in.o:(.data.env_htab+0xc): undefined reference to `env_flags_validate'
u-boot/scripts/Makefile.spl:384: recipe for target 'spl/u-boot-spl' failed
make[2]: *** [spl/u-boot-spl] Error 1
u-boot/Makefile:1649: recipe for target 'spl/u-boot-spl' failed
make[1]: *** [spl/u-boot-spl] Error 2

Signed-off-by: Patrick Delaunay

env: common: Return specific error code on bad CRC

2019-01-26T13:13:56+00:00

Callers of env_import*() functions might want to check the case when we
have incorrect environment (with bad CRC). For example, when environment
location is being defined in env_load(), call chain may look like this:

    env_load() -> drv->load() = env_mmc_load() -> env_import()

Return code will be passed from env_import() all way up to env_load().
Right now both env_mmc_load() and env_import() return -EIO error code,
so env_load() can't differentiate between two cases:
  1. Driver reports the error, because device is not accessible
  2. Device is actually accessible, but environment is broken

Let's return -ENOMSG in env_import(), so we can distinguish two cases
mentioned above. It will make it possible to continue working with "bad
CRC" environment (like doing "env save"), instead of considering it not
functional (implemented in subsequent patch).

Signed-off-by: Sam Protsenko 
Reviewed-by: Simon Goldschmidt