u-boot.git/env/env.c, branch v2017.09

env: Replace all open-coded gd->env_valid values with ENV_ flags

2017-08-20T23:27:44+00:00

Some of these were missed in the conversion.
Signed-off-by: Simon Glass

env: Allow env_load() to detect errors

2017-08-20T23:27:43+00:00

Now that we have errors available in the environment driver's load()
method, check the return valid.

Signed-off-by: Simon Glass

env: Correct case of no sub-init function

2017-08-20T23:27:28+00:00

With the change to the environment code to remove the common init stage
of pointing to the default environment and setting it as valid, combined
with the change to switch gd->env_valid from 0/1/2 to an enum we now
must set env_valid to one of the enum values rather than an int.  And in
this case, not only was setting it to an int wrong, it was now the wrong
value.  Finally, in the case of ENV_IS_NOWHERE we must still say that
our envionrment is invalid after init for things to continue to
function.

Fixes: 7938822a6b75 ("env: Drop common init() functions")
Tested-by: Marek Vasut 
Reported-by: Marek Vasut 
Reported-by: Andy Shevchenko 
Signed-off-by: Tom Rini 
---
Changes in v3:
- Actually include changes for env/nowhere.c

env: Drop saveenv() in favour of env_save()

2017-08-16T00:50:30+00:00

Use the env_save() function directly now that there is only one
implementation of saveenv().

Signed-off-by: Simon Glass 
Reviewed-by: Wolfgang Denk 
Reviewed-by: Tom Rini

env: Drop env_relocate_spec() in favour of env_load()

2017-08-16T00:50:29+00:00

This is a strange name for a function that loads the environment. There is
now only one implementation of this function, so use the new env_load()
function directly instead.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

env: Drop env_get_char_spec()

2017-08-16T00:50:29+00:00

We only have a single implementation of this function now and it is called
env_get_char(). Drop the old function and the weak version.

Reviewed-by: Tom Rini 
Signed-off-by: Simon Glass

env: Drop env_init_new()

2017-08-16T00:50:29+00:00

Now that env_init() is only defined once we can drop the env_init_new()
name and just use env_init().

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

env: Drop the env_name_spec global

2017-08-16T00:50:28+00:00

Add a name to the driver and use that instead of the global variable
declared by each driver.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

env: Drop common init() functions

2017-08-16T00:50:27+00:00

Most of the init() implementations just use the default environment.
Adjust env_init_new() to do this automatically, and drop the redundant
code.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

env: Switch over to use environment location drivers

2017-08-16T00:50:27+00:00

Move over to use a the master implementation of the location drivers, with
each method calling out to the appropriate driver.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini