u-boot.git/env, branch v2017.09-rc3

env: Replace all open-coded gd->env_valid values with ENV_ flags

2017-08-20T23:27:44+00:00

Some of these were missed in the conversion.
Signed-off-by: Simon Glass

env: Allow env_load() to detect errors

2017-08-20T23:27:43+00:00

Now that we have errors available in the environment driver's load()
method, check the return valid.

Signed-off-by: Simon Glass

env: Correct case of no sub-init function

2017-08-20T23:27:28+00:00

With the change to the environment code to remove the common init stage
of pointing to the default environment and setting it as valid, combined
with the change to switch gd->env_valid from 0/1/2 to an enum we now
must set env_valid to one of the enum values rather than an int.  And in
this case, not only was setting it to an int wrong, it was now the wrong
value.  Finally, in the case of ENV_IS_NOWHERE we must still say that
our envionrment is invalid after init for things to continue to
function.

Fixes: 7938822a6b75 ("env: Drop common init() functions")
Tested-by: Marek Vasut 
Reported-by: Marek Vasut 
Reported-by: Andy Shevchenko 
Signed-off-by: Tom Rini 
---
Changes in v3:
- Actually include changes for env/nowhere.c

env: Sort selection of default choices

2017-08-20T13:54:33+00:00

It would be easier to catch out which platform is using which default.

Signed-off-by: Andy Shevchenko

env: Adjust the load() method to return an error

2017-08-16T12:31:24+00:00

The load() methods have inconsistent behaviour on error. Some of them load
an empty default environment. Some load an environment containing an error
message. Others do nothing.

As a step in the right direction, have the method return an error code.
Then the caller could handle this itself in a consistent way.

Signed-off-by: Simon Glass

env: Adjust the get_char() method to return an int

2017-08-16T12:31:24+00:00

In principle this can fail, e.g. if the index is out of range. Adjust the
driver signature to allow returning an error code.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

env: Rename some other getenv()-related functions

2017-08-16T12:31:11+00:00

We are now using an env_ prefix for environment functions. Rename these
other functions as well, for consistency:

   getenv_vlan()
   getenv_bootm_size()
   getenv_bootm_low()
   getenv_bootm_mapsize()
   env_get_default()

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()

2017-08-16T12:30:32+00:00

We are now using an env_ prefix for environment functions. Rename these
for consistency. Also add function comments in common.h.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

env: Rename getenv/_f() to env_get()

2017-08-16T12:30:24+00:00

We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.

Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

env: Drop saveenv() in favour of env_save()

2017-08-16T00:50:30+00:00

Use the env_save() function directly now that there is only one
implementation of saveenv().

Signed-off-by: Simon Glass 
Reviewed-by: Wolfgang Denk 
Reviewed-by: Tom Rini