u-boot.git/env, branch v2018.03

env: mmc/fat/ext4: make sure that the MMC sub-system is initialized before using it

2018-02-20T13:21:30+00:00

When booting from a non-MMC device, the MMC sub-system may not be
initialized when the environment is first accessed.
We need to make sure that the MMC sub-system is ready in even a non-MMC
boot case.

Therefore, initialize mmc before loading environment from it.

Signed-off-by: Faiz Abbas

env: restore old env_get_char() behaviour

2018-02-16T16:12:42+00:00

With multiple environments, the 'get_char' callback for env
drivers does not really make sense any more because it is
only supported by two drivers (eeprom and nvram).

To restore single character loading for these drivers,
override 'env_get_char_spec'.

Signed-off-by: Simon Goldschmidt 
Acked-by: Maxime Ripard

env: Fix env_load_location

2018-02-16T16:12:41+00:00

Commit 7d714a24d725 ("env: Support multiple environments") added
static variable env_load_location. When saving environmental
variables, this variable is presumed to have the value set before.
In case the value was set before relocation and U-Boot runs from a
NOR flash, this variable wasn't writable. This causes failure when
saving the environment. To save this location, global data must be
used instead.

Signed-off-by: York Sun 
CC: Maxime Ripard

Fix misaligned buffer in env_fat_save

2018-02-12T20:31:18+00:00

When saving the environment on a platform which has DMA alignment
larger than the natural alignment, env_fat_save triggers a debug
message in file_fat_write:

  Saving Environment to FAT... writing uboot.env
  FAT: Misaligned buffer address (9df1c8e0)
  OK

Signed-off-by: Alex Kiernan

env: sf: use env_import_redund to simplify env_sf_load

2018-02-01T13:05:53+00:00

For the redundant environment configuration, env_sf_load still
contained duplicate code instead of using env_import_redund().

Simplify the code by only executing the load twice and delegating
everything else to env_import_redund.

Signed-off-by: Simon Goldschmidt 
Acked-by: Maxime Ripard

env: make env drivers propagate env_import return value

2018-02-01T13:05:53+00:00

For multiple env drivers to correctly implement fallback when
one environment fails to load (e.g. crc error), the return value
of env_import has to be propagated by all env driver's load
function.

Without this change, the first driver that succeeds to load an
environment with an invalid CRC return 0 (success) and no other
drivers are checked.

Signed-off-by: Simon Goldschmidt 
Acked-by: Maxime Ripard

env: move more common code to env_import_redund

2018-02-01T13:05:49+00:00

There is more common code in mmc, nand and ubi env drivers that
can be shared by moving to env_import_redund.

For this, a status/error value whether the buffers were loaded
are passed as additional parameters to env_import_redund.
Ideally, these are already returned to the env driver by the
storage driver. This is the case for mmc, nand and ubi, so for
this change, code deduplicated.

Signed-off-by: Simon Goldschmidt 
Acked-by: Maxime Ripard

env: make env_import(_redund) return 0 on success, not 1

2018-01-31T23:45:10+00:00

env_import (and env_import_redund) currently return 1 on success
and 0 on error. However, they are only used from functions
returning 0 on success or a negative value on error.

Let's clean this up by making env_import and env_import_redund
return 0 on success and -EIO on error (as was the case for all
users before).

Users that cared for the return value are also updated. Funny
enough, this only affects onenand.c and sf.c

Signed-off-by: Simon Goldschmidt 
Acked-by: Maxime Ripard

env: sunxi: Enable FAT-based environment support by default

2018-01-27T14:23:32+00:00

Now that we have everything in place to implement the transition scheme,
let's enable it by default.

Reviewed-by: Andre Przywara 
Reviewed-by: Lukasz Majewski 
Signed-off-by: Maxime Ripard

env: Mark env_get_location as weak

2018-01-27T14:23:22+00:00

Allow boards and architectures to override the default environment lookup
code by overriding env_get_location.

Reviewed-by: Andre Przywara 
Reviewed-by: Lukasz Majewski 
Reviewed-by: Simon Glass 
Signed-off-by: Maxime Ripard