u-boot.git/fs/ext4/ext4_write.c, branch v2016.09

ext4: avoid calling ext4fs_mount() twice, which leaks

2015-09-11T21:15:22+00:00

ext4_write_file() is only called from the "fs" layer, which calls both
ext4fs_mount() and ext4fs_close() before/after calling ext4_write_file().
Fix ext4_write_file() not to call ext4fs_mount() again, since the mount
operation malloc()s some RAM which is leaked when a second mount call
over-writes the pointer to that data, if no intervening close call is
made.

Signed-off-by: Stephen Warren 
Acked-by: Lukasz Majewski 
Tested-by: Lukasz Majewski

Move ALLOC_CACHE_ALIGN_BUFFER() to the new memalign.h header

2015-09-11T21:15:20+00:00

Now that we have a new header file for cache-aligned allocation, we should
move the stack-based allocation macro there also.

Signed-off-by: Simon Glass

fs: ext4 write: return file len on success

2015-03-06T01:49:42+00:00

After rework of the file system API, the size of ext4
write was missed. This causes printing unreliable write
size at the end of the file system write operation.

Signed-off-by: Przemyslaw Marczak 
Cc: Sjoerd Simons 
Cc: Lukasz Majewski 
Cc: Simon Glass 
Tested-by: Stephen Warren

ext4: Prepare API change for files greater than 2GB

2014-11-23T11:49:04+00:00

Change the internal EXT4 functions to use loff_t for offsets.

Signed-off-by: Suriyan Ramasami 
Acked-by: Simon Glass 
[trini: Update common/spl/spl_ext.c]
Signed-off-by: Tom Rini

ext4: correctly zero filename

2014-06-11T20:27:05+00:00

Since ALLOC_CACHE_ALIGN_BUFFER declares a char* for filename
sizeof(filename) is not the size of the buffer. Use the already
known length instead.

cc: Uma Shankar 
cc: Manjunatha C Achar 
cc: Marek Vasut 
Signed-off-by: Jeroen Hofstee 
Acked-by: Marek Vasut

fs:ext4:write:fix: Reinitialize global variables after updating a file

2014-05-12T20:31:50+00:00

This bug shows up when file stored on the ext4 file system is updated.

The ext4fs_delete_file() is responsible for deleting file's (e.g. uImage)
data.
However some global data (especially ext4fs_indir2_block), which is used
during file deletion are left unchanged.

The ext4fs_indir2_block pointer stores reference to old ext4 double
indirect allocated blocks. When it is unchanged, after file deletion,
ext4fs_write_file() uses the same pointer (since it is already initialized
- i.e. not NULL) to return number of blocks to write. This trunks larger
file when previous one was smaller.

Lets consider following scenario:

1. Flash target with ext4 formatted boot.img (which has uImage [*] on itself)
2. Developer wants to upload their custom uImage [**]
	- When new uImage [**] is smaller than the [*] - everything works
	correctly - we are able to store the whole smaller file with corrupted
	ext4fs_indir2_block pointer
	- When new uImage [**] is larger than the [*] - theCRC is corrupted,
	since truncation on data stored at eMMC was done.
3. When uImage CRC error appears, then reboot and LTHOR/DFU reflashing causes
	proper setting of ext4fs_indir2_block() and after that uImage[**]
	is successfully stored (correct uImage [*] metadata is stored at an
	eMMC on the first flashing).

Due to above the bug was very difficult to reproduce.
This patch sets default values for all ext4fs_indir* pointers/variables.

Signed-off-by: Lukasz Majewski

fs:ext4:cleanup: Remove superfluous code

2014-05-12T20:31:50+00:00

Code responsible for handling situation when ext4 has block size of 1024B
can be ordered to take less space.

This patch does that for ext4 common and write files.

Signed-off-by: Lukasz Majewski

fs/ext4: fix calling put_ext4 with truncated offset

2014-01-20T15:09:38+00:00

Curently, we are using 32 bit multiplication to calculate the offset,
so the result will always be 32 bit.
This can silently cause file system corruption when performing a write
operation on partition larger than 4 GiB.

This patch address the issue by simply promoting the terms to 64 bit,
and let compilers decide how to do the multiplication efficiently.

Signed-off-by: Ma Haijun

Add GPL-2.0+ SPDX-License-Identifier to source files

2013-07-24T13:44:38+00:00

Signed-off-by: Wolfgang Denk 
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini

Fix ext2/ext4 filesystem accesses beyond 2TiB

2013-07-15T21:06:13+00:00

With CONFIG_SYS_64BIT_LBA, lbaint_t gets defined as a 64-bit type,
which is required to represent block numbers for storage devices that
exceed 2TiB (the block size usually is 512B), e.g. recent hard drives

We now use lbaint_t for partition offset to reflect the lbaint_t change,
and access partitions beyond or crossing the 2.1TiB limit.
This required changes to signature of ext4fs_devread(), and type of all
variables relatives to block sector.

ext2/ext4 fs uses logical block represented by a 32 bit value. Logical
block is a multiple of device block sector. To avoid overflow problem
when calling ext4fs_devread(), we need to cast the sector parameter.

Signed-off-by: Frédéric Leroy