u-boot.git/fs/ext4, branch v2018.05

SPDX: Convert all of our single license tags to Linux Kernel style

2018-05-07T13:34:12+00:00

When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from.  So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry.  Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.

In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.

This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents.  There's also a few places where I found we did not have a tag
and have introduced one.

Signed-off-by: Tom Rini

fs: ext4: Do not print mount fail message when not ext4 filesystem

2018-03-09T17:31:07+00:00

Other filesystem drivers don't do this.

Signed-off-by: Marek Behun

fs: Migrate ext4 to Kconfig

2018-01-22T21:43:30+00:00

Migrate the following symbols to Kconfig:

CONFIG_FS_EXT4
CONFIG_EXT4_WRITE

The definitions in config_fallbacks.h can now be expressed in Kconfig.

Signed-off-by: Tuomas Tynkkynen

ext4: recover from filesystem corruption when reading

2017-11-20T08:58:31+00:00

Some fixes when reading EXT files and directory entries were identified
after using e2fuzz to corrupt an EXT3 filesystem:

 - Stop reading directory entries if the offset becomes badly aligned.

 - Avoid overwriting memory by clamping the length used to zero the buffer
   in ext4fs_read_file.  Also sanity check blocksize.

Signed-off-by: Ian Ray 
Signed-off-by: Martyn Welch 
Reviewed-by: Stefano Babic

fs/ext4/ext4fs.c: Free dirnode in error path of ext4fs_ls

2017-10-06T15:28:22+00:00

As reported by Coverity, we did not free dirnode in the case of failure.
Do so now.

Reported-by: Coverity (CID: 131221)
Cc: Stefan Brüns 
Signed-off-by: Tom Rini

fs/ext4: Fix group descriptor checksum calculation

2017-10-06T15:28:18+00:00

The current code doesn't compute the group descriptor checksum correctly
for the filesystems that e2fsprogs 1.43.4 creates (they have
'Group descriptor size: 64' as reported by tune2fs). Extend the checksum
calculation to be done as ext4_group_desc_csum() does in Linux.

This fixes these errors in dmesg from running fs-test.sh and makes it
succeed again:

[1671902.620699] EXT4-fs (loop1): ext4_check_descriptors: Checksum for group 0 failed (35782!=10965)
[1671902.620706] EXT4-fs (loop1): group descriptors corrupted!

Signed-off-by: Tuomas Tynkkynen

fs: Create a common fs_devread for ext4/reiserfs/zfs

2017-10-03T01:51:50+00:00

The ext4, reiserfs and zfs filesystems all have their own implementation
of the same function, *_devread. Generalize this function into fs_devread
and put the code into fs/fs_internal.c.

Signed-off-by: Marek Behun 
[trini: Move fs/fs_internal.o hunk to the end of fs/Makefile as all
cases need it]
Signed-off-by: Tom Rini

fs: ext4: Fix journal overrun issue reported by Coverity

2017-08-26T18:56:13+00:00

While &p_jdb[fs->blksz] is a valid expression (it points *one* char
sized element past the end of the array, e.g. &p_jdb[fs->blksz + 1] is
invalid (according to the C standard (C99/C11)).

Changing this to tag = (struct ext3_journal_block_tag *)(p_jdb + ofs);

Cc: Stefan Brüns 
Suggested-by: Stefan Brüns 
Reported-by: Coverity (CID: 165117, 165110)
Signed-off-by: Tom Rini 
Reviewed-by: Stefan Brüns

ext4: Fix comparision of unsigned expression with < 0

2017-04-27T20:49:09+00:00

In file ext4fs.c funtion ext4fs_read_file() compares an
unsigned expression with < 0 like below

	lbaint_t blknr;
	blknr = read_allocated_block(&(node->inode), i);
	if (blknr < 0)
		return -1;

blknr is of type ulong/uint64_t. read_allocated_block() returns
long int. So comparing blknr with < 0 will always be false. Instead
declare blknr as long int.

Similarly ext4/dev.c does a similar comparison. Drop the redundant
comparison.

Signed-off-by: Lokesh Vutla 
Reviewed-by: Tom Rini

fs/ext4: Initialize group descriptor size for revision level 0 filesystems

2016-12-27T16:24:18+00:00

genext2fs creates revision level 0 filesystems, which are not readable
by u-boot due to the initialized group descriptor size field.
f798b1dda1c5de818b806189e523d1b75db7e72d

Reported-by: Kever Yang 
Reported-by: FrostyBytes@protonmail.com
Signed-off-by: Stefan Brüns 
Tested-by: Kever Yang