u-boot.git/fs/ext4, branch v2025.10

Merge patch series "fs: ext4fs: Fix some issues found by Smatch"

2025-07-11T17:33:25Z

Andrew Goodbody says: Smatch reported some issues in the ext4fs code. This includes a suggestion to use an unwind goto, to not negate a return value and to ensure that a NULL check happens before the pointer is dereferenced. Link: https://lore.kernel.org/r/20250704-ext4fs_fix-v1-0-5c6acf4bf839@linaro.org

fs: ext4fs: Perform NULL check before dereference

2025-07-11T16:44:29Z

In the function put_ext4 there is a NULL check for fs->dev_desc but this has already been derefenced twice before this happens. Refactor the code a bit to put the NULL check first. This issue found by Smatch. Signed-off-by: Andrew Goodbody

fs: ext4fs: Use unwind goto to free memory on error

2025-07-11T16:44:29Z

Ensure that allocated memory is freed on error exit replace the direct return calls with 'goto fail'. This issue found by Smatch. Signed-off-by: Andrew Goodbody

fs: ext4fs: Do not negate error before returning it

2025-07-11T16:44:29Z

In ext4fs_readdir it calls ext4fs_read_file and checks the return value for non-zero to detect an error. This return value should be returned as is rather than being negated. This issue found by Smatch Signed-off-by: Andrew Goodbody

fs: ext4fs: Fix: Data abort in ext4fs_log_gdt()

2025-06-25T19:41:35Z

Return ENOMEM in ext4fs_log_gdt when number of blocks per gdt is more than number of allocated journal entries. Signed-off-by: Tony Dinh

ext4fs: Fix: Read outside partition error (take 2)

2025-06-12T19:22:26Z

Use lbaint_t for blknr to avoid overflow in ext4fs_read_file(). Background: blknr (block number) used in ext4fs_read_file() could be increased to a very large value and causes a wrap around at 32 bit signed integer max, thus becomes negative. This results in an out-of-normal range for sector number (during the assignment delayed_start = blknr) where delayed_start sector is typed uint64 lbaint_t. This causes the "Read outside partition" error. Looks like we also have this overflown problem in ext4_write.c that needs to be addressed. This patch was tested on the Synology DS116 (Armada 385) board, and a 4TB Seagate HDD. Signed-off-by: Tony Dinh

Merge tag 'v2025.07-rc4' into next

2025-06-09T22:28:28Z

Prepare v2025.07-rc4

Revert "ext4fs: Fix: Read outside partition error"

2025-05-27T16:09:12Z

The issue here is that the function read_allocated_block() will report problems via a negative return value. If we say the return value is stored in an lbaint_t that can no longer happen (and Coverity discovered this by reporting a no effect comparison and then dead code). The problem being fixed by allowing for storing a larger block number will have to be solved in some other manner. This reverts commit df2ed552f0b05591090369a7fe7ddc92439dea5c. Addresses-Coverity-ID: 131183 Signed-off-by: Tom Rini

Merge tag 'v2025.07-rc3' into next

2025-05-26T22:07:19Z

Prepare v2025.07-rc3

ext4fs: Fix: Read outside partition error

2025-05-23T16:42:49Z

Use lbaint_t for blknr to avoid overflow in ext4fs_read_file(). Background: blknr (block number) used in ext4fs_read_file() could be increased to a very large value and causes a wrap around at 32 bit signed integer max, thus becomes negative. This results in an out-of-normal range for sector number (during the assignment delayed_start = blknr) where delayed_start sector is typed uint64 lbaint_t. This causes the "Read outside partition" error. This patch was tested on the Synology DS116 (Armada 385) board, and a 4TB Seagate HDD. Signed-off-by: Tony Dinh