u-boot.git/fs/fat/fat_write.c, branch v2017.09

fs: fat: fix fatwrite overflow calculation

2017-08-26T18:56:07Z

The overflow calculation was incorrect. Adding the start block of the partition is not needed because the sectors are already relative to the beginning of the partition. If you attempted to write a file smaller than cur_part_info.start blocks on a full partition the old calculation fails to catch the overflow. This would cause an infinite loop in the determine_fatent function. Old, incorrect calculation: ending sector of new file = start sector + file size (in sectors) last sector = partition start + total sectors on the partition Adding the partition start block number is not needed because sectors are already relative to the start of the partition. New calculation: ending sector of new file = start sector + file size (in sectors) last sector = total sectors on the partition Signed-off-by: Reno Farnesi

fs/fat: merge readwrite get_fatent_value() with readonly get_fatent()

2016-12-27T16:24:14Z

get_fatent_value(...) flushes changed FAT entries to disk when fetching the next FAT blocks, in every other aspect it is identical to get_fatent(...). Provide a stub implementation for flush_dirty_fat_buffer if CONFIG_FAT_WRITE is not set. Calling flush_dirty_fat_buffer during read only operation is fine as it checks if any buffers needs flushing. Signed-off-by: Stefan Brüns Reviewed-by: Benoît Thébaudeau

fs/fat: Avoid corruption of sectors following the FAT

2016-12-27T16:24:13Z

The FAT is read/flushed in segments of 6 (FATBUFBLOCKS) disk sectors. The last segment may be less than 6 sectors, cap the length. Signed-off-by: Stefan Brüns Reviewed-by: Benoît Thébaudeau

fat: fatwrite: fix the command for FAT12

2016-12-27T16:24:13Z

The u-boot command fatwrite empties FAT clusters from the beginning till the end of the file. Specifically for FAT12 it fails to detect the end of the file and goes beyond the file bounds thus corrupting the file system. Additionally, FAT entry chaining-up into a file is not implemented for FAT12. The users normally workaround this by re-formatting the partition as FAT16/FAT32, like here: https://github.com/FEDEVEL/openrex-uboot-v2015.10/issues/1 The patch fixes the bounds of a file and FAT12 entries chaining into a file, including EOF markup. Signed-off-by: Philipp Skadorov

fs/fat/fatwrite: Local variable as buffer to store dir_slot entries

2016-11-29T01:09:45Z

fill_dir_slot use get_contents_vfatname_block as a temporary buffer for constructing a list of dir_slot entries. To save the memory and providing correct type of memory for above usage, a local buffer with accurate size declaration is introduced. The local array size 640 is used because for long file name entry, each entry use 32 bytes, one entry can store up to 13 characters. The maximum number of entry possible is 20. So, total size is 32*20=640bytes. Signed-off-by: Genevieve Chan Signed-off-by: Tien Fong Chee

fs/fat: Correct description of determine_fatent function

2016-09-23T12:55:57Z

Current description does not match the function behaviour. Signed-off-by: Stefan Brüns Acked-by: Lukasz Majewski

fs/fat: Do not write unmodified fat entries to disk

2016-09-23T12:55:56Z

The code caches 6 sectors of the FAT. On FAT traversal, the old contents needs to be flushed to disk, but only if any FAT entries had been modified. Explicitly flag the buffer on modification. Currently, creating a new file traverses the whole FAT up to the first free cluster and rewrites the on-disk blocks. Signed-off-by: Stefan Brüns Reviewed-by: Lukasz Majewski

fs/fat: Remove two statements without effect

2016-09-23T12:55:55Z

fatlength is a local variable which is no more used after the assignment. s_name is not used in the function, save the strncpy. Signed-off-by: Stefan Brüns Acked-by: Lukasz Majewski Acked-by: Stephen Warren Reviewed-by: Benoît Thébaudeau

Fix spelling of "supported/unsupported".

2016-03-22T16:16:14Z

Signed-off-by: Vagrant Cascadian Reviewed-by: Simon Glass Reviewed-by: Tom Rini Reviewed-by: Peter Griffin

dm: block: Adjust device calls to go through helpers function

2016-03-14T21:34:50Z

To ease conversion to driver model, add helper functions which deal with calling each block device method. With driver model we can reimplement these functions with the same arguments. Use inline functions to avoid increasing code size on some boards. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Tested-by: Stephen Warren