u-boot.git/fs/fat, branch v2019.04

fs: fat: fix link error when building with DEBUG=1

2019-02-28T19:21:46Z

When compiling with DEBUG=1 an error fs/fat/fat_write.c:831: undefined reference to `__aeabi_ldivmod' occurred. We should use do_div() instead of the modulus operator. filesize and cur_pos cannot be negative. So let's use u64 to avoid warnings. Fixes: cb8af8af5ba0 ("fs: fat: support write with non-zero offset") Signed-off-by: Heinrich Schuchardt

fs: fat: Reduce default max clustersize 64KiB from malloc pool

2019-02-19T13:55:43Z

Release cluster block immediately when no longer use would help to reduce 64KiB memory allocated to the memory pool. Signed-off-by: Tien Fong Chee

fs: fat: dynamically allocate memory for temporary buffer

2019-02-19T13:55:43Z

Drop the statically allocated get_contents_vfatname_block and dynamically allocate a buffer only if required. This saves 64KiB of memory. Signed-off-by: Stefan Agner Signed-off-by: Tien Fong Chee

spl: fat/fs: Add option to include/exclude FAT write build in SPL

2019-02-01T14:12:48Z

Most of the time SPL only needs very simple FAT reading, so having CONFIG_IS_ENABLED(FAT_WRITE) to exclude it from SPL build would help to save 64KiB default max clustersize from memory. Signed-off-by: Tien Fong Chee Reviewed-by: Simon Goldschmidt Reviewed-by: Tom Rini

Revert "fs: fat: assign rootdir sector when accessing root directory"

2019-01-11T15:15:42Z

This particular commit is causing a regression on stih410-b2260 and other platforms when reading from FAT16. Noting that I had rebased the original fix from Thomas onto then-current master, there is also question from Akashi-san if the change is still needed after other FAT fixes that have gone in. This reverts commit a68b0e11ea774492713a65d9fd5bb525fcaefff3. Reported-by: Patrice Chotard Cc: AKASHI Takahiro Cc: Thomas RIENOESSL Signed-off-by: Tom Rini

fs: fix FAT name extraction

2018-12-07T04:26:31Z

The long name apparently can be accumulated using multiple 13-byte slots. Unfortunately we never checked how many we can actually fit in the buffer we are reading to. Signed-off-by: Patrick Wildt

fs: check FAT cluster size

2018-12-07T04:26:31Z

The cluster size specifies how many sectors make up a cluster. A cluster size of zero makes no sense, as it would mean that the cluster is made up of no sectors. This will later lead into a division by zero in sect_to_clust(), so better take care of that early. The MAX_CLUSTSIZE define can reduced using a define to make some room in low-memory system. Unfortunately if the code reads a filesystem with a bigger cluster size it will overflow the buffer. Signed-off-by: Patrick Wildt

fs: fat: assign rootdir sector when accessing root directory

2018-11-20T17:35:35Z

This fixes problems accessing drives formated under Windows as FAT16. Signed-off-by: Thomas RIENOESSL [trini: Rebase on top of f528c140c801] Signed-off-by: Tom Rini

fs: fat: Fix warning in normalize_longname()

2018-10-16T14:44:12Z

As observed with clang: fs/fat/fat_write.c:1024:13: warning: comparison of constant 128 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare] if ((0x80 <= c) && (c <= 0xff)) ~~~~ ^ ~ fs/fat/fat_write.c:1024:25: warning: comparison of constant 255 with expression of type 'char' is always true [-Wtautological-constant-out-of-range-compare] if ((0x80 <= c) && (c <= 0xff)) ~ ^ ~~~~ Fixes: 25bb9dab14f4 ("fs: fat: check and normalize file name") Signed-off-by: Tom Rini Signed-off-by: Alexander Graf

fs: fat: fix set_cluster()

2018-10-06T18:09:41Z

Avoid CoverityScan warning SIGN_EXTENSION by changing the type of parameter size of set_cluster(). Avoid leaking stack content when writing an incomplete last sector. Reported-by: Coverity (CID: 184096) Signed-off-by: Heinrich Schuchardt