<feed xmlns='http://www.w3.org/2005/Atom'>
<title>u-boot.git/fs/jffs2, branch v2020.07</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<id>http://cgit.235523.xyz/u-boot.git/atom/fs/jffs2?h=v2020.07</id>
<link rel='self' href='http://cgit.235523.xyz/u-boot.git/atom/fs/jffs2?h=v2020.07'/>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/'/>
<updated>2020-05-18T18:53:28Z</updated>
<entry>
<title>common: Drop flash.h from common header</title>
<updated>2020-05-18T18:53:28Z</updated>
<author>
<name>Simon Glass</name>
<email>sjg@chromium.org</email>
</author>
<published>2020-05-10T17:39:54Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=b79fdc76978515fba2c4f3b5b4f2e679c5ff1463'/>
<id>urn:sha1:b79fdc76978515fba2c4f3b5b4f2e679c5ff1463</id>
<content type='text'>
Move this uncommon header out of the common header.

Fix up some style problems in flash.h while we are here.

Signed-off-by: Simon Glass &lt;sjg@chromium.org&gt;
</content>
</entry>
<entry>
<title>JFFS2: Add useful fields into lists</title>
<updated>2020-05-15T18:47:35Z</updated>
<author>
<name>Petr Borsodi</name>
<email>petr.borsodi@i.cz</email>
</author>
<published>2020-05-07T10:25:56Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=69dbebd1f70a983bede22ffb8be36fbf7eaa7d61'/>
<id>urn:sha1:69dbebd1f70a983bede22ffb8be36fbf7eaa7d61</id>
<content type='text'>
The inode list uses version and ino, the dirent list uses version and pino.
This information is collected during scanning, reducing accesses to flash
and significantly speeding up ls and read.

Signed-off-by: Petr Borsodi &lt;petr.borsodi@i.cz&gt;
</content>
</entry>
<entry>
<title>JFFS2: Process obsolete nodes as well as accurate ones</title>
<updated>2020-05-15T18:47:35Z</updated>
<author>
<name>Petr Borsodi</name>
<email>petr.borsodi@i.cz</email>
</author>
<published>2020-05-07T10:25:55Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=25ec2282ebbcd09af0f8f714abbc9bab89659e9a'/>
<id>urn:sha1:25ec2282ebbcd09af0f8f714abbc9bab89659e9a</id>
<content type='text'>
Obsolete nodes (ie. without the JFFS2_NODE_ACCURATE flag) were ignored
because they had seemingly invalid crc. This could lead to finding
the phantom node header in obsolete node data.

Signed-off-by: Petr Borsodi &lt;petr.borsodi@i.cz&gt;
</content>
</entry>
<entry>
<title>crc32: Use the crc.h header for crc functions</title>
<updated>2019-12-02T23:23:08Z</updated>
<author>
<name>Simon Glass</name>
<email>sjg@chromium.org</email>
</author>
<published>2019-11-14T19:57:16Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=3db7110857524cf1b7d0a374c1ebcde8a2680de0'/>
<id>urn:sha1:3db7110857524cf1b7d0a374c1ebcde8a2680de0</id>
<content type='text'>
Drop inclusion of crc.h in common.h and use the correct header directly
instead.

With this we can drop the conflicting definition in fw_env.h and rely on
the crc.h header, which is already included.

Signed-off-by: Simon Glass &lt;sjg@chromium.org&gt;
Reviewed-by: Tom Rini &lt;trini@konsulko.com&gt;
</content>
</entry>
<entry>
<title>jffs2: remove unused code files</title>
<updated>2019-08-20T16:20:33Z</updated>
<author>
<name>Uwe Kleine-König</name>
<email>u.kleine-koenig@pengutronix.de</email>
</author>
<published>2019-08-14T20:07:29Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=ad49488ffb0dd6357139f74a6b88c0b51e1ac215'/>
<id>urn:sha1:ad49488ffb0dd6357139f74a6b88c0b51e1ac215</id>
<content type='text'>
I failed to find where these two files are used and a few test compile
runs with JFFS2 enabled succeeded also without these.
</content>
</entry>
<entry>
<title>SPDX: Convert all of our single license tags to Linux Kernel style</title>
<updated>2018-05-07T13:34:12Z</updated>
<author>
<name>Tom Rini</name>
<email>trini@konsulko.com</email>
</author>
<published>2018-05-06T21:58:06Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=83d290c56fab2d38cd1ab4c4cc7099559c1d5046'/>
<id>urn:sha1:83d290c56fab2d38cd1ab4c4cc7099559c1d5046</id>
<content type='text'>
When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from.  So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry.  Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.

In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.

This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents.  There's also a few places where I found we did not have a tag
and have introduced one.

Signed-off-by: Tom Rini &lt;trini@konsulko.com&gt;
</content>
</entry>
<entry>
<title>fs/jffs2/mini_inflate.c: use "static inline" instead of "inline"</title>
<updated>2017-10-16T13:42:51Z</updated>
<author>
<name>Vagrant Cascadian</name>
<email>vagrant@debian.org</email>
</author>
<published>2017-10-10T16:42:39Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=c005f7edbbc41b33de2c5f8d31a8c12d86ffdb59'/>
<id>urn:sha1:c005f7edbbc41b33de2c5f8d31a8c12d86ffdb59</id>
<content type='text'>
This makes gcc no longer expect an out-of-line version of the
functions being present elsewhere.

This fixes a failure to build on several marvell targets with gcc-7 on
Debian:

  https://bugs.debian.org/877963

Signed-off-by: Adrian Bunk &lt;bunk@debian.org&gt;
Signed-off-by: Vagrant Cascadian &lt;vagrant@debian.org&gt;
</content>
</entry>
<entry>
<title>jffs2: ECC corrected nand data is ignored</title>
<updated>2017-10-16T13:42:51Z</updated>
<author>
<name>Engling, Uwe</name>
<email>Uwe.Engling@ise.de</email>
</author>
<published>2017-10-10T14:20:55Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=41ba7f525fa21941dee062b87adbbd7dde72f32f'/>
<id>urn:sha1:41ba7f525fa21941dee062b87adbbd7dde72f32f</id>
<content type='text'>
Hello,

I ran into a problem with the JFFS2 filesystem driver implemented in U-Boot.

I've got a NAND device that has correctable ECC errors (corrected somewhere in mtd/nand/nand_base.c).
The NAND driver tells the filesystem layer (jffs2_1pass.c) above that there occurred correctable ECC errors and returns with a "value &gt; 0".
The JFFS2 driver recognizes the corrected ECC errors as real error and skips this block because the only accepts a "return value == 0" as correct.

This problem exists for over 8 years (I checked version 2010.09) so I'm a little bit worried that I interpreted something wrong or didn't get the whole context.

Can someone confirm this bug (and the bugfix) in the u-boot jffs2 driver?

There was a mail in 2012 that mentioned the same problem, but there was no patch:
http://u-boot.10912.n7.nabble.com/JFFS2-seems-to-drop-nand-data-with-ECC-corrections-td142008.html
Sometime after this discussion the return value of nand_read() changed from -EUCLEAN as correctable ECC error to a positive value with the count of ECC corrected errors.

With kind reguards,
Uwe Engling
</content>
</entry>
<entry>
<title>treewide: replace with error() with pr_err()</title>
<updated>2017-10-04T15:59:44Z</updated>
<author>
<name>Masahiro Yamada</name>
<email>yamada.masahiro@socionext.com</email>
</author>
<published>2017-09-16T05:10:41Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=9b643e312d528f291966c1f30b0d90bf3b1d43dc'/>
<id>urn:sha1:9b643e312d528f291966c1f30b0d90bf3b1d43dc</id>
<content type='text'>
U-Boot widely uses error() as a bit noisier variant of printf().

This macro causes name conflict with the following line in
include/linux/compiler-gcc.h:

  # define __compiletime_error(message) __attribute__((error(message)))

This prevents us from using __compiletime_error(), and makes it
difficult to fully sync BUILD_BUG macros with Linux.  (Notice
Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)

Let's convert error() into now treewide-available pr_err().

Done with the help of Coccinelle, excluing tools/ directory.

The semantic patch I used is as follows:

// &lt;smpl&gt;
@@@@
-error
+pr_err
 (...)
// &lt;/smpl&gt;

Signed-off-by: Masahiro Yamada &lt;yamada.masahiro@socionext.com&gt;
Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt;
[trini: Re-run Coccinelle]
Signed-off-by: Tom Rini &lt;trini@konsulko.com&gt;
</content>
</entry>
<entry>
<title>fs: use get_nand_dev_by_index()</title>
<updated>2017-07-12T02:41:47Z</updated>
<author>
<name>Grygorii Strashko</name>
<email>grygorii.strashko@ti.com</email>
</author>
<published>2017-06-27T00:12:57Z</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=eb6a5c3c020099bbbc41cf3509718828ec1733cc'/>
<id>urn:sha1:eb6a5c3c020099bbbc41cf3509718828ec1733cc</id>
<content type='text'>
As part of preparation for nand DM conversion the new API has been
introduced to remove direct access to nand_info array. So, use it here
instead of accessing to nand_info array directly.

Signed-off-by: Grygorii Strashko &lt;grygorii.strashko@ti.com&gt;
</content>
</entry>
</feed>
