u-boot.git/fs/ubifs, branch main

cmd: ubifs: mark string parameters with const

2026-07-08T09:30:14Z

File name and volume name should be const as they will not be modified in these functions. Reviewed-by: Simon Glass Signed-off-by: Weijie Gao

fs: ubifs: fix ubifs_finddir() result check

2026-07-08T09:28:23Z

ubifs_finddir() can return a negative error code (-ENOMEM or PTR_ERR(dent)) and returns 1 when the name is found in the directory. Fix the result check accordingly. This fixes file existence detection (for "test -e") when U-Boot uses UBIFS through ops ubifs_exists(). Since this function is also called before other file operations, commands such as "load" could be executed on a non-existing file without reporting an error. Fixes: 0cab29ff467e ("fs: ubifs: Fix and rework error handling in ubifs_finddir") Signed-off-by: Patrick Delaunay

fs: ubifs: remove dead code

2026-05-18T07:19:56Z

This code is dead because it appears after an infinite loop; remove it. Fixes: d5888d509cc4 ("fs: ubifs: fix bugs involving symlinks in ubifs_findfile") Signed-off-by: Peter Collingbourne Reviewed-by: Heiko Schocher hs: corrected the commit ID

fs: ubifs: fix bugs involving symlinks in ubifs_findfile

2026-05-11T18:18:56Z

When encountering a symlink pointing to an absolute path, ubifs_findfile would return the target of the symlink as the result instead of resolving any following components in the original path. Fix it by following the same code path that is used for relative paths except that we set the next inode to the root if we see a leading slash. The existing code used memcpy and sprintf to copy the symlink target into a fixed size stack buffer and was therefore vulnerable to buffer overflows with a sufficiently long symlink target. Fix it by using a heap buffer for the temporary path during path resolution. Signed-off-by: Peter Collingbourne Fixes: 9d7952e4c636 ("ubifs: Add support for looking up directory and relative symlinks")

treewide: Clean up DECLARE_GLOBAL_DATA_PTR usage

2026-02-17T19:50:22Z

Remove DECLARE_GLOBAL_DATA_PTR from files where gd is not used, and drop the unnecessary inclusion of asm/global_data.h. Headers should be included directly by the files that need them, rather than indirectly via global_data.h. Reviewed-by: Patrice Chotard #STMicroelectronics boards and STM32MP1 ram test driver Tested-by: Anshul Dalal #TI boards Acked-by: Yao Zi #TH1520 Signed-off-by: Peng Fan

fs: ubifs: Fix and rework error handling in ubifs_finddir

2025-10-08T09:36:05Z

Add a null check for 'file' before dereferencing it and also rework the error handling to be a bit more sane. This issue was found by Smatch. Signed-off-by: Andrew Goodbody

fs: ubifs: Need to check return for being an error pointer

2025-10-08T09:36:00Z

The return value from alloc_super can be an error pointer so the error check needs to detect this as well as checking the pointer for being NULL. This issue was found by Smatch. Signed-off-by: Andrew Goodbody

fs: ubifs: Ensure buf is freed before return

2025-10-08T09:35:47Z

Returning directly after buf has been allocated will result in a memory leak. Instead set the error code and goto the common unwind code to ensure that buf will be freed before returning. This issue was found by Smatch. Signed-off-by: Andrew Goodbody

fs: ubifs: Remove unnecessary assignment

2025-01-28T05:44:18Z

Variable self assignment has been found by clang. But Linux kernel already fixed this problem by commit 2a068daf5742 ("ubifs: Remove unnecessary assignment") and commit ae4c8081eb77 ("ubifs: remove unnecessary assignment"). Signed-off-by: Michal Simek Reviewed-by: Alexander Dahl Reviewed-by: Michael Trimarchi Reviewed-by: Heiko Schocher

ubifs: Call ubifs_iput when ubifs_iget is used

2024-08-11T04:52:15Z

The inode should be freed after a reference is get to avoid memory leak Tested-by: Alexander Dahl Link: https://lore.kernel.org/u-boot/b698ec3e-d857-6512-8cc9-4edcab0a41b9@denx.de/T/#t Link: https://lore.kernel.org/all/8f3a7059-6330-f332-8e9f-729b853e001e@denx.de/T/ Co-developed-by: Heiko Schocher Signed-off-by: Michael Trimarchi