u-boot.git/fs/ubifs, branch next Unnamed repository; edit this file 'description' to name the repository. fs: ubifs: remove dead code 2026-05-18T07:19:56+00:00 Peter Collingbourne peter@pcc.me.uk 2026-05-12T05:50:08+00:00 0646ee0ed86bd2809e10cff1f8ca3310ad7bf33b This code is dead because it appears after an infinite loop; remove it. Fixes: d5888d509cc4 ("fs: ubifs: fix bugs involving symlinks in ubifs_findfile") Signed-off-by: Peter Collingbourne <peter@pcc.me.uk> Reviewed-by: Heiko Schocher <hs@nabladev.com> hs: corrected the commit ID 
This code is dead because it appears after an infinite loop; remove it.

Fixes: d5888d509cc4 ("fs: ubifs: fix bugs involving symlinks in ubifs_findfile")
Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
Reviewed-by: Heiko Schocher <hs@nabladev.com>

hs: corrected the commit ID
fs: ubifs: fix bugs involving symlinks in ubifs_findfile 2026-05-11T18:18:56+00:00 Peter Collingbourne peter@pcc.me.uk 2026-05-05T10:38:16+00:00 d5888d509cc43942ec98d993f2d129f5c8ddc432 When encountering a symlink pointing to an absolute path, ubifs_findfile would return the target of the symlink as the result instead of resolving any following components in the original path. Fix it by following the same code path that is used for relative paths except that we set the next inode to the root if we see a leading slash. The existing code used memcpy and sprintf to copy the symlink target into a fixed size stack buffer and was therefore vulnerable to buffer overflows with a sufficiently long symlink target. Fix it by using a heap buffer for the temporary path during path resolution. Signed-off-by: Peter Collingbourne <peter@pcc.me.uk> Fixes: 9d7952e4c636 ("ubifs: Add support for looking up directory and relative symlinks") 
When encountering a symlink pointing to an absolute path, ubifs_findfile
would return the target of the symlink as the result instead of resolving
any following components in the original path. Fix it by following the
same code path that is used for relative paths except that we set the
next inode to the root if we see a leading slash.

The existing code used memcpy and sprintf to copy the symlink target
into a fixed size stack buffer and was therefore vulnerable to buffer
overflows with a sufficiently long symlink target. Fix it by using a
heap buffer for the temporary path during path resolution.

Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
Fixes: 9d7952e4c636 ("ubifs: Add support for looking up directory and relative symlinks")
treewide: Clean up DECLARE_GLOBAL_DATA_PTR usage 2026-02-17T19:50:22+00:00 Peng Fan peng.fan@nxp.com 2026-02-09T01:30:18+00:00 0f90b1e715f8abe41b0875752eb184f46032ff11 Remove DECLARE_GLOBAL_DATA_PTR from files where gd is not used, and drop the unnecessary inclusion of asm/global_data.h. Headers should be included directly by the files that need them, rather than indirectly via global_data.h. Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> #STMicroelectronics boards and STM32MP1 ram test driver Tested-by: Anshul Dalal <anshuld@ti.com> #TI boards Acked-by: Yao Zi <me@ziyao.cc> #TH1520 Signed-off-by: Peng Fan <peng.fan@nxp.com> 
Remove DECLARE_GLOBAL_DATA_PTR from files where gd is not used, and
drop the unnecessary inclusion of asm/global_data.h.

Headers should be included directly by the files that need them,
rather than indirectly via global_data.h.

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> #STMicroelectronics boards and STM32MP1 ram test driver
Tested-by: Anshul Dalal <anshuld@ti.com> #TI boards
Acked-by: Yao Zi <me@ziyao.cc> #TH1520
Signed-off-by: Peng Fan <peng.fan@nxp.com>
fs: ubifs: Fix and rework error handling in ubifs_finddir 2025-10-08T09:36:05+00:00 Andrew Goodbody andrew.goodbody@linaro.org 2025-10-03T10:42:52+00:00 0cab29ff467e297064a9fc30200347bda06ee0c4 Add a null check for 'file' before dereferencing it and also rework the error handling to be a bit more sane. This issue was found by Smatch. Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> 
Add a null check for 'file' before dereferencing it and also rework the
error handling to be a bit more sane.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
fs: ubifs: Need to check return for being an error pointer 2025-10-08T09:36:00+00:00 Andrew Goodbody andrew.goodbody@linaro.org 2025-10-03T10:42:51+00:00 51615eb4f7bcd3367aecdeaea3638058ef5407f3 The return value from alloc_super can be an error pointer so the error check needs to detect this as well as checking the pointer for being NULL. This issue was found by Smatch. Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> 
The return value from alloc_super can be an error pointer so the error
check needs to detect this as well as checking the pointer for being
NULL.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
fs: ubifs: Ensure buf is freed before return 2025-10-08T09:35:47+00:00 Andrew Goodbody andrew.goodbody@linaro.org 2025-10-03T10:42:50+00:00 d23ddd5dee570e625e0fd76bba1e155f4cc1248c Returning directly after buf has been allocated will result in a memory leak. Instead set the error code and goto the common unwind code to ensure that buf will be freed before returning. This issue was found by Smatch. Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> 
Returning directly after buf has been allocated will result in a memory
leak. Instead set the error code and goto the common unwind code to
ensure that buf will be freed before returning.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
fs: ubifs: Remove unnecessary assignment 2025-01-28T05:44:18+00:00 Michal Simek michal.simek@amd.com 2025-01-24T13:17:57+00:00 14e02d6c6180f85114cc0a90469e010a5d68b2ee Variable self assignment has been found by clang. But Linux kernel already fixed this problem by commit 2a068daf5742 ("ubifs: Remove unnecessary assignment") and commit ae4c8081eb77 ("ubifs: remove unnecessary assignment"). Signed-off-by: Michal Simek <michal.simek@amd.com> Reviewed-by: Alexander Dahl <ada@thorsis.com> Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com> Reviewed-by: Heiko Schocher <hs@denx.de> 
Variable self assignment has been found by clang. But Linux kernel already
fixed this problem by commit 2a068daf5742 ("ubifs: Remove unnecessary
assignment") and commit ae4c8081eb77 ("ubifs: remove unnecessary
assignment").

Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Alexander Dahl <ada@thorsis.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
ubifs: Call ubifs_iput when ubifs_iget is used 2024-08-11T04:52:15+00:00 Michael Trimarchi michael@amarulasolutions.com 2024-08-10T12:57:44+00:00 d16bda85ff0762aa96e36fa65d2e3b5342d73d7a The inode should be freed after a reference is get to avoid memory leak Tested-by: Alexander Dahl <ada@thorsis.com> Link: https://lore.kernel.org/u-boot/b698ec3e-d857-6512-8cc9-4edcab0a41b9@denx.de/T/#t Link: https://lore.kernel.org/all/8f3a7059-6330-f332-8e9f-729b853e001e@denx.de/T/ Co-developed-by: Heiko Schocher <hs@denx.de> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> 
The inode should be freed after a reference is get to avoid
memory leak

Tested-by: Alexander Dahl <ada@thorsis.com>
Link: https://lore.kernel.org/u-boot/b698ec3e-d857-6512-8cc9-4edcab0a41b9@denx.de/T/#t
Link: https://lore.kernel.org/all/8f3a7059-6330-f332-8e9f-729b853e001e@denx.de/T/
Co-developed-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
ubifs: mount fails after power cycle 2024-08-10T09:56:53+00:00 Ravi Minnikanti rminnikanti@marvell.com 2024-07-30T09:14:57+00:00 cf7ea719ce60cd885cce5023dfaf7833d9fc1442 When kernel uses file system encryption, fscrypt on UBIFS v5, after a hard power cycle UBIFS journal replay fails which results in mount failure. Failure logs: UBIFS: recovery needed UBIFS error (pid 0): ubifs_validate_entry: bad directory entry node UBIFS error (pid 0): replay_bud: bad node is at LEB 890:24576 UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume 'ubi0:rootfs' errno=-22! This change is ported from kernel: commit id: 304790c038bc4af4f19774705409db27eafb09fc Kernel commit description: Kernel commit description: ubifs: Relax checks in ubifs_validate_entry() With encrypted filenames we store raw binary data, doing string tests is no longer possible. Signed-off-by: rminnikanti <rminnikanti@marvell.com> Reviewed-by: Heiko Schocher <hs@denx.de> 
When kernel uses file system encryption, fscrypt on UBIFS v5,
after a hard power cycle UBIFS journal replay fails which results in mount failure.

Failure logs:
UBIFS: recovery needed
UBIFS error (pid 0): ubifs_validate_entry: bad directory entry node
UBIFS error (pid 0): replay_bud: bad node is at LEB 890:24576
UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume 'ubi0:rootfs' errno=-22!

This change is ported from kernel:
commit id: 304790c038bc4af4f19774705409db27eafb09fc

Kernel commit description:
    Kernel commit description:
    ubifs: Relax checks in ubifs_validate_entry()

    With encrypted filenames we store raw binary data, doing
    string tests is no longer possible.

Signed-off-by: rminnikanti <rminnikanti@marvell.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
fs: ubifs: Add volume mounted check 2024-08-10T09:54:28+00:00 Alexander Dahl ada@thorsis.com 2024-07-03T10:12:58+00:00 ca1f11d8c11dacd91c3bfd8e39d41db349e83f8b Safety guard in the U-Boot filesystem glue code, because these functions are called from different parts of the codebase. For generic filesystem handling this should have been checked in blk_get_device_part_str() already. Commands from cmd/ubifs.c should also check this before calling those functions, but you never know?! Signed-off-by: Alexander Dahl <ada@thorsis.com> 
Safety guard in the U-Boot filesystem glue code, because these functions
are called from different parts of the codebase.  For generic filesystem
handling this should have been checked in blk_get_device_part_str()
already.  Commands from cmd/ubifs.c should also check this before
calling those functions, but you never know?!

Signed-off-by: Alexander Dahl <ada@thorsis.com>