u-boot.git/fs, branch v2020.07-rc4

cbfs: Don't require the CBFS size with cbfs_init_mem()

2020-05-27T06:40:09+00:00

The size is not actually used since it is present in the header. Drop this
parameter. Also tidy up error handling while we are here.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Allow reading a file from a CBFS given its base addr

2020-05-27T06:40:09+00:00

Currently we support reading a file from CBFS given the address of the end
of the ROM. Sometimes we only know the start of the CBFS. Add a function
to find a file given that.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Change file_cbfs_find_uncached() to return an error

2020-05-27T06:40:09+00:00

This function currently returns a node pointer so there is no way to know
the error code. Also it uses data in BSS which seems unnecessary since the
caller might prefer to use a local variable.

Update the function and split its body out into a separate function so we
can use it later.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Return the error code from file_cbfs_init()

2020-05-27T06:40:09+00:00

We may as well return the error code and use it directly in the command
code. CBFS still uses its own error enum which we may be able to remove,
but leave it for now.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Record the start address in cbfs_priv

2020-05-27T06:40:09+00:00

The start address of the CBFS is used when scanning for files. It makes
sense to put this in our cbfs_priv struct and calculate it when we read
the header.

Update the code accordingly.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Use void * for the position pointers

2020-05-27T06:40:09+00:00

It doesn't make sense to use u8 * as the pointer type for accessing the
CBFS since we do not access it as bytes, but via structures. Change it to
void *, which allows us to avoid a cast.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Unify the two header loaders

2020-05-27T06:40:09+00:00

These two functions have mostly the same code. Pull this out into a common
function.

Also make this function zero the private data so that callers don't have
to do it. Finally, update cbfs_load_header_ptr() to take the base of the
ROM as its parameter, which makes more sense than passing the address of
the header within the ROM.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Adjust cbfs_load_header_ptr() to use cbfs_priv

2020-05-27T06:40:09+00:00

This function is strange at the moment in that it takes a header pointer
but then accesses the cbfs_s global. Currently clients have their own priv
pointer, so update the function to take that as a parameter instead.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Adjust file_cbfs_load_header() to use cbfs_priv

2020-05-27T06:40:09+00:00

This function is strange at the moment in that it takes a header pointer
but then accesses the cbfs_s global. Currently clients have their own priv
pointer, so update the function to take that as a parameter instead.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

cbfs: Adjust return value of file_cbfs_next_file()

2020-05-27T06:40:09+00:00

At present this uses a true return to indicate it found a file. Adjust it
to use 0 for this, so it is consistent with other functions.

Update its callers accordingly and add a check for malloc() failure in
file_cbfs_fill_cache().

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng