<feed xmlns='http://www.w3.org/2005/Atom'>
<title>u-boot.git/fs, branch v2021.01</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.
</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/'/>
<entry>
<title>fs/squashfs: sqfs_close/sqfs_read_sblk: set ctxt.sblk to NULL after free</title>
<updated>2020-12-02T21:21:58+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-24T17:07:52+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=7e932ac790b3615a67a3c24041c194aa748c0d98'/>
<id>7e932ac790b3615a67a3c24041c194aa748c0d98</id>
<content type='text'>
This will prevent a double free error if sqfs_close() is called twice.

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will prevent a double free error if sqfs_close() is called twice.

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs: fat: use ATTR_ARCH instead of anonymous 0x20</title>
<updated>2020-11-29T04:18:16+00:00</updated>
<author>
<name>Heinrich Schuchardt</name>
<email>xypron.glpk@gmx.de</email>
</author>
<published>2020-11-22T10:13:33+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=1ec29aa30623fc8cc8f4b014497aa0d72af96720'/>
<id>1ec29aa30623fc8cc8f4b014497aa0d72af96720</id>
<content type='text'>
Using constants instead of anonymous numbers increases code readability.

Fixes: 704df6aa0a28 ("fs: fat: refactor write interface for a file offset")
Signed-off-by: Heinrich Schuchardt &lt;xypron.glpk@gmx.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using constants instead of anonymous numbers increases code readability.

Fixes: 704df6aa0a28 ("fs: fat: refactor write interface for a file offset")
Signed-off-by: Heinrich Schuchardt &lt;xypron.glpk@gmx.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs: fat: directory entries starting with 0x05</title>
<updated>2020-11-29T04:18:16+00:00</updated>
<author>
<name>Heinrich Schuchardt</name>
<email>xypron.glpk@gmx.de</email>
</author>
<published>2020-11-21T11:34:20+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=a2c5a92d4865cea53de8a9297a4f4d115e6ac3b6'/>
<id>a2c5a92d4865cea53de8a9297a4f4d115e6ac3b6</id>
<content type='text'>
0x05 is used as replacement letter for 0xe5 at the first position of short
file names. We must not skip over directory entries starting with 0x05.

Cf. Microsoft FAT Specification, August 30 2005

Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
Signed-off-by: Heinrich Schuchardt &lt;xypron.glpk@gmx.de&gt;
Reviewed-by: Christian Gmeiner &lt;christian.gmeiner@gmail.com&gt;
Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
0x05 is used as replacement letter for 0xe5 at the first position of short
file names. We must not skip over directory entries starting with 0x05.

Cf. Microsoft FAT Specification, August 30 2005

Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
Signed-off-by: Heinrich Schuchardt &lt;xypron.glpk@gmx.de&gt;
Reviewed-by: Christian Gmeiner &lt;christian.gmeiner@gmail.com&gt;
Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs: fat: avoid NULL dereference when root dir is full</title>
<updated>2020-11-29T04:18:16+00:00</updated>
<author>
<name>Heinrich Schuchardt</name>
<email>xypron.glpk@gmx.de</email>
</author>
<published>2020-11-19T11:24:44+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=661d2238688c25f676aa18a7f866ff1cd285ff3d'/>
<id>661d2238688c25f676aa18a7f866ff1cd285ff3d</id>
<content type='text'>
When trying to create a file in the full root directory of a FAT32
filesystem a NULL dereference can be observed.

When the root directory of a FAT16 filesystem is full fill_dir_slot() must
return -1 to signal that a new directory entry could not be allocated.

Fixes: cd2d727fff7e ("fs: fat: allocate a new cluster for root directory of fat32")
Signed-off-by: Heinrich Schuchardt &lt;xypron.glpk@gmx.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When trying to create a file in the full root directory of a FAT32
filesystem a NULL dereference can be observed.

When the root directory of a FAT16 filesystem is full fill_dir_slot() must
return -1 to signal that a new directory entry could not be allocated.

Fixes: cd2d727fff7e ("fs: fat: allocate a new cluster for root directory of fat32")
Signed-off-by: Heinrich Schuchardt &lt;xypron.glpk@gmx.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs/squashfs: implement exists() function</title>
<updated>2020-11-19T14:45:49+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-03T11:11:26+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=dd4866b43754b18f0c06672e341d93e16b8bf674'/>
<id>dd4866b43754b18f0c06672e341d93e16b8bf674</id>
<content type='text'>
This permits to find a file and use the distro_bootcmd

Reviewed-by: Joao Marcos Costa &lt;jmcosta944@gmail.com&gt;
Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This permits to find a file and use the distro_bootcmd

Reviewed-by: Joao Marcos Costa &lt;jmcosta944@gmail.com&gt;
Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs/squashfs: sqfs_read: remove buggy offset functionality</title>
<updated>2020-11-19T14:45:49+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-03T11:11:24+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=21b1b3bad58b50e5464b1bf016e7c96bf18ddb8d'/>
<id>21b1b3bad58b50e5464b1bf016e7c96bf18ddb8d</id>
<content type='text'>
offset is the offset in the file read, not the offset in the destination
buffer.
If the offset is not null, this will lead to a memory corruption.
So, for now, we are returning an error if the offset is used.

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
offset is the offset in the file read, not the offset in the destination
buffer.
If the offset is not null, this will lead to a memory corruption.
So, for now, we are returning an error if the offset is used.

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs/squashfs: sqfs_read: don't write beyond buffer size</title>
<updated>2020-11-19T14:45:49+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-03T11:11:23+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=cbd5e40ede4e5c6aedce9475325bdf80b7fa839b'/>
<id>cbd5e40ede4e5c6aedce9475325bdf80b7fa839b</id>
<content type='text'>
The length of the buffer wasn't taken into account when writing to the
given buffer.

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The length of the buffer wasn't taken into account when writing to the
given buffer.

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs/squashfs: sqfs_probe: use sqfs_decompressor_init() return value</title>
<updated>2020-11-19T14:45:49+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-03T11:11:22+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=6d25bd3e9c1d317cdbd52a4c6bba11f912bb4d6a'/>
<id>6d25bd3e9c1d317cdbd52a4c6bba11f912bb4d6a</id>
<content type='text'>
sqfs_decompressor_init() returns a value, so it's better to use it than
to force the return value to EINVAL (it could be ENOMEM)

Reviewed-by: Joao Marcos Costa &lt;jmcosta944@gmail.com&gt;
Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sqfs_decompressor_init() returns a value, so it's better to use it than
to force the return value to EINVAL (it could be ENOMEM)

Reviewed-by: Joao Marcos Costa &lt;jmcosta944@gmail.com&gt;
Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs/squashfs: sqfs_probe: reset cur_dev/cur_part_info to NULL on error</title>
<updated>2020-11-19T14:45:49+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-03T11:11:21+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=56cf1ceee38435a0c105d40336d12d19e1db8b1d'/>
<id>56cf1ceee38435a0c105d40336d12d19e1db8b1d</id>
<content type='text'>
Resetting the context on error will prevent some checks like:
if (!ctx.cur_dev)
To pass when the probe method has failed

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resetting the context on error will prevent some checks like:
if (!ctx.cur_dev)
To pass when the probe method has failed

Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fs/squashfs: sqfs_probe: fix possible memory leak on error</title>
<updated>2020-11-19T14:45:49+00:00</updated>
<author>
<name>Richard Genoud</name>
<email>richard.genoud@posteo.net</email>
</author>
<published>2020-11-03T11:11:19+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.235523.xyz/u-boot.git/commit/?id=ccd4c08a452b3703ee16ba730a84b7caadcff97a'/>
<id>ccd4c08a452b3703ee16ba730a84b7caadcff97a</id>
<content type='text'>
If SquashFS magic number is invalid, there's a memory leak.

Reviewed-by: Joao Marcos Costa &lt;jmcosta944@gmail.com&gt;
Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If SquashFS magic number is invalid, there's a memory leak.

Reviewed-by: Joao Marcos Costa &lt;jmcosta944@gmail.com&gt;
Signed-off-by: Richard Genoud &lt;richard.genoud@posteo.net&gt;
</pre>
</div>
</content>
</entry>
</feed>
