u-boot.git/include/net.h, branch v2019.04

net: remove CONFIG_MCAST_TFTP

2019-01-24T17:35:30+00:00

No mainline board enables CONFIG_MCAST_TFTP and there have been
compilation issues with the code for some time. Additionally, it has a
potential buffer underrun issue (reported as a side note in
CVE-2018-18439).

Remove the multicast TFTP code but keep the driver API for the future
addition of IPv6.

Cc: Simon Goldschmidt 
Signed-off-by: Chris Packham 
Acked-by: Joe Hershberger

net: move ether_crc to tsec driver

2019-01-24T17:35:29+00:00

ether_crc was added to the core net code in commit 53a5c424bf86
("multicast tftp: RFC2090") so that other drivers could use it. However
the only current user of it is tsec.c so move it there.

Signed-off-by: Chris Packham 
Acked-by: Joe Hershberger

net: Consolidate UDP header functions

2018-10-10T17:29:02+00:00

Make it possible to add TCP versions of the same, while reusing
IP portions. This patch should not change any behavior.

Signed-off-by: Duncan Hare 
Acked-by: Joe Hershberger

net: Don't overwrite waiting packets with asynchronous replies

2018-10-10T17:29:01+00:00

Peter originally sent a fix, but it breaks a number of other things.
This addresses the original reported issue in a different way.

That report was:

> U-Boot has 1 common buffer to send Ethernet frames, pointed to by
> net_tx_packet.  When sending to an IP address without knowing the MAC
> address, U-Boot makes an ARP request (using the arp_tx_packet buffer)
> to find out the MAC address of the IP addressr. When a matching ARP
> reply is received, U-Boot continues sending the frame stored in the
> net_tx_packet buffer.
>
> However, in the mean time, if U-Boot needs to send out any network
> packets (e.g. replying ping packets or ARP requests for its own IP
> address etc.), it will use the net_tx_packet buffer to prepare the
> new packet. Thus this buffer is no longer the original packet meant
> to be transmitted after the ARP reply. The original packet will be
> lost.

This instead uses the ARP tx buffer to send async replies in the case
where we are actively waiting for an ARP reply.

Signed-off-by: Joe Hershberger 

Reported-by: Tran Tien Dat 
Reviewed-by: Simon Glass 
Reviewed-by: Bin Meng 
Tested-by: Bin Meng

net: Add an accessor to know if waiting for ARP

2018-10-10T17:28:58+00:00

This single-sources the state of the ARP.

Signed-off-by: Joe Hershberger 
Reviewed-by: Simon Glass 
Reviewed-by: Bin Meng

net.h: Include linux/if_ether.h to avoid duplication

2018-10-10T17:28:52+00:00

There are plenty of existing drivers that have macros like ETH_ALEN
defined in their own source files. Now that we imported the kernel's
if_ether.h to U-Boot we can reduce some duplication.

Signed-off-by: Bin Meng 
Acked-by: Joe Hershberger

net: Increase ethernet name string size to 20 chars

2018-08-08T15:23:49+00:00

The 16 char ethernet name size is inadequate to hold the name of ethernet
name "DPMAC17@rgmii-id", which is a valid name in LX2160AQDS/LX2160ARDB.

Therefore, increase the name string size to 20 chars.

Reported-by: Ioana Ciornei 
Suggested-by: Ioana Ciocoi Radulescu 
Signed-off-by: Pankaj Bansal 
Reviewed-by: York Sun

net: Consolidate the parsing of bootfile

2018-07-26T19:08:20+00:00

The same basic parsing was implemented in tftp and nfs, so add a helper
function to do the work once.

Signed-off-by: Joe Hershberger

net: When checking prerequisites, consider boot_file_name

2018-07-26T19:08:19+00:00

For net_boot_common, we allow the serverip to be specified as part of
the boot file name. For net commands that require serverip, include that
source as a valid specification of serverip.

Signed-off-by: Joe Hershberger 
Reviewed-by: Alexander Graf

net: Prefer command line arguments

2018-07-02T19:14:20+00:00

We can call commands like dhcp and bootp without arguments or with
explicit command line arguments that really should tell the code where
to look for files instead.

Unfortunately, the current code simply overwrites command line arguments
in the dhcp case with dhcp values.

This patch allows the code to preserve the command line values if they
were set on the command line. That way the semantics are slightly more
intuitive.

The reason this patch does that by introducing a new variable is that we
can not rely on net_boot_file_name[0] being unset, as today it's
completely legal to call "dhcp" and afterwards run "tftp" and expect the
latter to repeat the same query as before. I would prefer not to break
that behavior in case anyone relies on it.

Signed-off-by: Alexander Graf 
Acked-by: Joe Hershberger