u-boot.git/include/scsi.h, branch v2017.09

dm: scsi: Split out the bus scanning code

2017-07-11T16:08:19+00:00

Split out the code that scans a single SCSI bus into a separate function.
This will allow it to be used from driver model.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Add operations for SCSI devices

2017-07-11T16:08:19+00:00

The SCSI uclass currently has no operations. It just uses the global SCSI
functions. Fix this by adding operations to the only two drivers that use
the uclass, and replacing the global functions with those defined locally
in the SCSI code.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Document and rename the scsi_scan() parameter

2017-07-11T16:08:19+00:00

The 'mode' parameter is actually a flag to determine whether to display
a list of devices found during the scan. Rename it to reflect this, add a
function comment and adjust callers to use a boolean.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Add a device pointer to scan_exec(), scsi_bus_reset()

2017-07-11T16:08:19+00:00

With driver model these functions need a device pointer. Add one even
when CONFIG_DM_SCSI is not defined. This avoids having ugly conditional
function prototypes, When CONFIG_DM_SCSI is not defined we can just ignore
the pointer.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Add operations

2017-07-11T16:08:19+00:00

Add operations for SCSI. These are not yet implemented, but we have the
struct.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: ahci: Unwind the confusing init code

2017-07-11T16:08:19+00:00

Two AHCI drivers use SCSI with CONFIG_DM_SCSI. The SCSI uclass calls
scsi_low_level_init() which is implemented by ahci.c. If
CONFIG_SCSI_AHCI_PLAT is defined it does one thing and if it is not
it does something else.

We don't need to call through scsi_low_level_init() to get the init
completed. Instead, adjust the two drivers to call into AHCI directly.
Drop the post-probe init in the SCSI uclass. This means that driver model
doesn't need to use scsi_low_level_init(). It is a legacy function and
driver model should use a driver's probe() method instead.

While we are here, add a comment to the top of the file explaining what
ahci.c does.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Drop the ccb typedef

2017-07-11T16:08:19+00:00

We should not be using typedefs in U-Boot and 'ccb' is a pretty short
name. It is also used with variables. Drop the typedef and use 'struct'
instead.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Rename struct SCSI_cmd_block to struct scsi_cmd

2017-07-11T16:08:19+00:00

This name should be lower case. Also the _block suffix is superfluous.
Rename it.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

dm: scsi: Rearrange header file for driver model

2017-07-11T16:08:19+00:00

Put the driver-model declarations first since we are migrating to that.
Also drop scsi_init() when driver model is used.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

scsi: Drop scsi_print_error()

2017-07-11T16:08:19+00:00

This function is only defined by one driver and is empty. Move it into
the SCSI implementation itself. We could remove it, but it should be
useful for debugging.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng