u-boot.git/lib/efi_driver, branch v2023.10

efi_loader: make efi_delete_handle() follow the EFI spec

2023-07-28T09:36:37+00:00

The EFI doesn't allow removal of handles, unless all hosted protocols
are cleanly removed.  Our efi_delete_handle() is a bit intrusive.
Although it does try to delete protocols before removing a handle,
it doesn't care if that fails.  Instead it only returns an error if the
handle is invalid. On top of that none of the callers of that function
check the return code.

So let's rewrite this in a way that fits the EFI spec better.  Instead
of forcing the handle removal, gracefully uninstall all the handle
protocols.  According to the EFI spec when the last protocol is removed
the handle will be deleted.  Also switch all the callers and check the
return code. Some callers can't do anything useful apart from reporting
an error.  The disk related functions on the other hand, can prevent a
medium that is being used by EFI from removal.

The only function that doesn't check the result is efi_delete_image().
But that function needs a bigger rework anyway, so we can clean it up in
the future

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_driver: fix duplicate efiblk#0 issue

2023-07-20T07:12:50+00:00

The devnum value of the blk_desc structure starts from 0,
current efi_bl_create_block_device() function creates
two "efiblk#0" devices for the cases that blk_find_max_devnum()
returns -ENODEV and blk_find_max_devnum() returns 0(one device
found in this case).

This commit uses blk_next_free_devnum() instead of blk_find_max_devnum().

Signed-off-by: Masahisa Kojima 
Reviewed-by: Heinrich Schuchardt

efi_driver: use efi_close_protocol

2022-10-10T14:34:26+00:00

Avoid EFI_CALL() by using efi_close_protocol().

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_driver: fix efi_uc_stop()

2022-10-10T14:34:25+00:00

We must always call EFI_EXIT() when returning from an EFIAPI function.

Fixes: 05ef48a2484b ("efi_driver: EFI block driver")
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_driver: move event registration to driver

2022-10-06T20:54:58+00:00

Move the registration of events for the addition and removal of block
devices to the block device driver. Here we can add a reference to the
EFI Driver Binding protocol as context.

Signed-off-by: Heinrich Schuchardt

efi_driver: add init function to EFI block driver

2022-10-06T20:54:58+00:00

For handling added and removed block devices we need to register events
which has to be done when the driver is installed.

This patch only creates an empty init function that will be filled with
code later on. The function needs to be called before any EFI block devices
are used. Move the efi_driver_init() call to early init.

Signed-off-by: Heinrich Schuchardt

efi_driver: provide driver binding protocol to bind function

2022-10-06T20:54:57+00:00

DisconnectController() is based on the open protocol information created
when the driver opens a protocol with BY_CHILD_CONTROLLER or BY_DRIVER.

To create an open protocol information it is required to supply the handle
of the driver as agent handle. This information is available as field
DriverBindingHandle in the driver binding protocol.

Signed-off-by: Heinrich Schuchardt

efi_driver: reformat efi_block_device.c

2022-10-06T20:54:57+00:00

* use Sphinx documentation style
* correct indentation

Signed-off-by: Heinrich Schuchardt

efi_driver: carve out function to create block device

2022-10-06T20:54:57+00:00

* Carve out function efi_bl_create_block_device() from efi_bl_bind().
* Add a check for U-Boot devices to efi_bl_bind().

Signed-off-by: Heinrich Schuchardt

efi_driver: simplify efi_uc_stop(), call efi_free_pool()

2022-10-06T20:54:57+00:00

We have exported efi_free_pool(). There is no need to use EFI_CALL().

Signed-off-by: Heinrich Schuchardt