u-boot.git/lib/efi_loader/efi_boottime.c, branch v2017.11

efi_loader: Disable env_save() call on boot

2017-10-29T11:59:08+00:00

With the introduction of EFI variable support, we also wanted to persist
these EFI variables. However, the way it was implemented we ended up
persisting all U-Boot environment variables on every EFI boot.

That could potentially lead to unexpected side effects because variables
that were not supposed to be written to persisted env get written. It also
means we may end up writing the environment more often than we should.

For this release, let's just disable EFI variable persistence and instead
implement it properly for the next one.

Reported-by: Heinrich Schuchardt 
Fixes: ad644e7c182 ("efi_loader: efi variable support")
Signed-off-by: Alexander Graf 
Acked-by: Rob Clark 
Reviewed-by: Heinrich Schuchardt

efi_loader: comments for functions add missing @return

2017-10-09T05:00:38+00:00

For some functions the @return description is missing.

Fix typo.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: avoid NULL dereference in efi_dp_match

2017-10-09T05:00:37+00:00

When calling bootefi hello twice a kernel dump occurs.

Neither bootefi hello nor bootefi selftest have an image
device patch. So do not try to dereference the NULL
value.

Fixes: 95c5553ea26 efi_loader: refactor boot device and loaded_image handling
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: wrong type in wait_for_event

2017-10-09T05:00:30+00:00

The UEFI spec defines parameter index of WaitForEvent as UINTN*.
So we should use size_t here.

I deliberately do not use UINTN because I hold a following patch
that will eliminate UINTN because uppercase types to not match
the U-Boot coding style.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: pass GUIDs as const efi_guid_t *

2017-10-09T05:00:30+00:00

We need to call some boottime services internally.
Our GUIDs are stored as const efi_guid_t *.

The boottime services never change GUIDs.
So we can define the parameters as const efi_guid_t *.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: parameters of CopyMem and SetMem

2017-10-09T05:00:29+00:00

The UEFI spec defines the length parameters of CopyMem and SetMem
as UINTN. We should size_t here.

The source buffer of CopyMem should be marked as const.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: call EFI_EXIT in efi_copy_mem, efi_set_mem

2017-10-09T05:00:29+00:00

EFI_ENTRY and EFI_EXIT calls must match.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: replace efi_div10 by do_div

2017-10-09T05:00:29+00:00

We should use the existing 64bit division instead of
reinventing the wheel.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: provide function comments for boot services

2017-10-09T05:00:28+00:00

Provide comments describing the boot service functions.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: use type bool for event states

2017-10-09T04:59:38+00:00

Queued and signaled describe boolean states of events.
So let's use type bool and rename the structure members to is_queued
and is_signaled.

Update the comments for is_queued and is_signaled.

Reported-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Rob Clark 
Reviewed-by: Rob Clark 
Signed-off-by: Alexander Graf