u-boot.git/lib/efi_loader/efi_boottime.c, branch v2018.01

efi_loader: error handling in efi_load_image()

2017-12-16T22:07:55+00:00

If a failure occurs when trying to load an image, it is insufficient
to free() the EFI object. We must remove it from the object list,
too. Otherwise a use after free will occur the next time we
iterate over the object list.

Furthermore errors in setting up the image should be handled.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: new function efi_delete_handle()

2017-12-16T22:07:36+00:00

Provide a function to remove a handle from the object list
after removing all protocols.

To avoid forward declarations other functions have to move up
in the coding.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: return status from efi_setup_loaded_image()

2017-12-16T22:07:25+00:00

efi_setup_loaded_image() should return an error code indicating if
an error has occurred.

An error occurs if a protocol cannot be installed.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: helper function to add EFI object to list

2017-12-01T12:41:01+00:00

To avoid duplicate coding provide a helper function that
initializes an EFI object and adds it to the EFI object
list.

efi_exit() is the only place where we dereference a handle
to obtain a protocol interface. Add a comment to the function.

Suggested-by: Alexander Graf 
Reviewed-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: pass handle of loaded image

2017-12-01T12:40:07+00:00

The handle of a loaded image is the value of the handle
member of the loaded image info object and not the
address of the loaded image info.

Reviewed-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: manage protocols in a linked list

2017-12-01T12:37:49+00:00

Reviewed-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: simplify efi_open_protocol

2017-12-01T12:37:06+00:00

Use function efi_search_protocol.

Reviewed-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: reimplement LocateDevicePath

2017-12-01T12:35:30+00:00

The current implementation of efi_locate_device_path does not match
the UEFI specification. It completely ignores the protocol
parameters.

Reviewed-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: refactor efi_setup_loaded_image

2017-12-01T12:22:56+00:00

Use helper functions to add protocols.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: simplify efi_locate_protocol

2017-12-01T12:22:56+00:00

Use helper function efi_search_protocol.

Do not print protocol guid twice in debug mode.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf