u-boot.git/lib/efi_loader/efi_boottime.c, branch v2018.09

efi_loader: update runtime services table crc32

2018-08-20T12:43:12+00:00

The crc32 of the runtime services table must be updated after detaching.

efi_update_table_header_crc32() must be __efi_runtime. So move it to
efi_runtime.c

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: fix a parameter check at CreateEvent()

2018-08-20T12:39:35+00:00

The commit 21b3edfc9644 ("efi_loader: check parameters of CreateEvent")
enforces a strict parameter check at CreateEvent(). On the other hand,
UEFI specification version 2.7, section 7.1, says:

    The EVT_NOTIFY_WAIT and EVT_NOTIFY_SIGNAL flags are exclusive. If
    neither flag is specified, the caller does not require any notification
    concerning the event and the NotifyTpl, NotifyFunction, and
    NotifyContext parameters are ignored.

So the check should be mitigated so as to comply with the specification.
Without this patch, EDK2's Shell.efi won't be started.

Fixes: 21b3edfc9644 ("efi_loader: check parameters of CreateEvent")
Signed-off-by: AKASHI Takahiro 
Reviewed-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: update crc32 in InstallConfigurationTable

2018-07-25T13:00:24+00:00

If the number of installed tables is changed in
InstallConfigurationTable() update the crc32 of the system table.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: correct signature of CalculateCrc32()

2018-07-25T13:00:24+00:00

Use const for the buffer. We are not changing the buffer.
Use efi_uintn_t where prescribed by the UEFI spec.
Prefer u32 over uint32_t.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: allocate configuration table array

2018-07-25T13:00:24+00:00

The system table contains a link to the list of configurations tables.
These include the device tree, SMBIOS table, and the ACPI table.

This array is currently statically linked. With the patch it is allocated
as EFI_RUNTIME_SERVICES_DATA. Due to the structure of the system table we
cannot work with a linked list here.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Bin Meng 
Signed-off-by: Alexander Graf

efi_loader: calculate crc32 for EFI tables

2018-07-25T13:00:24+00:00

For the boot and runtime services tables and for the system table the
crc32 has to be set in the header.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Bin Meng 
Signed-off-by: Alexander Graf

efi_loader: provide firmware revision

2018-07-25T12:59:44+00:00

Provide a firmware revision in the system table using the Makefile
variables VERSION and PATCHLEVEL, e.g. 0x20180700 for v2018.07.

Correct the type of the firmware vendor. It is a u16* pointer.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Bin Meng 
Signed-off-by: Alexander Graf

efi_loader: correct headersize EFI tables

2018-07-25T12:59:44+00:00

The headersize field has to be set to the size of the whole table
including the header.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Bin Meng 
Signed-off-by: Alexander Graf

efi_loader: specify UEFI spec revision

2018-07-25T12:59:44+00:00

Both in the boot and the runtime services tables we have to specify the
UEFI spec revision. The same value is already used for the system
table. So let's use a common constant.

In the boot services table we have to provide the header signature.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Bin Meng 
Signed-off-by: Alexander Graf

efi_loader: set revision in loaded image protocol

2018-07-25T12:59:44+00:00

The revision number has to be set in the loaded image protocol.

The problem was detected by running the SCT in
Protocol/LoadedImage/BlackBoxTest/LoadedImageBBTestMain.c:890

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf