u-boot.git/lib/efi_loader/efi_boottime.c, branch v2018.11

efi_loader: fix typo in efi_boottime.c

2018-10-16T14:44:26+00:00

%s/conncected/connected/

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: Fix warning in efi_load_image()

2018-10-16T14:41:18+00:00

As observed with clang:
lib/efi_loader/efi_boottime.c:1624:7: warning: variable 'info'
      is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
                if (ret != EFI_SUCCESS)
                    ^~~~~~~~~~~~~~~~~~
lib/efi_loader/efi_boottime.c:1653:7: note: uninitialized use
      occurs here
        free(info);
             ^~~~
lib/efi_loader/efi_boottime.c:1624:3: note: remove the 'if' if
      its condition is always false
                if (ret != EFI_SUCCESS)
                ^~~~~~~~~~~~~~~~~~~~~~~
lib/efi_loader/efi_boottime.c:1602:31: note: initialize the
      variable 'info' to silence this warning
        struct efi_loaded_image *info;
                                     ^
                                      = NULL

Rather than change how we unwind the function it makes the most sense to
initialize info to NULL so that we can continue to pass it to free().

Fixes: c982874e930d ("efi_loader: refactor efi_setup_loaded_image()")
Signed-off-by: Tom Rini 
Reviewed-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: efi_allocate_pool(EFI_ALLOCATE_ANY_PAGES, ...)

2018-10-16T14:16:49+00:00

The first parameter of efi_allocate_pool is a memory type. It cannot be
EFI_ALLOCATE_ANY_PAGES. Use EFI_BOOT_SERVICES_DATA instead.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: refactor efi_setup_loaded_image()

2018-09-23T19:55:31+00:00

Create the handle of loaded images and the EFI_LOADED_IMAGE_PROTOCOL
inside efi_setup_loaded_image(). Do not use local variables.

Currently we expect the loaded image handle to point to the loaded image
protocol. Additionally we have appended private fields to the protocol.

With the patch the handle points to a loaded image object and the private
fields are added here. This matches how we handle the net and the gop
object.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: remove efi_exit_caches()

2018-09-23T19:55:31+00:00

Since GRUB patch d0c070179d4d ("arm/efi: Switch to arm64 linux loader",
2018-07-09) we do not need a workaround for GRUB on 32bit ARM anymore.

So let's eliminate function efi_exit_caches().

This will require Linux distributions to update grub-efi-arm to the GRUB
git HEAD (a tag containing the aforementioned GRUB patch is not available
yet).

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: create root node

2018-09-23T19:55:31+00:00

Currently we assign a lot of protocols to loaded images though
these protocols are not related to them. Instead they should be
installed on a separate handle. Via the device path it is the
parent to the devices like the network adapter.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: EFI_UNICODE_COLLATION_PROTOCOL

2018-09-23T19:55:29+00:00

The patch implements the EFI_UNICODE_COLLATION_PROTOCOL.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: use correct documentation style

2018-09-23T19:55:29+00:00

We have moved generating html documentation with Sphinx.

%s/Return Value/Return/g

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: fix typos in efi_boottime.c

2018-09-23T19:55:29+00:00

Fix numerous typos.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: pass system table in loaded image protocol

2018-09-23T19:55:28+00:00

The system table must be passed as a pointer in the loaded image
protocol.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf