u-boot.git/lib/efi_loader/efi_boottime.c, branch v2019.04

efi_loader: remove superfluous check in efi_setup_loaded_image()

2019-03-20T17:16:53+00:00

It does not make any sense to check if a pointer is NULL if we have
dereferenced it before.

Reported-by: Coverity (CID 185827)
Signed-off-by: Heinrich Schuchardt

efi_loader: fix EFI entry counting

2019-02-16T14:42:20+00:00

`bootefi selftest` fails on qemu-x86_defconfig if efi_selftest() is not
invoked using EFI_CALL().

Likewise we call the entry point of EFI payloads with
EFI_CALL(efi_start_image()).

entry_count indicates if we are in U-Boot (1) or in EFI payload code (0).
As we start in U-Boot code the initial value has to be 1.

Signed-off-by: Heinrich Schuchardt

efi_loader: use efi_start_image() for bootefi

2019-02-16T14:42:20+00:00

Remove the duplicate code in efi_do_enter() and use efi_start_image() to
start the image invoked by the bootefi command.

Signed-off-by: Heinrich Schuchardt

efi_loader: set entry point in efi_load_pe()

2019-02-16T14:42:20+00:00

Up to now efi_load_pe() returns the entry point or NULL in case of an
error. This does not allow to return correct error codes from LoadImage().

Let efi_load_pe() return a status code and fill in the entry point in the
corresponding field of the image object.

Signed-off-by: Heinrich Schuchardt

efi_loader: LoadImage: always allocate new pages

2019-02-16T14:42:20+00:00

If we want to properly unload images in Exit() the memory should always be
allocated in the same way. As we allocate memory when reading from file we
should do the same when the original image is in memory.

A further patch will be needed to free the memory when Exit() is called.

Signed-off-by: Heinrich Schuchardt

efi_loader: error handling in efi_setup_loaded_image()

2019-02-16T14:42:20+00:00

In case of an error we should set the returned pointers to NULL. This
ensures that an illegal free does not occur even if the caller calls
free() for the handles.

If protocols cannot be installed, release all resources.

Signed-off-by: Heinrich Schuchardt

efi_loader: Make HII a config option

2019-02-13T08:40:06+00:00

Heinrich ran into issues with HII and iPXE which lead to #SErrors on
his Odroid-C2 system. We definitely do not want to regress just yet,
so let's not expose the HII protocols by default.

Instead, let's make it a config option that people can play with
This way, we can stabilize the code in tree without breaking any
users.

Once someone figures out, why this breaks iPXE (probably a NULL
dereference), we can enable it by default.

Reported-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf 

---

v1 -> v2:

  - Remove HII selftest as well

v2 -> v3:

  - Make config option

efi: hii: add HII config routing/access protocols

2019-02-13T08:40:06+00:00

This patch is a place holder for HII configuration routing protocol and
HII configuration access protocol.

Signed-off-by: AKASHI Takahiro 
Signed-off-by: Alexander Graf

efi_loader: Initial HII database protocols

2019-02-13T08:40:06+00:00

This patch provides enough implementation of the following protocols to
run EDKII's Shell.efi and UEFI SCT:

  * EfiHiiDatabaseProtocol
  * EfiHiiStringProtocol

Not implemented are:
  * ExportPackageLists()
  * RegisterPackageNotify()/UnregisterPackageNotify()
  * SetKeyboardLayout() (i.e. *current* keyboard layout)

HII database protocol in this patch series can handle only:
  * GUID package
  * string package
  * keyboard layout package
  (The other packages, except Device path package, will be necessary
   for interactive and graphical UI.)

Signed-off-by: Leif Lindholm 
Signed-off-by: Rob Clark 
Signed-off-by: AKASHI Takahiro 
Signed-off-by: Alexander Graf

efi_loader: fix CopyMem()

2019-02-13T08:40:06+00:00

CopyMem() must support overlapping buffers. So replace memcpy() by
memmove().

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf