u-boot.git/lib/efi_loader/efi_boottime.c, branch v2025.01-rc2

efi_loader: use list_count_nodes() in efi_protocols_per_handle()

2024-08-11T05:47:23Z

Simplify the code by using the list_count_nodes() function. Signed-off-by: Heinrich Schuchardt

efi_loader: export efi_load_image_from_path

2024-06-10T09:43:36Z

We can reuse this function to load the device-tree. Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas

efi_loader: allow concatenation with contained end node

2024-06-10T09:43:36Z

Allow appending a device-path to a device-path that contains an end node as separator. We need this feature for creating boot options specifying kernel, initrd, and dtb. Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas

efi_loader: Clean up efi_dp_append and efi_dp_concat

2024-01-13T17:17:47Z

Looking back at the initrd storing functionality, we introduced three functions, efi_dp_append_or_concatenate(), efi_dp_append/concat(). In hindsight we could have simplified that by a lot. First of all none of the functions append anything. They all allocate a new device path and concatenate the contents of two device paths in one. A boolean parameter controls the final device path -- if that's true an end node is injected between the two device paths. So let's rewrite this and make it a bit easier to read. Get rid of efi_dp_append(), efi_dp_concat() and rename efi_dp_append_or_concatenate() to efi_dp_concat(). This is far more intuitive and the only adjustment that is needed is an extra boolean argument on all callsites. Signed-off-by: Ilias Apalodimas

efi_loader: Remove

2023-12-21T13:54:37Z

We largely do not need in these files, so drop it. The only exception here is that efi_freestanding.c needs and had been getting that via . Reviewed-by: Simon Glass Signed-off-by: Tom Rini

Merge tag 'v2024.01-rc5' into next

2023-12-18T14:55:32Z

Prepare v2024.01-rc5

efi_loader: Make DisconnectController follow the EFI spec

2023-12-05T00:38:56Z

commit 239d59a65e20 ("efi_loader: reconnect drivers on failure") tried to fix the UninstallProtocol interface which must reconnect any controllers it disconnected by calling ConnectController() in case of failure. However, the reconnect functionality was wired in efi_disconnect_all_drivers() instead of efi_uninstall_protocol(). As a result some SCT tests started failing. Specifically, BBTestOpenProtocolInterfaceTest333CheckPoint3() test - Calls ConnectController for DriverImageHandle1 - Calls DisconnectController for DriverImageHandle1 which will disconnect everything apart from TestProtocol4. That will remain open on purpose. - Calls ConnectController for DriverImageHandle2. TestProtocol4 which was explicitly preserved was installed wth BY_DRIVER attributes. The new protocol will call DisconnectController since its attributes are BY_DRIVER|EXCLUSIVE, but TestProtocol4 will not be removed. The test expects EFI_ACCESS_DENIED which works fine. The problem is that DisconnectController, will eventually call EFI_DRIVER_BINDING_PROTOCOL.Stop(). But on the aforementioned test this will call CloseProtocol -- the binding protocol is defined in 'DBindingDriver3.c' and the .Stop function uses CloseProtocol. If that close protocol call fails with EFI_NOT_FOUND, the current code will try to mistakenly reconnect all drivers and the subsequent tests that rely on the device being disconnected will fail. Move the reconnection in efi_uninstall_protocol() were it belongs. Fixes: commit 239d59a65e20 ("efi_loader: reconnect drivers on failure") Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

efi_loader: add return to efibootmgr event group

2023-11-18T08:08:09Z

When the image loaded by efibootmgr returns, efibootmgr needs to clean the resources. Adding the event of returning to efibootmgr is useful to simplify the implementation. Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas

efi_loader: add missing const classifier for event service

2023-11-18T08:08:09Z

const classifier is missing in EventGroup parameter of CreateEventEx(). Fix it to remove the compiler warning. NotifyContext parameter of CreateEventEx() is also defined with const in UEFI specification, but NotifyContext parameter of CreateEvent() is defined without const. Since current implementation calls the common efi_create_event() function from both CreateEventEx() and CreateEvent() services, NotifyContext parameter leaves as is. Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas

efi_loader: delete handle from events when a protocol is uninstalled

2023-08-27T06:21:08Z

When a notification event is registered for a protocol the handle of the protocol is added in our event notification list. When all the protocols of the handle are uninstalled we delete the handle but we do not remove it from the event notification list. Clean up the protocol removal functions and add a wrapper which - Removes the to-be deleted handle from any lists it participates - Remove the handle if no more protocols are present Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt