u-boot.git/lib/efi_loader/efi_device_path.c, branch v2024.01

efi_loader: simplify dp_fill()

2023-07-28T09:36:37+00:00

Move the recursive dp_fill(dev->parent) call to a single location.
Determine uclass_id only once.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass

efi_loader: device paths for special block devices

2023-07-28T09:36:37+00:00

The UEFI specification does not provide node types matching UCLASS_BLKMAP,
UCLASS_HOST, UCLASS_VIRTIO block devices.

The current implementation uses VenHw() nodes with uclass specific GUIDs
and a single byte for the device number appended. This leads to unaligned
integers in succeeding device path nodes.

The current implementation fails to create unique device paths for block
devices based on other uclasses like UCLASS_PVBLOCK.

Let's use a VenHw() node with the U-Boot GUID with a length dividable by
four and encoding blkdesc->uclass_id as well as  blkdesc->devnum.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: support all uclasses in device path

2023-07-20T07:12:50+00:00

On devices with multiple USB mass storage devices errors like

    Path /../USB(0x0,0x0)/USB(0x1,0x0)/Ctrl(0x0)
    already installed.

are seen. This is due to creating non-unique device paths. To uniquely
identify devices we must provide path nodes for all devices on the path
from the root device.

Add support for generating device path nodes for all uclasses.

Reported-by: Suniel Mahesh 
Signed-off-by: Heinrich Schuchardt

efi_loader: fix dp_fill() for BLKMAP, HOST, VIRTIO

2023-07-20T07:12:50+00:00

Do not assume that the preceding device path contains a single VenHW node.
Instead use the return value of dp_fill() which provides the address of the
next node.

Fixes: 23ad52fff4da ("efi_loader: device_path: support Sandbox's "host" devices")
Fixes: 19ecced71cfb ("efi_loader: device path for virtio block devices")
Fixes: 272ec6b45304 ("efi_loader: device_path: support blkmap devices")
Signed-off-by: Heinrich Schuchardt

efi_loader: check return value of part_get_info()

2023-06-02T08:59:15+00:00

part_get_info() may return an error code. Check it.
Update function description of dp_part_node().

Addresses-Coverity-ID: 184067 ("Unchecked return value")
Signed-off-by: Heinrich Schuchardt

efi_loader: fix efi_dp_from_file()

2023-05-13T09:09:51+00:00

* When called from efi_dp_from_name() we miss to append the filename
  for non-block devices.
* expand_media_path() could be simplified by using efi_dp_from_file to
  prepend the device path of the boot device.

This can be avoided by passing a device path to efi_dp_from_file() instead
of a block device descriptor and a partition number.

Signed-off-by: Heinrich Schuchardt

efi_loader: simplify efi_dp_from_name()

2023-05-13T09:09:51+00:00

Don't do the same check and assignment in multiple places.

Signed-off-by: Heinrich Schuchardt

efi_loader: error code efi_dp_from_name()

2023-05-13T09:09:51+00:00

Use EFI_OUT_OF_RESOURCES if the device path cannot be constructed.

Signed-off-by: Heinrich Schuchardt

efi_loader: clean up efi_dp_from_file

2023-05-13T09:09:51+00:00

* Improve variable name usage: Use pos instead of buf to indicate the
  current position in a buffer.
* Avoid double assignment in a single code line.

Signed-off-by: Heinrich Schuchardt

efi_loader: duplicate code in efi_dp_from_name

2023-05-13T09:09:51+00:00

efi_dp_from_name() has duplicate code to replace slash by backslash.
path_to_uefi() called by efi_dp_from_file() already does this.

Signed-off-by: Heinrich Schuchardt