u-boot.git/lib/efi_loader/efi_file.c, branch v2020.01

efi_loader: parameter checks EFI_FILE_PROTOCOL.SetInfo()

2019-09-11T19:51:38+00:00

We do not support volume label changes. No parameter checks are needed
here.

When the info for as file is changed the buffer must always contain a file
name.

Signed-off-by: Heinrich Schuchardt

efi_loader: check parameters EFI_FILE_PROTOCOL.GetInfo()

2019-09-09T13:21:09+00:00

Check the parameters of EFI_FILE_PROTOCOL.GetInfo() to avoid possible NULL
dereference.

Check the buffer size for EFI_FILE_SYSTEM_INFO.

Signed-off-by: Heinrich Schuchardt

efi_loader: volume name in EFI_FILE_PROTOCOL.GetInfo()

2019-09-09T13:21:09+00:00

We cannot determine the volume name in U-Boot. Instead of providing a dummy
volume name in case of EFI_FILE_SYSTEM_INFO and EFI_UNSUPPORTED in case of
EFI_FILE_SYSTEM_VOLUME_LABEL consistently return an empty string.

Signed-off-by: Heinrich Schuchardt

efi_loader: EFI_FILE_PROTOCOL rev 2 stub

2019-09-09T13:21:09+00:00

The UEFI specification requires to implement version 2 of the
EFI_FILE_PROTOCOL. Provide the missing functions as stubs.

Signed-off-by: Heinrich Schuchardt

efi_loader: file size checks

2019-09-09T13:21:08+00:00

The file size has to be determined in multiple places. Factor out a common
function.

If on entry into EFI_FILE_PROTOCOL.Read() the current position is beyond
the end of the file, return EFI_DEVICE_ERROR.

Signed-off-by: Heinrich Schuchardt

efi_loader: correct reading of directories

2019-09-09T13:21:08+00:00

EFI_FILE_PROTOCOL.Read() is used both to read files and directories.

When reaching the end of a directory we always have to return buffer size
zero irrespective of the incoming buffer size. (The described scenario for
a Shim quirk cannot arise because every directory has at least '.' and '..'
as entries.)

Even when the buffer_size is too small multiple times we have to keep a
reference to our last read directory entry.

When we return to the start of the directory via SetPosition() we must
remove the reference to a previously kept directory entry.

Signed-off-by: Heinrich Schuchardt

efi_loader: eliminate inline function ascii2unicode()

2019-09-09T13:21:08+00:00

ascii2unicode() can only convert characters 0x00-0x7f from UTF-8 to UTF-16.
Use utf8_utf16_strcpy() instead.

Signed-off-by: Heinrich Schuchardt

efi_loader: EFI_FILE_PROTOCOL.Write() check args

2019-09-09T13:21:08+00:00

Check the parameters passed to Write():

* cannot write to directories (UEFI SCT 2017, 5.7.3.5.15)
* cannot write to file opened read only (UEFI SCT 2017, 5.7.3.5.16)

Add missing comments.

Signed-off-by: Heinrich Schuchardt

efi_loader: unaligned access in efi_file_from_path()

2019-07-16T22:17:23+00:00

The device path structure is packed. So no assumption on the alignment is
possible. Copy the file name in efi_file_from_path() to assure there is no
unaligned access.

Signed-off-by: Heinrich Schuchardt

efi_loader: Delete() return EFI_WARN_DELETE_FAILURE

2019-06-20T22:26:19+00:00

If EFI_FILE_PROTOCOL.Delete() fails, always close the handle and return
EFI_WARN_DELETE_FAILURE.

Signed-off-by: Heinrich Schuchardt