u-boot.git/lib/efi_loader/efi_file.c, branch v2023.07.01

efi_loader: replace a u16_strdup with alloc + memcpy

2022-11-16T07:34:06Z

Heinrich reports that on RISC-V unaligned access is emulated by OpenSBI which is very slow. Performance wise it's better if we skip the calls to u16_strdup() -- which in turn calls u16_strsize() and just allocate/copy the memory directly. The access to dp.length may still be unaligned, but that's way less than what u16_strsize() would do Signed-off-by: Ilias Apalodimas Use malloc() instead of calloc(). Reviewed-by: Heinrich Schuchardt

efi_loader: add missing EFI_CALL when closing a file

2022-11-16T07:34:06Z

Closing the files uses the EFI protocol and specifically it's .close callback. This needs to be wrapped on an EFI_CALL() Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-16T07:34:06Z

UEFI specification requires pointers that are passed to protocol member functions to be aligned. There's a u16_strdup in that function which doesn't make sense otherwise Add a comment so no one removes it accidentally Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

efi_loader: improve description of efi_file_from_path()

2022-11-16T07:34:06Z

Provide a description of the function's logic. Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas

eficonfig: menu-driven addition of UEFI boot option

2022-09-14T06:43:31Z

This commit add the "eficonfig" command. The "eficonfig" command implements the menu-driven UEFI boot option maintenance feature. This commit implements the addition of new boot option. User can select the block device volume having efi_simple_file_system_protocol and select the file corresponding to the Boot#### variable. User can also enter the description and optional_data of the BOOT#### variable in utf8. This commit adds "include/efi_config.h", it contains the common definition to be used from other menus such as UEFI Secure Boot key management. Signed-off-by: Masahisa Kojima

efi_loader: correct function comment style

2022-01-29T09:23:40Z

Replace @return and @param. Signed-off-by: Heinrich Schuchardt

efi_loader: use %pUs for printing GUIDs

2022-01-19T15:16:33Z

For printing GUIDs with macro EFI_ENTRY use %pUs instead of %pUl to provide readable debug output. Signed-off-by: Heinrich Schuchardt

efi_loader: provide file attributes in EFI_FILE_PROTOCOL.Read()

2021-07-12T18:30:48Z

When reading a directory using EFI_FILE_PROTOCOL.Read() provide file attributes and timestamps. Signed-off-by: Heinrich Schuchardt

efi_loader: loosen buffer parameter check in efi_file_read_int

2021-05-18T10:36:12Z

This is same issue as https://bugzilla.redhat.com/show_bug.cgi?id=1733817, but that fix was wrongly partial reverted. When reading a directory, EFI_BUFFER_TOO_SMALL should be returned when the supplied buffer is too small, so a use-case is to call EFI_FILE_PROTOCOL.Read() with *buffer_size=0 and buffer=NULL to obtain the needed size before doing the actual read. So remove the check only for directory reading, file reading already do the check by itself. Fixes: db12f518edb0("efi_loader: implement non-blocking file services") Signed-off-by: Peng Fan Cc: Stefan Sørensen Tested-by: Peter Robinson Reviewed-by: Heinrich Schuchardt

efi_loader: Add helper functions for EFI

2021-03-25T19:14:25Z

A following patch introduces a different logic for loading initrd's based on the EFI_LOAD_FILE2_PROTOCOL. Since similar logic can be applied in the future for other system files (i.e DTBs), let's add some helper functions which will retrieve and parse file paths stored in EFI variables. Signed-off-by: Ilias Apalodimas