u-boot.git/lib/efi_loader/efi_firmware.c, branch next

efi_loader: Assure fitImage from capsule is used from 8-byte aligned address

2025-11-15T10:50:42+00:00

The fitImage may be stored in EFI update capsule at address that
is not aligned to 8 bytes. Since fitImage is a DT, new version of
libfdt 1.7.2 rejects such an unaligned DT. Patch the code and copy
the fitImage into aligned buffer in case it is not aligned. This
does increase overhead for unaligned fitImages in EFI capsules, but
tries to keep the overhead low for aligned ones.

Signed-off-by: Marek Vasut 
Reviewed-by: Heinrich Schuchardt

efi_loader: add missing check in FMP.GetImageInfo()

2025-07-26T05:37:03+00:00

The UEFI 2.11 specification, chapter 23.1.3 requires
EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo() to return
EFI_INVALID_PARAMETER if *ImageInfoSize is not too small
and ImageInfo is NULL.

Fixes: f27c20148511 ("efi_loader: add firmware management protocol for FIT image")
Reviewed-by: Ilias Apalodimas 
Signed-off-by: Heinrich Schuchardt

global: Avoid indirect inclusion of from

2025-05-29T14:29:16+00:00

The include file  does not need anything from .
Furthermore, include/env.h itself includes other headers which can lead
to longer indirect inclusion paths. To prepare to remove  from
 fix all of the places which had relied on this indirect
inclusion to instead include  directly.

Reviewed-by: Mattijs Korpershoek  # android, bcb
Reviewed-by: Jerome Forissier  # spawn
Signed-off-by: Tom Rini

board: remove capsule update support in set_dfu_alt_info()

2025-04-11T11:20:37+00:00

Now that capsule update sets the dfu_alt_info environment variable
explicitly, there is no need to support it in the set_dfu_alt_info()
function. Decouple SET_DFU_ALT_INFO from EFI_CAPSULE_FIRMWARE_FIT and
EFI_CAPSULE_FIRMWARE_RAW. For many boards, this was the only use of
set_dfu_alt_info() so remove the function entirely.

Fixes: a9e6f01a941f ("efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled")

Signed-off-by: Jonathan Humphreys 
Signed-off-by: Michal Simek 
Reviewed-by: Mattijs Korpershoek 
Reviewed-by: Neil Armstrong  # for board/libre-computer/*
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Wadim Egorov  # for

efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-04-11T11:20:37+00:00

The current implementation of EFI capsule update uses set_dfu_alt_info() to
set the dfu_alt_info environment variable with the settings it requires.
However, set_dfu_alt_info() is doing this for all DFU operations, even
those unrelated to capsule update.

Thus other uses of DFU, such as DFU boot which sets its own value for the
dfu_alt_info environment variable, will have that setting overwritten with
the capsule update setting. Similarly, any user defined value for the
dfu_alt_info environment variable would get overwritten when any DFU
operation was performed, including simply performing a "dfu 0 list"
command.

The solution is stop using the set_dfu_alt_info() mechanism to set the
dfu_alt_info environment variable and instead explicitly set it to the
capsule update's setting just before performing the capsule update's DFU
operation, and then restore the environment variable back to its original
value.

This patch implements the explicit setting and restoring of the
dfu_alt_info environment variable as part of the EFI capsule update
operation.

The fix is fully implemented in a subsequent patch that removes the capsule
update dfu_alt_info support in set_dfu_alt_info().

Signed-off-by: Jonathan Humphreys 
Reviewed-by: Mattijs Korpershoek 
Reviewed-by: Ilias Apalodimas

efi_loader: use LOGC_EFI consistently

2025-01-26T10:06:56+00:00

The log category should be LOGC_EFI all over the EFI sub-system.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: Check for a valid fw_name before auto generating GUIDs

2024-12-05T07:01:33+00:00

The gen_v5_guid() is a void and does no error checking with pointers
being available etc. Instead it expects all things to be in place to
generate GUIDs. If a board capsule definition is buggy and does not
define the firmware names when enabling capsule updates, the board will
crash trying to bring up the EFI subsystem.

Check for a valid firmware name before generating GUIDs.

Reviewed-by: Heinrich Schuchardt 
Signed-off-by: Ilias Apalodimas

efi: add a helper to generate dynamic UUIDs

2024-09-12T15:35:37+00:00

Introduce a new helper efi_capsule_update_info_gen_ids() which populates
the capsule update fw images image_type_id field. This allows for
determinstic UUIDs to be used that can scale to a large number of
different boards and board variants without the need to maintain a big
list.

We call this from efi_fill_image_desc_array() to populate the UUIDs
lazily on-demand.

Reviewed-by: Ilias Apalodimas 
Signed-off-by: Caleb Connolly

efi_loader: check efi_get_variable_int return value

2024-01-29T10:31:44+00:00

efi_get_variable_int() may fail, the buffer should be
cleared before using it.

Signed-off-by: Masahisa Kojima 
Addresses-Coverity-ID: 478333 ("Error handling issues")

efi_loader: support fmp versioning for multi bank update

2024-01-13T17:17:47+00:00

This commit stores the firmware version into the array
of fmp_state structure to support the fmp versioning
for multi bank update. The index of the array is identified
by the bank index.

This modification keeps the backward compatibility with
the existing versioning feature.

Signed-off-by: Masahisa Kojima 
Reviewed-by: Ilias Apalodimas