u-boot.git/lib/efi_loader/efi_image_loader.c, branch v2025.01

lib: Remove duplicate newlines

2024-07-15T18:12:18+00:00

Drop all duplicate newlines. No functional change.

Signed-off-by: Marek Vasut

efi_loader: avoid duplicate weak invalidate_icache_all()

2024-06-19T19:10:23+00:00

If multiple weak implementations of a weak function exist, it is unclear
which one the linker should chose. cmd/cache.c already defines a weak
invalidate_icache_all().

We don't need a call to invalidate_icache_all() on x86.
ARM, RISC-V, and Sandbox provide an implementation.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: Remove

2023-12-21T13:54:37+00:00

We largely do not need  in these files, so drop it. The only
exception here is that efi_freestanding.c needs  and had
been getting that via .

Reviewed-by: Simon Glass 
Signed-off-by: Tom Rini

efi_loader: Fix memory corruption on 32bit systems

2023-08-03T07:21:02+00:00

It's pretty unlikely that anyone is going to be using EFI authentication
on a 32bit system.  However, if you did, the efi_prepare_aligned_image()
function would write 8 bytes of data to the &efi_size variable and it
can only hold 4 bytes so that corrupts memory.

Fixes: 163a0d7e2cbd ("efi_loader: add PE/COFF image measurement")
Signed-off-by: Dan Carpenter 
Reviewed-by: Heinrich Schuchardt

Correct SPL use of EFI_TCG2_PROTOCOL

2023-02-09T21:32:26+00:00

This converts 1 usage of this option to the non-SPL form, since there is
no SPL_EFI_TCG2_PROTOCOL defined in Kconfig

Signed-off-by: Simon Glass

efi_loader: image_loader: add a missing digest verification for signed PE image

2022-07-05T12:37:16+00:00

At the last step of PE image authentication, an image's hash value must be
compared with a message digest stored as the content (of SpcPeImageData type)
of pkcs7's contentInfo.

Fixes: commit 4540dabdcaca ("efi_loader: image_loader: support image authentication")
Signed-off-by: AKASHI Takahiro

efi_loader: image_loader: replace EFI_PRINT with log macros

2022-07-05T12:37:16+00:00

Now We are migrating from EFI_PRINT() to log macro's.

Signed-off-by: AKASHI Takahiro

efi_loader: copy GUID in InstallProtocolInterface()

2022-03-12T11:27:07+00:00

InstallProtocolInterface() is called with a pointer to the protocol GUID.
There is not guarantee that the memory used by the caller for the protocol
GUID stays allocated. To play it safe the GUID should be copied to U-Boot's
internal structures.

Reported-by: Joerie de Gram 
Signed-off-by: Heinrich Schuchardt

efi_loader: fix dual signed image certification

2022-02-11T19:07:55+00:00

The EFI spec allows for images to carry multiple signatures. Currently
we don't adhere to the verification process for such images.

The spec says:
"Multiple signatures are allowed to exist in the binary's certificate
table (as per PE/COFF Section "Attribute Certificate Table"). Only one
hash or signature is required to be present in db in order to pass
validation, so long as neither the SHA-256 hash of the binary nor any
present signature is reflected in dbx."

With our current implementation signing the image with two certificates
and inserting both of them in db and one of them dbx doesn't always reject
the image.  The rejection depends on the order that the image was signed
and the order the certificates are read (and checked) in db.

While at it move the sha256 hash verification outside the signature
checking loop, since it only needs to run once per image and get simplify
the logic for authenticating an unsigned imahe using sha256 hashes.

Signed-off-by: Ilias Apalodimas

efi: Use 16-bit unicode strings

2022-02-03T17:16:01+00:00

At present we use wide characters for unicode but this is not necessary.
Change the code to use the 'u' literal instead. This helps to fix build
warnings for sandbox on rpi.

Signed-off-by: Simon Glass 
Suggested-by: Heinrich Schuchardt 
Reviewed-by: Heinrich Schuchardt