u-boot.git/lib/efi_loader/efi_memory.c, branch master

efi_loader: efi_realloc() must check efi_alloc() return value

2025-07-26T05:37:03+00:00

Avoid copying to NULL if out of memory.

Fixes: 3c08df58cc43 ("lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory")
Addresses-Coverity-ID: 569499: Null pointer dereferences (NULL_RETURNS)
Reviewed-by: Ilias Apalodimas 
Signed-off-by: Heinrich Schuchardt

lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-07-03T09:25:56+00:00

Add efi_realloc() for realloc memory that previously alloc by efi_alloc().
Note that if realloced memory is explicitly allocated as BootServicesData.

Cc: Heinrich Schuchardt 
Cc: Ilias Apalodimas 
Cc: Peter Robinson 
Cc: Simon Glass 
Signed-off-by: Ying-Chun Liu (PaulLiu) 
Reviewed-by: Ilias Apalodimas 
Signed-off-by: Ilias Apalodimas

lmb: use a single function to free up memory

2025-06-25T15:50:37+00:00

There is no need to have two separate API's for freeing up memory. Use
a single API lmb_free() to achieve this.

Signed-off-by: Sughosh Ganu 
Reviewed-by: Ilias Apalodimas

lmb: replace the lmb_alloc() and lmb_alloc_base() API's

2025-06-25T15:50:37+00:00

There currently are two API's for requesting memory from the LMB
module, lmb_alloc() and lmb_alloc_base(). The function which does the
actual allocation is the same. Use the earlier introduced API
lmb_alloc_mem() for both types of allocation requests.

Signed-off-by: Sughosh Ganu 
Acked-by: Ilias Apalodimas

lmb: replace lmb_reserve() and lmb_alloc_addr() API's

2025-06-25T15:50:37+00:00

There currently are multiple allocation API's in the LMB module. There
are a couple of API's for allocating memory(lmb_alloc() and
lmb_alloc_base()), and then there are two for requesting a reservation
for a particular memory region (lmb_reserve() and
lmb_alloc_addr()). Introduce a single API lmb_alloc_mem() which will
cater to all types of allocation requests and replace lmb_reserve()
and lmb_alloc_addr() with the new API.

Moreover, the lmb_reserve() API is pretty similar to the
lmb_alloc_addr() API, with the one difference being that the
lmb_reserve() API allows for reserving any address passed to it --
the address need not be part of the LMB memory map. The
lmb_alloc_addr() does check that the address being requested is
actually part of the LMB memory map.

There is no need to support reserving memory regions which are outside
the LMB memory map. Remove the lmb_reserve() API functionality and use
the functionality provided by lmb_alloc_addr() instead. The
lmb_alloc_addr() will check if the requested address is part of the
LMB memory map and return an error if not.

Signed-off-by: Sughosh Ganu 
Acked-by: Ilias Apalodimas

efi_loader: allow for removal of memory from the EFI map

2025-03-26T11:28:08+00:00

With upcoming changes supporting pmem nodes, we need to remove the
pmem area from the EFI memory map. Rename efi_add_memory_map_pg() to
efi_update_memory_map(), and allow removing memory from the EFI memory
map.

Signed-off-by: Sughosh Ganu 
Signed-off-by: Ilias Apalodimas

lmb: change the return code on lmb_alloc_addr()

2025-03-24T17:12:33+00:00

Ben reports a failure to boot the kernel on hardware that starts its
physical memory from 0x0.
The reason is that lmb_alloc_addr(), which is supposed to reserve a
specific address, takes the address as the first argument, but then also
returns the address for success or failure and treats 0 as a failure.

Since we already know the address change the prototype to return an int.

Reported-by: Ben Schneider 
Signed-off-by: Ilias Apalodimas 
Tested-by: Ben Schneider 
Reviewed-by: Sughosh Ganu

efi_loader: make efi_add_memory_map_pg() static

2025-02-20T10:09:33+00:00

The function is only used in the efi_memory.c module.

Reviewed-by: Ilias Apalodimas 
Signed-off-by: Heinrich Schuchardt

lmb: move lmb_map_update_notify() to EFI

2025-02-20T10:09:33+00:00

When building with qemu_arm64_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y
and CONFIG_EFI_LOADER=n an error undefined reference to efi_add_memory_map_pg
occurs.

Move the EFI dependent part of lmb_map_update_notify() to the EFI
sub-system.

Reported-by: Liya Huang <1425075683@qq.com>
Acked-by: Liya Huang <1425075683@qq.com>
Signed-off-by: Heinrich Schuchardt

lmb: Remove lmb_alloc_base_flags()

2024-12-30T19:21:55+00:00

lmb_alloc_base() is just calling lmb_alloc_base_flags() with LMB_NONE.
There's not much we gain from this abstraction, so let's remove the
former add the flags argument to lmb_alloc_base() and make the code
a bit easier to follow.

Reviewed-by: Sam Protsenko 
Tested-by: Sam Protsenko 
Signed-off-by: Ilias Apalodimas