u-boot.git/lib/efi_loader/efi_memory.c, branch v2017.11

efi_loader: make pool allocations cacheline aligned

2017-09-20T08:48:09+00:00

This avoids printf() spam about file reads (such as loading an image)
into unaligned buffers (and the associated memcpy()).  And generally
seems like a good idea.

Signed-off-by: Rob Clark 
[agraf: use __aligned]
Signed-off-by: Alexander Graf

efi_loader: fix bug in efi_get_memory_map

2017-07-26T20:09:49+00:00

When booting shim -> fallback -> shim -> grub -> linux the memory map is
a bit larger than the size linux passes in on the first call.  But in
the EFI_BUFFER_TOO_SMALL case we were not passing back the updated size
to linux so it would loop forever.

Signed-off-by: Rob Clark 
Signed-off-by: Alexander Graf

efi_memory: return MapKey

2017-07-24T12:46:13+00:00

efi_get_memory_map should set a defined value for map_key.

We later can introduce the test against this value in
efi_exit_boot_services as required by the UEFI standard.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_memory: do parameter checks first

2017-07-24T12:46:01+00:00

The parameter checks should be done first.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_memory: avoid NULL dereference in efi_free_pool

2017-07-19T12:14:41+00:00

If efi_free_pool is called with argument NULL an illegal memory
access occurs.

So let's check the parameter on entry.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi: Add a hook to allow adding memory mapping

2017-03-14T15:44:03+00:00

Instead of adding all memory banks, add a hook so individual SoC/board
can has its own implementation.

Signed-off-by: York Sun 
CC: Alexander Graf 
Reviewed-by: Alexander Graf

efi_loader: Do not leak memory when unlinking a mapping

2016-10-18T07:08:08+00:00

As soon as a mapping is unlinked from the list, there are no further
references to it, so it should be freed. If it not unlinked,
update the start address and length.

Signed-off-by: Stefan Brüns 
Reviewed-by: Alexander Graf 
Signed-off-by: Alexander Graf

efi_loader: Keep memory mapping sorted when splitting an entry

2016-10-18T07:08:07+00:00

The code assumes sorted mappings in descending address order. When
splitting a mapping, insert the new part next to the current mapping.

Signed-off-by: Stefan Brüns 
Reviewed-by: Alexander Graf 
Signed-off-by: Alexander Graf

efi_loader: Readd freed pages to memory pool

2016-10-18T07:08:07+00:00

Currently each allocation creates a new mapping. Readding the mapping
as free memory (EFI_CONVENTIONAL_MEMORY) potentially allows to hand out
an existing mapping, thus limiting the number of mapping descriptors in
the memory map.

Mitigates a problem with current (4.8rc7) linux kernels when doing an
efi_get_memory map, resulting in an infinite loop. Space for the memory
map is reserved with allocate_pool (implicitly creating a new mapping) and
filled. If there is insufficient slack space (8 entries) in the map, the
space is freed and a new round is started, with space for one more entry.
As each round increases requirement and allocation by exactly one, there
is never enough slack space. (At least 32 entries are allocated, so as
long as there are less than 24 entries, there is enough slack).
Earlier kernels reserved no slack, and did less allocations, so this
problem was not visible.

Signed-off-by: Stefan Brüns 
Reviewed-by: Alexander Graf 
Signed-off-by: Alexander Graf

efi_loader: Track size of pool allocations to allow freeing

2016-10-18T07:08:07+00:00

We need a functional free_pool implementation, as otherwise each
allocate_pool causes growth of the memory descriptor table.

Different to free_pages, free_pool does not provide the size for the
to be freed allocation, thus we have to track the size ourselves.

As the only EFI requirement for pool allocation is an alignment of
8 bytes, we can keep allocating a range using the page allocator,
reserve the first 8 bytes for our bookkeeping and hand out the
remainder to the caller. This saves us from having to use any
independent data structures for tracking.

To simplify the conversion between pool allocations and the corresponding
page allocation, we create an auxiliary struct efi_pool_allocation.

Given the allocation size free_pool size can handoff freeing the page
range, which was indirectly allocated by a call to allocate_pool,
to free_pages.

Signed-off-by: Stefan Brüns 
Reviewed-by: Alexander Graf 
Signed-off-by: Alexander Graf