u-boot.git/lib/efi_loader/efi_memory.c, branch v2018.09

efi: Fix truncation of constant value

2018-08-20T22:03:01+00:00

Starting with commit 867a6ac86dd8 ("efi: Add start-up library code"),
sparse constantly complains about truncated constant value in efi.h:

include/efi.h:176:35: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

This can get quite noisy, preventing real issues to be noticed:

$ make defconfig
*** Default configuration is based on 'sandbox_defconfig'
$ make C=2 -j12 2>&1 | grep truncates | wc -l
441

After the patch is applied:
$ make C=2 -j12 2>&1 | grep truncates | wc -l
0
$ sparse --version
v0.5.2

Following the suggestion of Heinrich Schuchardt, instead of only
fixing the root-cause, I replaced the whole enum of _SHIFT values
by ULL defines. This matches both the UEFI 2.7 spec and the Linux
kernel implementation.

Some ELF size comparison before and after the patch (gcc 7.3.0):

efi-x86_payload64_defconfig:
text    data    bss     dec       hex   filename
407174  29432   278676  715282    aea12 u-boot.old
407152  29464   278676  715292    aea1c u-boot.new
-22     +32     0       +10

efi-x86_payload32_defconfig:
text    data    bss     dec       hex   filename
447075  30308   280076  757459    b8ed3 u-boot.old
447053  30340   280076  757469    b8edd u-boot.new
-22     +32     0       +10

Fixes: 867a6ac86dd8 ("efi: Add start-up library code")
Suggested-by: Heinrich Schuchardt 
Signed-off-by: Eugeniu Rosca 
Reviewed-by: Heinrich Schuchardt 
Reviewed-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: avoid NULL dereference in efi_get_memory_map()

2018-08-20T12:41:09+00:00

We should only dereference parameter memory_map_size after checking that
it is valid.

Fixes: 8e835554b36b ("efi_loader: check parameters of GetMemoryMap")
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

Revert "efi_loader: efi_allocate_pages is too restrictive"

2018-08-20T09:39:19+00:00

This reverts commit aa909462d01866354f4cd4534db5f571c2cf1fbb. This change
caused "dhcp filename" to crash the system on p2371-2180 (Jetson TX1), for
example when running test/py.

Reverting this change isn't optimal, but at least restores TX1 to a working
state. In the future, we should:

a) Fix whatever problem causes the crash with this patch applied. This
needs further discussion, so isn't something we can immediately do.

b) Undo the revert; re-apply the original patch to efi_allocate_pages.

Signed-off-by: Stephen Warren 
Reviewed-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: check map_key in ExitBootServices

2018-07-25T12:59:44+00:00

The UEFI spec requires that the memory map key is checked in
ExitBootServices().

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: check parameters of GetMemoryMap

2018-07-25T12:59:44+00:00

Check the parameters of boottime service GetMemoryMap().
Return EFI_INVALID_PARAMETER where required by the UEFI spec.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: check parameters in memory allocation

2018-07-25T12:59:44+00:00

If no pointer is provided throw an error.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: Expose U-Boot addresses in memory map for sandbox

2018-07-25T12:57:44+00:00

We currently expose host addresses in the EFI memory map. That can be
bad if we ever want to use sandbox to boot strap a real kernel, because
then the kernel would fetch its memory table from our host virtual address
map. But to make that use case work, we would need to have full control
over the address space the EFI application sees.

So let's expose only U-Boot addresses to the guest until we get to the
point of allocation. EFI's allocation functions are fun - they can take
U-Boot addresses as input values for hints and return host addresses as
allocation results through the same uint64_t * parameter. So we need to
be extra careful on what to pass in when.

With this patch I am successfully able to run the efi selftest suite as
well as grub.efi on aarch64.

Signed-off-by: Alexander Graf

efi: sandbox: Adjust memory usage for sandbox

2018-07-25T12:57:44+00:00

With sandbox the U-Boot code is not mapped into the sandbox memory range
so does not need to be excluded when allocating EFI memory. Update the EFI
memory init code to take account of that.

Signed-off-by: Simon Glass 
[agraf: Remove map_sysmem() call and header reference]
Signed-off-by: Alexander Graf

efi_loader: efi_allocate_pages is too restrictive

2018-07-25T12:57:43+00:00

When running on the sandbox the stack is not necessarily at a higher memory
address than the highest free memory.

There is no reason why the checking of the highest memory address should be
more restrictive for EFI_ALLOCATE_ANY_PAGES than for
EFI_ALLOCATE_MAX_ADDRESS.

Signed-off-by: Heinrich Schuchardt 
[agraf: use -1ULL instead]
Signed-off-by: Alexander Graf

efi_loader: efi_mem_carve_out should return s64

2018-06-03T13:27:21+00:00

efi_mem_carve_out() is used to remove memory pages from a mapping.
As the number of pages to be removed is a 64bit type the return type
should be 64bit too.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf