u-boot.git/lib/efi_loader/efi_memory.c, branch v2019.10

efi_loader: Extract adding a conventional memory in separate routine

2019-09-05T21:18:51+00:00

Adding a conventional memory region to the memory map may require ram_top
limitation and it can be also commonly used. Extract adding a conventional
memory to the memory map in a separate routine for generic use.

Signed-off-by: Aiden Park 
Tested-by: Heinrich Schuchardt 
Reviewed-by: Heinrich Schuchardt

efi_loader: fix comment for struct efi_pool_allocation

2019-07-16T22:17:19+00:00

Change comment for struct efi_pool_allocation to match Sphinx style.
Describe all structure fields.

Signed-off-by: Heinrich Schuchardt

efi_loader: Change return type of efi_add_memory_map()

2019-07-16T22:17:17+00:00

We currently have some inconsistent use of efi_add_memory_map()
throughout the code. In particular the return value of efi_add_memory_map()
is not interpreted the same way by various users in the codebase.

This patch does the following:

- Changes efi_add_memory_map() to return efi_status_t.
- Adds a method description to efi_add_memory_map().
- Changes efi_add_memory_map() to return EFI_SUCCESS
- Returns non-zero for error in efi_add_memory_map()
- Updates efi_allocate_pages() to new efi_add_memory_map()
- Updates efi_free_pages() to new efi_add_memory_map()
- Updates efi_carve_out_dt_rsv() to new efi_add_memory_map()
- Updates efi_add_runtime_mmio()  to new efi_add_memory_map()

Fixes: 5d00995c361c ("efi_loader: Implement memory allocation and map")
Fixes: 74c16acce30b ("efi_loader: Don't allocate from memory holes")
Suggested-by: Heinrich Schuchardt 
Cc: Alexander Graf 
Signed-off-by: Bryan O'Donoghue 
Reviewed-by: Heinrich Schuchardt

efi_loader: AllocatePages() must accept addr == 0

2019-06-14T17:18:40+00:00

It must be possible to allocate memory at address 0 with AllocatePages().

Move a NULL pointer check.

Signed-off-by: Heinrich Schuchardt

efi_loader: event signaling in ExitBootServices

2019-06-10T21:06:19+00:00

ExitBootServices() has to stop timer related activity before calling the
events of the EFI_EVENT_GROUP_EXIT_BOOT_SERVICES event group. But our
current implementation was stopping all other events.

All events have to observe the task priority level.

Signed-off-by: Heinrich Schuchardt

efi_loader: notify memory map changes

2019-06-04T20:09:38+00:00

When the memory map is changed signal events of the
EFI_EVENT_GROUP_MEMORY_MAP_CHANGE event group.

Signed-off-by: Heinrich Schuchardt

efi_loader: simplify efi_allocate_pages()

2019-05-12T18:54:22+00:00

Replace unnecessary control structures by using return statements.

Signed-off-by: Heinrich Schuchardt

efi_loader: AllocateAdress error handling

2019-05-12T18:54:22+00:00

If AllocatePages() is called with AllocateAddress, the UEFI spec requires
to return EFI_NOT_FOUND in case the memory page does not exist.

The UEFI SCT II 2017 spec additionally requires to return EFI_NOT_FOUND if
the page is already allocated.

Check that *Memory refers to an unallocated page.

UEFI SCT II (2017): AllocatePages(), 5.1.2.1.9 - 5.1.2.1.10

Signed-off-by: Heinrich Schuchardt

efi_loader: out of resources in AllocatePages()

2019-05-12T18:54:22+00:00

According to the UEFI AllocatePages() has to return EFI_OUT_OF_RESOURCES if
sufficient memory is not available.

Change the return value.

UEFI SCT II (2017): 3.2.1 AllocatePages(), 5.1.2.1.8

Signed-off-by: Heinrich Schuchardt

efi_loader: check memory address before freeing

2019-05-12T18:54:22+00:00

When we call FreePages() we essentially add memory to our memory map. We
shouldn't do this for memory that does not exit.

Check if the memory that is to be freed via FreePages() or FreePool() is in
our memory map and is not EFI_CONVENTIONAL_MEMORY.

This check is mandated by the UEFI specification.

Cf. UEFI SCT  II (2017), 3.2.2 FreePages(), 5.1.2.1 - 5.1.2.2

Signed-off-by: Heinrich Schuchardt