u-boot.git/lib/efi_loader/efi_memory.c, branch v2024.10

efi_memory: get the efi_mem_list node directly

2024-07-31T07:54:49+00:00

Use the list_for_each_entry() API to get the efi_mem_list node
directly, instead of making an additional call to list_entry().

Signed-off-by: Sughosh Ganu 
Reviewed-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_memory: avoid possible null pointer dereference

2024-07-31T07:54:42+00:00

Populate the previous memory descriptor node pointer only after it's
parent struct has been initialised. The compiler fixes this logic to
do the right thing, but it is better to have correct code in place.

Signed-off-by: Sughosh Ganu 
Reviewed-by: Simon Glass 
Reviewed-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_memory: use list_count_nodes() to count list entries

2024-07-31T07:54:31+00:00

Use the API function list_count_nodes() to count the number of EFI
memory map entries.

Signed-off-by: Sughosh Ganu 
Reviewed-by: Simon Glass 
Reviewed-by: Heinrich Schuchardt

efi_loader: eliminate duplicate runtime section definitions

2024-04-13T09:03:12+00:00

The following symbols are defined in two includes:

* __efi_runtime_start[]
* __efi_runtime_stop[]
* __efi_runtime_rel_start[]
* __efi_runtime_rel_stop[]

Eliminate the definitions in efi_loader.h.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: access __efi_runtime_start/stop without &

2024-04-08T11:05:42+00:00

A symbol defined in a linker script (e.g. __efi_runtime_start = .;) is
only a symbol, not a variable and should not be dereferenced.
The common practice is either define it as
extern uint32_t __efi_runtime_start or
extern char __efi_runtime_start[] and access it as
&__efi_runtime_start or __efi_runtime_start respectively.

So let's access it properly since we define it as an array

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_loader: Remove

2023-12-21T13:54:37+00:00

We largely do not need  in these files, so drop it. The only
exception here is that efi_freestanding.c needs  and had
been getting that via .

Reviewed-by: Simon Glass 
Signed-off-by: Tom Rini

efi_loader: fix efi_add_known_memory()

2023-08-15T16:21:17+00:00

In efi_add_known_memory() we currently call board_get_usable_ram_top() with
an incorrect value 0 of parameter total_size. This leads to an incorrect
value for ram_top depending on the code in board_get_usable_ram_top().

Use the value of gd->ram_top instead which is set before relocation by
calling board_get_usable_ram_top().

Fixes: 7b78d6438a2b ("efi_loader: Reserve unaccessible memory")
Signed-off-by: Heinrich Schuchardt

efi_loader: memory leak efi_add_memory_map_pg

2023-08-03T07:21:02+00:00

Don't leak newlist if we error out.

Fixes: 74c16acce30b ("efi_loader: Don't allocate from memory holes")
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: out of memory in efi_mem_carve_out

2023-08-03T07:21:02+00:00

Handle out of memory situation in efi_mem_carve_out().

Fixes: 5d00995c361c ("efi_loader: Implement memory allocation and map")
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: overflow in efi_allocate_pages

2023-08-03T07:21:02+00:00

On 32bit systems (pages << EFI_PAGE_SHIFT) may lead to an overflow which
does not occur in 64bit arithmetics.

An overflow of (pages << EFI_PAGE_SHIFT) on 64bit systems should be treated
as an error.

Signed-off-by: Heinrich Schuchardt