u-boot.git/lib/efi_loader/efi_variable.c, branch v2019.04

efi_loader: missing return in efi_get_next_variable_name()

2019-03-20T17:16:53+00:00

Add a missing return statement in efi_get_next_variable_name().

Reported-by: Coverity (CID 185834)
Signed-off-by: Heinrich Schuchardt

efi_loader: fix GetNextVariableName

2019-02-13T08:40:06+00:00

Our current implementation of GetNextVariableName() first collects all EFI
variables. If none is found at all hexport_r() returns a zero length string
terminated by \0 and the value 1 as number of bytes in the returned buffer.

In this case GetNextVariableName() has to return EFI_NOT_FOUND.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: implement GetNextVariableName()

2019-02-13T08:40:06+00:00

The current GetNextVariableName() is a placeholder.
With this patch, it works well as expected.

Signed-off-by: AKASHI Takahiro 
rebased on efi-next
Reviewed-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: comments for variable services

2019-02-13T08:40:06+00:00

Comment the functions implementing the runtime variable services.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: remove duplicate function mem2hex()

2019-02-13T08:40:06+00:00

Replace duplicate function mem2hex() by inline function bin2hex().

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: eliminate duplicate function hex2mem()

2019-02-13T08:40:06+00:00

Use existing inline function hex2bin() instead of defining a new one.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: efi_set_variable use const void *

2019-02-13T08:40:05+00:00

The SetVariable() runtime service does not change the data passed to it.
So mark the parameter as constant.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: use const efi_guid_t * for variable services

2019-02-13T08:40:05+00:00

The runtime variable services never change GUIDs. So we should declare
the GUID parameters as constant.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: memory leak in efi_set_variable()

2018-10-16T14:40:11+00:00

Do not leak native_name if out of memory.

This addresses CoverityScan CID 184095.

Reported-by: Tom Rini 
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: avoid out of bound access in efi_get_variable()

2018-09-23T19:55:31+00:00

In efi_get_variable() a string is longer than the allocated space which
results in overwriting the linked list of malloc().

The prefixes used for variables are 41 characters long, e.g.
efi_67029eb5-0af2-f6b1-da53-fcb566dd1ce6_

Change PREFIX_LEN to 41.

Fixes: faff21556748 ("efi_loader: remove limit on variable length")
Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf