u-boot.git/lib/efi_loader/efi_variable.c, branch v2020.07-rc2

efi_loader: variable: check a return value of uuid__str_to_bin()

2020-05-09T07:30:27+00:00

The only error case is that a given UUID is in wrong format.
So just return EFI_INVALID_PARAMETER here.

Reported-by: Coverity (CID 300333)
Signed-off-by: AKASHI Takahiro 
Reviewed-by: Heinrich Schuchardt

efi_loader: efi_variable_parse_signature() returns NULL on error

2020-05-07T16:23:16+00:00

efi_variable_parse_signature() returns NULL on error, so IS_ERR()
is an incorrect check.  The goto err leads to pkcs7_free_message(),
which works fine on a NULL ptr.

Signed-off-by: Patrick Wildt 
Reviewed-by: AKASHI Takahiro

efi_loader: do not unnecessarily use EFI_CALL()

2020-05-07T16:23:16+00:00

There is no need to call efi_get_variable() instead of
efi_get_variable_common(). So let's use the internal function.

Move forward declarations to the top of the file.

Signed-off-by: Heinrich Schuchardt

efi_loader: error handling in efi_set_variable_common().

2020-05-07T16:23:16+00:00

Fix unreachable code. Free memory on error.

Signed-off-by: Heinrich Schuchardt

efi_loader: correct comments for efi_status_t

2020-05-04T10:26:11+00:00

EFI_STATUS is unsigned (UINTN). Hence it cannot be negative.
Correct comments for 'Return:'.

Signed-off-by: Heinrich Schuchardt

efi_loader: eliminate efi_set_(non)volatile_variable

2020-05-04T10:26:11+00:00

Eliminate superfluous functions efi_set_volatile_variable() and
efi_set_nonvolatile_variable().

Signed-off-by: Heinrich Schuchardt

efi_loader: eliminate efi_get_(non)volatile_variable

2020-05-04T10:26:11+00:00

Eliminate superfluous functions efi_get_volatile_variable() and
efi_get_nonvolatile_variable().

Signed-off-by: Heinrich Schuchardt

efi_loader: factor out the common code from efi_transfer_secure_state()

2020-05-04T10:26:11+00:00

efi_set_secure_stat() provides the common code for each stat transition
caused by efi_transfer_secure_state().

Suggested-by: Heinrich Schuchardt 
Signed-off-by: AKASHI Takahiro 
Correct description of return value.
Reviewed-by: Heinrich Schuchardt

lib/crypto, efi_loader: move some headers to include/crypto

2020-05-04T10:26:11+00:00

Pkcs7_parse.h and x509_parser.h are used in UEFI subsystem, in particular,
secure boot. So move them to include/crypto to avoid relative paths.

Suggested-by: Heinrich Schuchardt 
Signed-off-by: AKASHI Takahiro 
Don't include include x509_parser.h twice.
Reviewed-by: Heinrich Schuchardt

efi_loader: variable: add VendorKeys variable

2020-04-16T06:12:46+00:00

The following variable is exported as UEFI specification defines:
VendorKeys: whether the system is configured to use only vendor-provided
	    keys or not
The value will have to be modified if a platform has its own way of
initializing signature database, in particular, PK.

Signed-off-by: AKASHI Takahiro