u-boot.git/lib/efi_loader, branch v2019.04

efi_loader: TODO for the EFI file protocol

2019-03-27T20:52:11+00:00

We currently only support EFI_FILE_PROTOCOL_REVISION while
UEFI specs 2.4 - 2.7 prescribe EFI_FILE_PROTOCOL_REVISION2.
Add a todo.

Add missing constants for the EFI file protocol revision.

Signed-off-by: Heinrich Schuchardt

efi_loader: superfluous conversion in efi_file_open()

2019-03-20T17:16:53+00:00

printf("%ls", ..) expects u16 * as argument to print. There is not need for
a conversion to wchar_t *.

Signed-off-by: Heinrich Schuchardt

efi_loader: remove superfluous check in efi_setup_loaded_image()

2019-03-20T17:16:53+00:00

It does not make any sense to check if a pointer is NULL if we have
dereferenced it before.

Reported-by: Coverity (CID 185827)
Signed-off-by: Heinrich Schuchardt

efi_loader: missing return in efi_get_next_variable_name()

2019-03-20T17:16:53+00:00

Add a missing return statement in efi_get_next_variable_name().

Reported-by: Coverity (CID 185834)
Signed-off-by: Heinrich Schuchardt

efi_loader: endless loop in add_strings_package()

2019-03-20T17:16:53+00:00

Avoid an endless loop in add_strings_package().

Suggested-by: Takahiro Akashi 
Reported-by: Coverity (CID 185833)
Signed-off-by: Heinrich Schuchardt

efi_loader: correct parameter size in efi_allocate_pool

2019-03-20T17:16:53+00:00

efi_allocate_pages() expects a (uint64_t *) pointer to pass the address of
the assigned memory. If we pass the address of a pointer here, an illegal
memory access occurs on 32bit systems.

Fixes: 282a06cbcae8 ("efi_loader: Expose U-Boot addresses in memory map
for sandbox")
Signed-off-by: Heinrich Schuchardt

efi_loader: Fix serial console size detection

2019-03-10T18:56:59+00:00

Function term_read_reply tries to read from the serial console until
the end_char was read. This can hang forever if we are, for some reason,
not able to read the full response (e.g. serial buffer too small,
frame error). This patch moves the timeout detection into
term_read_reply() to assure we will make progress.

Fixes: 6bb591f704 ("efi_loader: query serial console size reliably")
Signed-off-by: Matthias Brugger 

Throw missing error when an incomplete reply for the cursor position is
received.

Change type of argument of term_get_char() *s32. This renders the function
reusable in efi_cin_read_key().

Reviewed-by: Heinrich Schuchardt

efi_loader: HII protocols: debug messages

2019-03-02T22:34:26+00:00

When package types are not supported by our implementation of the HII
database protocol supported error messages are displayed.

Essentially the output is only needed for debugging. By using EFI_PRINT()
the messages are only written for in debug mode and with correct
indentation.

Signed-off-by: Heinrich Schuchardt

efi_loader: HII protocols: fix new_package_list()

2019-03-02T22:34:26+00:00

In new_package_list() we call new_packagelist() to create a new package
list. Next we try to add the packages which fails for form packages. Due
to this error we call free_packagelist(). Now in free_packagelist()
list_del() is called for an uninitialized field hii->link. This leads to
changing random memory addresses.

To solve the problem move the initialization of hii->link to
new_packagelist().

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: AKASHI Takahiro

efi_loader: do not add \ in efi_fs_from_name()

2019-03-02T22:34:26+00:00

In the `efidebug boot add` command we do not want an unsolicited leading
backslash added to the file name.

There is no good reason to mark a loaded file with a backslash as absolute.
Anyway when reading files the file name will be interpreted as relative to
root directory of the device.

So let's get rid of this backslash.

Signed-off-by: Heinrich Schuchardt