u-boot.git/lib/efi_loader, branch v2020.07

efi_loader: fix incorrect use of EFI_EXIT()

2020-06-29T09:56:10+00:00

efi_get_variable_common() does not use EFI_ENTRY(). So we should not use
EFI_EXIT() either.

Fixes: 767f6eeb01d3 ("efi_loader: variable: support variable authentication")
Signed-off-by: Heinrich Schuchardt

efi_loader: size of secure boot variables

2020-06-24T14:50:15+00:00

The variables SetupMode, AuditMode, DeployedMode are explicitly defined as
UINT8 in the UEFI specification. The type of SecureBoot is UINT8 in EDK2.

Use variable name secure_boot instead of sec_boot for the value of the
UEFI variable SecureBoot.

Avoid abbreviations in function descriptions.

Signed-off-by: Heinrich Schuchardt

efi_loader: type of efi_secure_mode

2020-06-24T14:50:15+00:00

Variable efi_secure_mode is meant to hold a value of enum efi_secure_mode.
So it should not be defined as int but as enum efi_secure_mode.

Signed-off-by: Heinrich Schuchardt

efi_loader: printf code in efi_image_parse()

2020-06-14T19:07:20+00:00

For size_t we have to use %zu for printing not %lu.

Fixes: 4540dabdcaca ("efi_loader: image_loader: support image
authentication")
Signed-off-by: Heinrich Schuchardt

efi_loader: comments EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL

2020-06-05T02:04:41+00:00

Provide missing comments for the functions implementing the
EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.

Signed-off-by: Heinrich Schuchardt

efi_loader: signature: move efi_guid_cert_type_pkcs7 to efi_signature.c

2020-06-03T15:19:19+00:00

The global variable, efi_guid_cert_type_pkcs7, will also be used in
efi_image_loader.c in a succeeding patch so as to correctly handle
a signature type of authenticode in signed image.

Meanwhile, it is currently defined in efi_variable.c. Once some secure
storage solution for UEFI variables is introduced, efi_variable.c may
not always be compiled in.

So move the definition to efi_signature.c as a common place.

Signed-off-by: AKASHI Takahiro 
Reviewed-by: Heinrich Schuchardt

efi_loader: simplify PE consistency check

2020-06-03T15:19:18+00:00

Knowing that at least one section header follows the optional header we
only need to check for the length of the 64bit header which is longer than
the 32bit header.

Signed-off-by: Heinrich Schuchardt

efi_loader: function description cmp_pe_section()

2020-06-03T15:19:17+00:00

Rework the description of function cmp_pe_section().

Signed-off-by: Heinrich Schuchardt

efi_loader: function descriptions efi_image_loader.c

2020-06-03T15:19:17+00:00

We want to follow the Linux kernel style for function descriptions.

Add missing parentheses after function names.

Signed-off-by: Heinrich Schuchardt

efi_loader: allow compiling with clang

2020-06-03T15:19:17+00:00

On ARM systems gd is stored in register r9 or x18. When compiling with
clang gd is defined as a macro calling function gd_ptr(). So we can not
make assignments to gd.

In the UEFI sub-system we need to save gd when leaving to UEFI binaries and
have to restore gd when reentering U-Boot.

Define a new function set_gd() for setting gd and use it in the UEFI
sub-system.

Signed-off-by: Heinrich Schuchardt 
Tested-by: Tom Rini