u-boot.git/lib/efi_loader, branch v2021.07-rc2

efi_loader: capsule: return a correct error code at find_boot_device()

2021-04-24T04:53:40+00:00

In case of failure at efi_get_variable_int("BootOrder"), we should
skip examining boot option variables and return an appropriate error
code which is the one the function returned.

Fixes: CID 331153 Code maintainability issues  (UNUSED_VALUE)
Signed-off-by: AKASHI Takahiro 
Reviewed-by: Heinrich Schuchardt

efi: Fix ESRT refresh after Capsule update

2021-04-24T04:53:40+00:00

Indicated by Coverity Scan CID 331147

The ESRT was being refreshed in situations where the UpdateCapsule
procedure failed. In that scenario:

1) the ESRT refresh was superfluous.
2) a failed ESRT refresh return code overwrites the UpdateCapsule error
return code.

This commit ensures that the ESRT is only refreshed when the
UpdateCapsule performs successfully.

CC: Heinrich Schuchardt 
CC: Sughosh Ganu 
CC: AKASHI Takahiro 
CC: Tom Rini 
CC: Andre Przywara 
CC: nd@arm.com

Signed-off-by: Jose Marinho 
Reviewed-by: Heinrich Schuchardt

efi_loader: simplify tcg2_create_digest()

2021-04-24T04:53:40+00:00

Bumping the digest list count, for all supported algorithms,  can be
calculated outside of the individual switch statements.  So let's do that
for every loop iteration instead and simplify the code a bit.

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_loader: missing include in efi_string.c

2021-04-24T04:53:40+00:00

To avoid diverging function definitions we need to include efi_loader.h.

Fixes: fe179d7fb5c1 ("efi_loader: Add size checks to efi_create_indexed_name()")
Signed-off-by: Heinrich Schuchardt

efi_loader: fix possible buffer overflow

2021-04-17T18:01:32+00:00

Variable "final" will have SHA512 digest, but currently
the array size is not sufficient. Let's fix it.

Signed-off-by: Masahisa Kojima 
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_loader: memory leak in efi_capsule_scan_dir()

2021-04-17T18:01:32+00:00

If realloc() fails, we should free the old buffer.

Fixes: c74cd8bd08d1: ("efi_loader: capsule: add capsule_on_disk support")
Signed-off-by: Heinrich Schuchardt

efi_loader: esrt: Remove incorrect invocations of EFI_CALL macro

2021-04-17T18:01:31+00:00

Remove function invocations using the EFI_CALL macro for those
functions that do not have an EFI_ENTRY call in their definition. Such
functions can use u-boot api's which rely on u-boot global data(gd)
pointer. The Arm and RiscV architectures maintain a separate gd
pointer, one for u-boot, and a separate gd for the efi application.

Calling a function through the EFI_CALL macro changes the gd pointer
to that used for the efi application, with u-boot gd being
unavailable. Any function then trying to dereference u-boot's gd will
result in an abort.

Fix this issue by removing the EFI_CALL macro for all of such
functions which do not begin by an EFI_ENTRY function call.

Signed-off-by: Sughosh Ganu 
Reviewed-by: Heinrich Schuchardt

efi_loader: Change ptr arithmetics tcg eventlog buffer

2021-04-10T10:00:24+00:00

Although ptr arithmetics are allowed with extensions in gcc, they
are not allowed by the C spec. So switch to (void *)(uintptr_t) instead

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Alexandru Gagniuc

efi_loader: esrt: wrong type for LocateHandleBuffer()

2021-04-10T10:00:24+00:00

efi_locate_handle_buffer() expects no_handles to be of type efi_uintn_t *.

Signed-off-by: Heinrich Schuchardt

efi_loader: use correct printf codes

2021-04-10T10:00:24+00:00

For printing u32 use %u not %d.

Signed-off-by: Heinrich Schuchardt