u-boot.git/lib/efi_loader, branch v2021.07-rc3

lib: introduce HASH_CALCULATE option

2021-05-18T10:36:13Z

Build error occurs when CONFIG_EFI_SECURE_BOOT or CONFIG_EFI_CAPSULE_AUTHENTICATE is enabled, because hash-checksum.c is not compiled. Since hash_calculate() implemented in hash-checksum.c can be commonly used aside from FIT image signature verification, this commit itroduces HASH_CALCULATE option to decide if hash-checksum.c shall be compiled. Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt

efi_loader: Fix Kconfig for EFI_TCG2 protocol

2021-05-18T10:36:13Z

EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support Reported-by: Michal Simek Signed-off-by: Ilias Apalodimas Add 'default y'. Reviewed-by: Heinrich Schuchardt

efi_loader: Don't stop EFI subsystem init if installing TCG2 fails

2021-05-18T10:36:13Z

Up to now we are stopping the EFI subsystem if a TPMv2 exists but the protocol fails to install. Now that we've switched the config to 'default y' the sandbox TPM fails, since it doesn't support all the required capabilities of the protocol. Not installing the protocol is not catastrophic. If the protocol fails to install the PCRs will never be extended to the expected values, so some other entity later in the boot flow will eventually figure it out and take the necessary actions. While at it fix a corner case were the user can see an invalid error message when the protocol failed to install. We do have a tcg2_uninit() which we call when the protocol installation fails. There are cases though that this might be called before the configuration table is installed (e.g probing the TPM for capabilities failed). In that case the user will see "Failed to delete final events config table". So stop printing it since it's not an actual failure , simply because the config table was never installed in the first place. In order to stop printing it make efi_init_event_log() and create_final_event() cleanup themselves and only call tcg2_uninit() when the protocol installation fails. Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

efi_loader: Uninstall the TCG2 protocol if logging s-crtm fails

2021-05-18T10:36:13Z

Instead of just failing, clean up the installed config table and EventLog memory if logging an s-crtm event fails during the protocol installation Signed-off-by: Ilias Apalodimas Eliminate label 'out:' by using return. Reviewed-by: Heinrich Schuchardt

efi_loader: Clean up tcg2 once in case of failure

2021-05-18T10:36:12Z

efi_init_event_log() calls tcg2_uninit() in case of failure. We can skip that since the function is called on efi_tcg2_register() which also cleans up if an error occurs Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

efi_loader: loosen buffer parameter check in efi_file_read_int

2021-05-18T10:36:12Z

This is same issue as https://bugzilla.redhat.com/show_bug.cgi?id=1733817, but that fix was wrongly partial reverted. When reading a directory, EFI_BUFFER_TOO_SMALL should be returned when the supplied buffer is too small, so a use-case is to call EFI_FILE_PROTOCOL.Read() with *buffer_size=0 and buffer=NULL to obtain the needed size before doing the actual read. So remove the check only for directory reading, file reading already do the check by itself. Fixes: db12f518edb0("efi_loader: implement non-blocking file services") Signed-off-by: Peng Fan Cc: Stefan Sørensen Tested-by: Peter Robinson Reviewed-by: Heinrich Schuchardt

efi_loader: capsule: Remove the check for capsule_authentication_enabled environment variable

2021-05-18T10:36:12Z

The current capsule authentication code checks if the environment variable capsule_authentication_enabled is set, for authenticating the capsule. This is in addition to the check for the config symbol CONFIG_EFI_CAPSULE_AUTHENTICATE. Remove the check for the environment variable. The capsule will now be authenticated if the config symbol is set. Signed-off-by: Sughosh Ganu Reviwed-by: Heinrich Schuchardt

efi_loader: build warning in efi_tcg2_hash_log_extend_event

2021-05-18T10:36:12Z

Building 32bit boards with the TCG2 protocol enabled leads to a build warning due to a missing conversion. lib/efi_loader/efi_tcg2.c:774:27: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 774 | ret = tcg2_create_digest((u8 *)data_to_hash, data_to_hash_len, | ^ Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas

efi_loader: capsule: return a correct error code at find_boot_device()

2021-04-24T04:53:40Z

In case of failure at efi_get_variable_int("BootOrder"), we should skip examining boot option variables and return an appropriate error code which is the one the function returned. Fixes: CID 331153 Code maintainability issues (UNUSED_VALUE) Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schuchardt

efi: Fix ESRT refresh after Capsule update

2021-04-24T04:53:40Z

Indicated by Coverity Scan CID 331147 The ESRT was being refreshed in situations where the UpdateCapsule procedure failed. In that scenario: 1) the ESRT refresh was superfluous. 2) a failed ESRT refresh return code overwrites the UpdateCapsule error return code. This commit ensures that the ESRT is only refreshed when the UpdateCapsule performs successfully. CC: Heinrich Schuchardt CC: Sughosh Ganu CC: AKASHI Takahiro CC: Tom Rini CC: Andre Przywara CC: nd@arm.com Signed-off-by: Jose Marinho Reviewed-by: Heinrich Schuchardt