u-boot.git/lib/efi_loader, branch v2023.01-rc4

efi: adjust ebbr to v2.1 in conformance profile

2022-12-17T13:37:33+00:00

The EFI Conformance Profile Table entry for EBBR appears in v2.1.0 of the
EBBR specification[1]. Update naming accordingly.

While at it, update the EBBR version referenced in the documentation.

[1]: https://github.com/ARM-software/ebbr/releases/tag/v2.1.0

Signed-off-by: Vincent Stehlé 
Cc: Heinrich Schuchardt 
Cc: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_loader: utility function to check the variable name is "Boot####"

2022-12-02T18:17:25+00:00

Some commands need to enumerate the existing UEFI load
option variable("Boot####"). This commit transfers some code
from cmd/efidebug.c to lib/efi_loder/, then exposes
efi_varname_is_load_option() function to check whether
the UEFI variable name is "Boot####".

Signed-off-by: Masahisa Kojima 
Reviewed-by: Ilias Apalodimas

efi_loader: don't use EFI_LOADER_DATA internally

2022-12-02T18:17:24+00:00

EFI_LOADER_DATA/CODE is reserved for EFI applications.
Memory allocated by U-Boot for internal usage should be
EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE.

Reported-by: François-Frédéric Ozog 
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: François-Frédéric Ozog 
Reviewed-by: Ilias Apalodimas

efi_loader: fix handling of DHCP acknowledge

2022-12-02T18:17:24+00:00

The dhcp command may be executed after the first UEFI command.
We should still update the EFI_PXE_BASE_CODE_PROTOCOL.

Don't leak content of prior acknowledge packages.

Handle failing allocation when calling malloc().

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: add an EFI binary to print boot hart ID

2022-12-02T18:17:24+00:00

Provide an EFI binary that prints the boot hart ID as found in the
device-tree as /chosen/boot-hartid property and as provided by the
RISCV_EFI_BOOT_PROTOCOL.

Signed-off-by: Heinrich Schuchardt

efi_loader: Fix buffer underflow

2022-11-22T10:54:30+00:00

If the array index 'i' < 128, the 'codepage' array is accessed using
[-128...-1] in efi_unicode_collation.c:262. This can lead to a buffer
overflow.

    Negative index in efi_unicode_collation.c:262.

The index of the 'codepage' array should be c - 0x80 instead of i - 0x80.

Fixes: 0bc4b0da7b59 ("efi_loader: EFI_UNICODE_COLLATION_PROTOCOL")
Signed-off-by: Mikhail Ilin 
Reviewed-by: Heinrich Schuchardt

efi_loader: replace a u16_strdup with alloc + memcpy

2022-11-16T07:34:06+00:00

Heinrich reports that on RISC-V unaligned access is emulated by OpenSBI
which is very slow.  Performance wise it's better if we skip the calls
to u16_strdup() -- which in turn calls u16_strsize() and just allocate/copy the
memory directly.  The access to dp.length may still be unaligned, but that's
way less than what u16_strsize() would do

Signed-off-by: Ilias Apalodimas 
Use malloc() instead of calloc().
Reviewed-by: Heinrich Schuchardt

efi_loader: add missing EFI_CALL when closing a file

2022-11-16T07:34:06+00:00

Closing the files uses the EFI protocol and specifically it's .close
callback.  This needs to be wrapped on an EFI_CALL()

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-16T07:34:06+00:00

UEFI specification requires pointers that are passed to protocol member
functions to be aligned.  There's a u16_strdup in that function which
doesn't make sense otherwise  Add a comment so no one removes it
accidentally

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

efi_loader: improve description of efi_file_from_path()

2022-11-16T07:34:06+00:00

Provide a description of the function's logic.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas