u-boot.git/lib/efi_loader, branch v2023.04

efi_loader: remove duplicate assignment

2023-04-01T08:11:50+00:00

Assigning the value of a variable to itself should be avoided.

Addresses-Coverity-ID: 451089 ("Evaluation order violation")
Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
Signed-off-by: Heinrich Schuchardt

efi_loader: correct shortening of device-paths

2023-04-01T08:11:50+00:00

We use short device-paths in boot options so that a file on a block device
can be found independent of the port into which the device is plugged.

Usb() device-path nodes only contain port and interface information and
therefore cannot identify a block device.
UsbWwi() device-path nodes contain the serial number of USB devices.

Signed-off-by: Heinrich Schuchardt

efi_loader: fix device-path for USB devices

2023-03-25T09:43:50+00:00

EFI device paths for block devices must be unique. If a non-unique device
path is discovered, probing of the block device fails.

Currently we use UsbClass() device path nodes. As multiple devices may
have the same vendor and product id these are non-unique. Instead we
should use Usb() device path nodes. They include the USB port on the
parent hub. Hence they are unique.

A USB storage device may contain multiple logical units. These can be
modeled as Ctrl() nodes.

Reported-by: Patrick Delaunay 
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass

efi_loader: support for Ctrl() device path node

2023-03-25T09:43:50+00:00

* Add the definitions for Ctrl() device path nodes.
* Implement Ctrl() nodes in the device path to text protocol.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 
Reviewed-by: Ilias Apalodimas

efi_loader: describe term_get_char()

2023-03-13T12:56:14+00:00

Add a function description.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

efi_loader: update SetVariable attribute check

2023-03-13T12:56:14+00:00

UEFI specification v2.10 says that
EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and
EFI_UNSUPPORTED should be returned in SetVariable variable service.
Current implementation returns EFI_INVALID_PARAMETER,
let's fix the return value.

Together with above change, this commit also updates the SetVariable
attribute check to be aligned with the EDK2 reference implementation.

Signed-off-by: Masahisa Kojima 
Reviewed-by: Heinrich Schuchardt

efi_loader: set CapsuleMax from CONFIG_EFI_CAPSULE_MAX

2023-02-19T20:15:15+00:00

Adds CONFIG_EFI_CAPSULE_MAX to configure the max index value used in
EFI capsule reports. Prior to this change is the hard coded value was
65535 which would exceed available storage for variables. Now the
default value is 15 which should work fine with most systems.

Signed-off-by: Etienne Carriere

efi_loader: Measure the loaded DTB

2023-02-19T20:15:15+00:00

Measures the DTB passed to the EFI application upon new boolean config
switch CONFIG_EFI_TCG2_PROTOCOL_MEASURE_DTB. For platforms where the
content of the DTB passed to the OS can change across reboots, there is
not point measuring it hence the config switch to allow platform to not
embed this feature.

Co-developed-by: Ilias Apalodimas 
Signed-off-by: Ilias Apalodimas 
Signed-off-by: Etienne Carriere 
Tested-by: Ilias Apalodimas 
Reviewed-by: Ilias Apalodimas

efi_loader: fix wrong attribute check for QueryVariableInfo

2023-02-19T20:15:15+00:00

QueryVariableInfo with EFI_VARIABLE_HARDWARE_ERROR_RECORD is
accepted, remove wrong attribute check.

Fixes: 454a9442fbce ("efi_loader: update attribute check for QueryVariableInfo()")
Signed-off-by: Masahisa Kojima 
Reviewed-by: Heinrich Schuchardt

efi_loader: avoid buffer overrun in efi_var_mem_compare

2023-02-19T20:15:15+00:00

We should not scan beyond the end of string name.

Signed-off-by: Heinrich Schuchardt