u-boot.git/lib/efi_loader, branch v2025.04

efi_loader: stop network in EXIT_BOOT_SERVICES

2025-04-06T16:03:22+00:00

It has been reported that memory corruption can occurred because network
packages where received after EXIT_BOOT_SERVICES. See the thread
starting at [1].

We try to remove all drivers when EXIT_BOOT_SERVICES is called. But

* Some network drivers don't call their own stop method when removed.
* Some network drivers don't have a remove method.
* Some devices have CONFIG_DM_DEVICE_REMOVE=n.

Let's call eth_halt() in EXIT_BOOT_SERVICES explicitly.

[1]
https://lore.kernel.org/all/C101B675-EEE6-44CB-8A44-83F72182FBD6@kohlschutter.com/

Cc: Michael Brown 
Reported-by: Christian Kohlschütter 
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Michael Brown 
Reviewed-by: Ilias Apalodimas 
Tested-by: Christian Kohlschütter

efi_loader: fix ipv4 device path node conversion

2025-03-26T11:05:36+00:00

When converting an IPv4 device path node to text, the
EFI_DEVICE_PATH_TO_TEXT_PROTOCOL will produce the following string:

  IPv4(5.6.7.8,TCP,UDP,0x6,DHCP,1.2.3.4,9.10.11.12,255.255.255.0)

This string erroneously contains multiple protocols: TCP, UDP and 0x6.

Add the missing `break' statements in the dp_msging() function to fix this
and obtain the following expected string instead:

  IPv4(5.6.7.8,TCP,DHCP,1.2.3.4,9.10.11.12,255.255.255.0)

Fixes: aaf63429a112 ("efi_loader: add IPv4() to device path to text protocol")
Signed-off-by: Vincent Stehlé 
Cc: Heinrich Schuchardt 
Cc: Ilias Apalodimas 
Cc: Adriano Cordova 
Cc: Tom Rini 
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt 
Reviewed-by: Andre Przywara 
Signed-off-by: Ilias Apalodimas

lmb: change the return code on lmb_alloc_addr()

2025-03-24T17:12:33+00:00

Ben reports a failure to boot the kernel on hardware that starts its
physical memory from 0x0.
The reason is that lmb_alloc_addr(), which is supposed to reserve a
specific address, takes the address as the first argument, but then also
returns the address for success or failure and treats 0 as a failure.

Since we already know the address change the prototype to return an int.

Reported-by: Ben Schneider 
Signed-off-by: Ilias Apalodimas 
Tested-by: Ben Schneider 
Reviewed-by: Sughosh Ganu

efi_loader: Move .dynamic out of .text in EFI

2025-03-17T08:22:06+00:00

EFI applications need to be relocatable. Ordinarily, this is achieved
through a PE-format .reloc section, but since that requires toolchain
tricks to achieve, U-Boot's EFI applications instead embed ELF-flavored
relocation information and use it for self-relocation; thus, the
.dynamic section needs to be preserved.

Before this patch, it was tacked on to the end of .text, but this was
not proper: A .text section is SHT_PROGBITS, while the .dynamic section
is SHT_DYNAMIC. Attempting to combine them like this creates a section
type mismatch. While GNU ld doesn't seem to complain, LLVM's lld
considers this a fatal linking error.

This patch moves .dynamic out to its own section, so that the output ELF
has the correct types. (They're all mashed together when converting to
binary anyway, so this patch causes no change in the final .efi output.)

Signed-off-by: Sam Edwards 
Cc: Heinrich Schuchardt

efi_loader: efi_net: let efi_net_set_dp properly update the device path

2025-02-28T14:25:30+00:00

This commit fixes an use after free introduced in Commit e55a4acb54
(" efi_loader: net: set EFI bootdevice device path to HTTP when loaded
from wget"). The logic in efi_net_set_dp is reworked so that when the
function is invoked it not only changes the value of the static variable
net_dp (this is how the function was implemented in e55a4acb54) but also
updates the protocol interface of the device path protocol in case efi
has started.

Fixes: e55a4acb54e8 ("efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget")
Signed-off-by: Adriano Cordova

efi_loader: make efi_add_memory_map_pg() static

2025-02-20T10:09:33+00:00

The function is only used in the efi_memory.c module.

Reviewed-by: Ilias Apalodimas 
Signed-off-by: Heinrich Schuchardt

lmb: move lmb_map_update_notify() to EFI

2025-02-20T10:09:33+00:00

When building with qemu_arm64_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y
and CONFIG_EFI_LOADER=n an error undefined reference to efi_add_memory_map_pg
occurs.

Move the EFI dependent part of lmb_map_update_notify() to the EFI
sub-system.

Reported-by: Liya Huang <1425075683@qq.com>
Acked-by: Liya Huang <1425075683@qq.com>
Signed-off-by: Heinrich Schuchardt

efi_loader: remove comparisons to string literals from runtime

2025-02-20T08:22:53+00:00

For EFI runtime services, we manage to preserve string literals
by placing the .efi_runtime section just before .data and preserving
it when marking the runtime memory by marking surrounding boottime
code as runtime. This is ok for now but will break if we update any
linker scripts and decouple .text and .runtime sections.

So let's define the strings we used to compare in the appropriate
section for runtime services

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Mark Kettenis

efi_loader: Fix potential deref-after-null

2025-02-20T08:04:12+00:00

After having been compared to a NULL value at efi_disk.c:426,
pointer 'part_info' is dereferenced at efi_disk.c:534.

Signed-off-by: Maks Mishin 
Reviewed-by: Heinrich Schuchardt

tcg2: decouple eventlog size from efi

2025-01-28T06:59:23+00:00

Move default eventlog size from efi to tpm for using in both
efi and measured boot.

Signed-off-by: Raymond Mao 
Reviewed-by: Ilias Apalodimas 
Signed-off-by: Ilias Apalodimas