u-boot.git/lib, branch v2019.04-rc2

efi_loader: do not miss last relocation block

2019-02-16T14:51:14+00:00

If the last block in the relocation table contains only a single
relocation, the current coding ignores it.

Fix the determination of the end of the relocation table.

Signed-off-by: Heinrich Schuchardt

efi_loader: documentation of image loader

2019-02-16T14:48:58+00:00

- Add missing function descriptions.
- Update existing function descriptions to match Sphinx style.
- Add lib/efi_loader/efi_image_loader.c to the input files for Sphinx
  generated documentation.

Signed-off-by: Heinrich Schuchardt

efi_loader: fix EFI entry counting

2019-02-16T14:42:20+00:00

`bootefi selftest` fails on qemu-x86_defconfig if efi_selftest() is not
invoked using EFI_CALL().

Likewise we call the entry point of EFI payloads with
EFI_CALL(efi_start_image()).

entry_count indicates if we are in U-Boot (1) or in EFI payload code (0).
As we start in U-Boot code the initial value has to be 1.

Signed-off-by: Heinrich Schuchardt

efi_loader: use efi_start_image() for bootefi

2019-02-16T14:42:20+00:00

Remove the duplicate code in efi_do_enter() and use efi_start_image() to
start the image invoked by the bootefi command.

Signed-off-by: Heinrich Schuchardt

efi_loader: set entry point in efi_load_pe()

2019-02-16T14:42:20+00:00

Up to now efi_load_pe() returns the entry point or NULL in case of an
error. This does not allow to return correct error codes from LoadImage().

Let efi_load_pe() return a status code and fill in the entry point in the
corresponding field of the image object.

Signed-off-by: Heinrich Schuchardt

efi_loader: LoadImage: always allocate new pages

2019-02-16T14:42:20+00:00

If we want to properly unload images in Exit() the memory should always be
allocated in the same way. As we allocate memory when reading from file we
should do the same when the original image is in memory.

A further patch will be needed to free the memory when Exit() is called.

Signed-off-by: Heinrich Schuchardt

efi_loader: error handling in efi_setup_loaded_image()

2019-02-16T14:42:20+00:00

In case of an error we should set the returned pointers to NULL. This
ensures that an illegal free does not occur even if the caller calls
free() for the handles.

If protocols cannot be installed, release all resources.

Signed-off-by: Heinrich Schuchardt

lib/vsprintf: print '?' for illegal Unicode sequence

2019-02-16T14:42:20+00:00

Commit 0e66c10a7d80 ("lib: vsprintf: avoid overflow printing UTF16
strings") broke the Unicode unit tests: an illegal UTF16 code point
should be printed as '?'.

Fixes: 0e66c10a7d80 ("lib: vsprintf: avoid overflow printing UTF16 strings")
Signed-off-by: Heinrich Schuchardt

efi_selftest: LoadImage from file device path

2019-02-16T14:42:19+00:00

Provide a unit test that calls LoadImage() with a file device path and
executes the application via StartImage().

Signed-off-by: Heinrich Schuchardt

efi_loader: comments for efi_file_from_path()

2019-02-16T14:42:19+00:00

Add more comments for efi_file_from_path().

Signed-off-by: Heinrich Schuchardt