u-boot.git/lib, branch v2019.07-rc2 Unnamed repository; edit this file 'description' to name the repository. efi_loader: ACPI device node to text 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-11T21:11:48+00:00 05fefe768177dee6d5ffa6e95867806adc030c21 The device path to text protocol renders ACPI device nodes incorrectly. Use capital hexadecimal numbers as shown in the UEFI spec examples. Always output the optional UID. This matches what UEFI SCT expects and saves us an `if`. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
The device path to text protocol renders ACPI device nodes incorrectly.

Use capital hexadecimal numbers as shown in the UEFI spec examples.

Always output the optional UID. This matches what UEFI SCT expects and
saves us an `if`.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: infinite recursion notifying events 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-11T19:44:59+00:00 3b985113be63821c799ae6ee98690f740f49a0e9 UEFI SCT uses this call sequence to determine the current TPL level inside notification functions: OldTpl = BS->RaiseTPL(TPL_HIGH_LEVEL); BS->RestoreTPL(OldTpl); In RestoreTPL() we trigger the notification function of queued events. If we do not mark the event as non-queued before calling the notification function, this results in an infinite recursive call sequence. Mark the event as non-queued before entering the notification function. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
UEFI SCT uses this call sequence to determine the current TPL level inside
notification functions:

    OldTpl = BS->RaiseTPL(TPL_HIGH_LEVEL);
    BS->RestoreTPL(OldTpl);

In RestoreTPL() we trigger the notification function of queued events. If
we do not mark the event as non-queued before calling the notification
function, this results in an infinite recursive call sequence.

Mark the event as non-queued before entering the notification function.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: simplify efi_allocate_pages() 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-11T06:43:30+00:00 8ae39857b93edfe697c223fa2f2edfb39d45c98c Replace unnecessary control structures by using return statements. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Replace unnecessary control structures by using return statements.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: AllocateAdress error handling 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-11T06:21:17+00:00 f756fe83b0d6e189dd524346d22f668d0861e573 If AllocatePages() is called with AllocateAddress, the UEFI spec requires to return EFI_NOT_FOUND in case the memory page does not exist. The UEFI SCT II 2017 spec additionally requires to return EFI_NOT_FOUND if the page is already allocated. Check that *Memory refers to an unallocated page. UEFI SCT II (2017): AllocatePages(), 5.1.2.1.9 - 5.1.2.1.10 Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
If AllocatePages() is called with AllocateAddress, the UEFI spec requires
to return EFI_NOT_FOUND in case the memory page does not exist.

The UEFI SCT II 2017 spec additionally requires to return EFI_NOT_FOUND if
the page is already allocated.

Check that *Memory refers to an unallocated page.

UEFI SCT II (2017): AllocatePages(), 5.1.2.1.9 - 5.1.2.1.10

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: out of resources in AllocatePages() 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-11T05:55:05+00:00 735fd22800bbe3177edf1491a26794427541102d According to the UEFI AllocatePages() has to return EFI_OUT_OF_RESOURCES if sufficient memory is not available. Change the return value. UEFI SCT II (2017): 3.2.1 AllocatePages(), 5.1.2.1.8 Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
According to the UEFI AllocatePages() has to return EFI_OUT_OF_RESOURCES if
sufficient memory is not available.

Change the return value.

UEFI SCT II (2017): 3.2.1 AllocatePages(), 5.1.2.1.8

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: check memory address before freeing 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-10T19:21:30+00:00 7d3af58ed9aa84175ed92a901db558f443b33e46 When we call FreePages() we essentially add memory to our memory map. We shouldn't do this for memory that does not exit. Check if the memory that is to be freed via FreePages() or FreePool() is in our memory map and is not EFI_CONVENTIONAL_MEMORY. This check is mandated by the UEFI specification. Cf. UEFI SCT II (2017), 3.2.2 FreePages(), 5.1.2.1 - 5.1.2.2 Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
When we call FreePages() we essentially add memory to our memory map. We
shouldn't do this for memory that does not exit.

Check if the memory that is to be freed via FreePages() or FreePool() is in
our memory map and is not EFI_CONVENTIONAL_MEMORY.

This check is mandated by the UEFI specification.

Cf. UEFI SCT  II (2017), 3.2.2 FreePages(), 5.1.2.1 - 5.1.2.2

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: error code in UninstallProtocolInterface() 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-10T18:06:48+00:00 96aa99cded0096bd6c6ea2919e6884c54c80f095 According to the UEFI specification UninstallProtocolInteface() has to return EFI_NOT_FOUND if the interface is not found. Correct the return value. Cf. UEFI SCT II spec (2017), 3.3.2 UninstallProtocolInterface(), 5.1.3.2.4 Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
According to the UEFI specification UninstallProtocolInteface() has to
return EFI_NOT_FOUND if the interface is not found.

Correct the return value.

Cf. UEFI SCT II spec (2017), 3.3.2 UninstallProtocolInterface(), 5.1.3.2.4

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: superfluous check in efi_remove_protocol() 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-10T17:55:53+00:00 61c63db7fe8af569229cb598b018c65f9ad9c95f efi_search_protocol() already checks that the GUID matches. Don't check a second time. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
efi_search_protocol() already checks that the GUID matches. Don't check
a second time.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: LocateDevicePath() incorrect parameter check 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-10T17:21:41+00:00 ab557141c2ddb9cccffa992651a240b63d5fbf5b A parameter check in LocateDevicePath() does not match the requirements of the UEFI spec. If device is NULL, only return EFI_INVALID_PARAMETER if a matching handle is found. Cf. UEFI SCT II specification (2017)3.3.7 LocateDevicePath(), 5.1.3.7.3 Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
A parameter check in LocateDevicePath() does not match the requirements of
the UEFI spec.

If device is NULL, only return EFI_INVALID_PARAMETER if a matching handle
is found.

Cf. UEFI SCT II specification (2017)3.3.7 LocateDevicePath(), 5.1.3.7.3

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: fix typo in efi_locate_handle() comment 2019-05-12T18:54:22+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2019-05-10T17:03:49+00:00 0a84319665e764ab1c9f619f43c01ef1627f4053 %s/not buffer/no buffer/ Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
%s/not buffer/no buffer/

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>