u-boot.git/lib, branch v2020.07-rc2 Unnamed repository; edit this file 'description' to name the repository. charset: Add support for calculating bytes occupied by a u16 string 2020-05-09T07:30:28+00:00 Sughosh Ganu sughosh.ganu@linaro.org 2020-05-06T19:12:41+00:00 4835d35acfabe9fed464602fb919279036a49236 The current code uses 'u16_strlen(x) + 1) * sizeof(u16)' in various places to calculate the number of bytes occupied by a u16 string. Let's introduce a wrapper around this. This wrapper is used on following patches Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
The current code uses 'u16_strlen(x) + 1) * sizeof(u16)' in various
places to calculate the number of bytes occupied by a u16 string.
Let's introduce a wrapper around this. This wrapper is used on following
patches

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: variable: check a return value of uuid__str_to_bin() 2020-05-09T07:30:27+00:00 AKASHI Takahiro takahiro.akashi@linaro.org 2020-05-08T05:51:21+00:00 b433acbb819e1546ef9493dc3ba97a44b398a9db The only error case is that a given UUID is in wrong format. So just return EFI_INVALID_PARAMETER here. Reported-by: Coverity (CID 300333) Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
The only error case is that a given UUID is in wrong format.
So just return EFI_INVALID_PARAMETER here.

Reported-by: Coverity (CID 300333)
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: image_loader: fix a Coverity check against array access 2020-05-09T07:30:27+00:00 AKASHI Takahiro takahiro.akashi@linaro.org 2020-05-08T05:51:59+00:00 52d7bfe78787c93b95e805b44bb4d746a65edde4 Coverity detected: Using "&opt->CheckSum" as an array. This might corrupt or misinterpret adjacent memory locations. The code should work as far as a structure, IMAGE_OPTIONAL_HEADER(64) is packed, but modify it in more logical form. Subsystem is a member next to CheckSum. Reported-by: Coverity (CID 300339) Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Coverity detected:
  Using "&opt->CheckSum" as an array.  This might corrupt or misinterpret
  adjacent memory locations.

The code should work as far as a structure, IMAGE_OPTIONAL_HEADER(64) is
packed, but modify it in more logical form. Subsystem is a member next to
CheckSum.

Reported-by: Coverity (CID 300339)
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: crypto/pkcs7_parser.h is not a local include 2020-05-07T16:23:18+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2020-05-07T15:57:43+00:00 d7ca3ce3d3b990503cb6e0bafad91aa2a7c96b9d User <> and not "" for referencing a global include. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
User <> and not "" for referencing a global include.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: pkcs7_parse_message() returns error pointer 2020-05-07T16:23:17+00:00 Patrick Wildt patrick@blueri.se 2020-05-07T00:17:14+00:00 6f146155f879ff42d465f0cca8ec2a7f8cb0961e Since pkcs7_parse_message() returns an error pointer, we must not check for NULL. We have to explicitly set msg to NULL in the error case, otherwise the call to pkcs7_free_message() on the goto err path will assume it's a valid object. Signed-off-by: Patrick Wildt <patrick@blueri.se> Add missing include linux/err.h Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Since pkcs7_parse_message() returns an error pointer, we must not
check for NULL.  We have to explicitly set msg to NULL in the error
case, otherwise the call to pkcs7_free_message() on the goto err
path will assume it's a valid object.

Signed-off-by: Patrick Wildt <patrick@blueri.se>
Add missing include linux/err.h
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: efi_variable_parse_signature() returns NULL on error 2020-05-07T16:23:16+00:00 Patrick Wildt patrick@blueri.se 2020-05-07T00:13:18+00:00 9ad15227bb92acc2bf73c60da1bcf2ae3774246d efi_variable_parse_signature() returns NULL on error, so IS_ERR() is an incorrect check. The goto err leads to pkcs7_free_message(), which works fine on a NULL ptr. Signed-off-by: Patrick Wildt <patrick@blueri.se> Reviewed-by: AKASHI Takahiro <takahiro.akashi@linaro.org> 
efi_variable_parse_signature() returns NULL on error, so IS_ERR()
is an incorrect check.  The goto err leads to pkcs7_free_message(),
which works fine on a NULL ptr.

Signed-off-by: Patrick Wildt <patrick@blueri.se>
Reviewed-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
efi_loader: put device tree into EfiACPIReclaimMemory 2020-05-07T16:23:16+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2020-05-06T18:32:31+00:00 42a426e027df472714e8d6209cafac291935c331 According to the UEFI spec ACPI tables should be placed in EfiACPIReclaimMemory. Let's do the same with the device tree. Suggested-by: Ard Biesheuvel <ardb@kernel.org> Cc: Grant Likely <grant.likely@arm.com> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
According to the UEFI spec ACPI tables should be placed in
EfiACPIReclaimMemory. Let's do the same with the device tree.

Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Cc: Grant Likely <grant.likely@arm.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: do not unnecessarily use EFI_CALL() 2020-05-07T16:23:16+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2020-05-05T23:51:04+00:00 306bf6e7ff9b267e4c38f8f38900cb93fa96b62b There is no need to call efi_get_variable() instead of efi_get_variable_common(). So let's use the internal function. Move forward declarations to the top of the file. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
There is no need to call efi_get_variable() instead of
efi_get_variable_common(). So let's use the internal function.

Move forward declarations to the top of the file.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: error handling in efi_set_variable_common(). 2020-05-07T16:23:16+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2020-05-05T23:37:25+00:00 3fdff6be40b01423aacf2c02eb3b4ef6d2186caf Fix unreachable code. Free memory on error. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Fix unreachable code. Free memory on error.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
efi_loader: remove redundant assignment in dp_fill() 2020-05-07T16:23:16+00:00 Heinrich Schuchardt xypron.glpk@gmx.de 2020-05-05T23:28:08+00:00 549b79e8e04930f515ace28556d1cea779a1086a The value of dp is overwritten without being used. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> 
The value of dp is overwritten without being used.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>